Commit Graph
100 Commits
Author SHA1 Message Date
Guo Xiang Tan fb6e7c1e19 Refactor DiscourseSassImporter. 2016-04-19 14:58:03 +08:00
Guo Xiang Tan 95e0948fba FIX: Don't use Uglifier that ships with Sprockets. 2016-04-19 14:29:20 +08:00
Guo Xiang Tan 6a33fcf48e FIX: Do not gzip when using uglifier. 2016-04-19 12:27:51 +08:00
Guo Xiang Tan 9e25e4baa8 [CI SKIP] Typo. 2016-04-18 11:40:04 +08:00
Guo Xiang Tan 21df320f71 FIX: Duplicated file. 2016-04-18 11:18:37 +08:00
Guo Xiang Tan 256d7a00e9 Update sprockets. (#4167)
* Update sass-rails.

* FIX: Tilt dependency has been removed from Ember::Handlebars::Template.

* Update `DiscourseIIFE` to new Sprockets API.

* `Rails.application.assets` returns `nil` in production.

* Move sprockets-rails out of the assets group.

* Pin ember-rails to 0.18.5 which works with Sprockets 3.x.

* Update sprockets to 3.6.0.

* Make `DiscourseSassCompiler` work with Sprockets 3.

* Use `Sass::Rails::SassImporterGlobbing` instead of haxxing our own.

* Moneky patch so that we don't add dependencies for our custom css.

* FIX: Missing class.

* Upgrade ember-handlebars-template.

* FIX: require path needs to share the same root as the folder's path.

* Bump discourse-qunit-rails.

* Update ember-template-compiler.js to 1.12.2.

* `prepend` is private in Ruby 2.0.0.
2016-04-18 10:47:52 +08:00
Guo Xiang Tan 36e3f1f5e4 FIX: Reset state of DiscourseRedis::FallbackHandler in tests. 2016-04-18 10:41:40 +08:00
Guo Xiang Tan c5e0b74321 UX: Increase contrast for mentions on dark theme. 2016-04-18 10:27:08 +08:00
Guo Xiang Tan 7af0e0006f UX: Mentions are not styled on mobile. 2016-04-18 10:26:43 +08:00
Guo Xiang Tan 3af5ab8c2c UX: Dark theme tweaks for edit history. 2016-04-18 10:01:10 +08:00
Guo Xiang Tan 9f264d2477 UX: Dark theme tweaks for Ember.Select. 2016-04-18 09:36:33 +08:00
Guo Xiang Tan 2db42e970d FIX: Autocomplete retriggering when term is blank on keyup. 2016-04-16 23:53:24 +08:00
Guo Xiang Tan 862b4fc9da FIX: DiscourseRedis::FallbackHandler not restricting number of threads spawned. 2016-04-15 17:05:03 +08:00
Guo Xiang Tan 4419d50780 Fix build. 2016-04-14 17:22:26 +08:00
Guo Xiang Tan f95cefd09a FEATURE: Add POP3 timeout error only after 3 failures in a row. 2016-04-14 08:55:19 +08:00
Guo Xiang Tan 4ceb04517f Bump grant emoji job back to default queue. 2016-04-13 08:18:37 +08:00
Guo Xiang Tan 983d64fd56 PERF: N+1 query on badges index. 2016-04-12 17:45:02 +08:00
Guo Xiang Tan ad1d14ecbe FIX: Bump GrantEmoji job to low priority queue and reduce batch size. 2016-04-12 17:05:47 +08:00
Guo Xiang Tan b0ae122fd2 No need to pin eslint to 2.2 anymore. 2016-04-08 15:08:48 +08:00
Guo Xiang Tan 6aa447816d UX: Publish changes to TopicView when Topic is updated. 2016-04-07 16:29:01 +02:00
Guo Xiang Tan 4e7e4cee7d PERF: Rendering crawler's template is expensive. 2016-04-07 16:28:31 +02:00
Guo Xiang Tan 5734c7f3f3 FIX: Don't send rejection mailer to bounced emails. 2016-04-07 22:21:17 +08:00
Guo Xiang Tan 60c21a3393 Extract valid connection types into a constant. 2016-04-07 15:45:42 +08:00
Guo Xiang Tan 48e118a054 DRY up tests. 2016-04-07 15:43:33 +08:00
Guo Xiang Tan 7f6fe8fe13 FIX: Pubsub connections need to be killed too. 2016-04-07 15:30:05 +08:00
Guo Xiang Tan fe54ece35e Merge pull request #4114 from tgxworld/better_logging_for_backfilling_badges
FIX: Better logging when badges fail to backfill.
2016-04-07 13:31:50 +08:00
Guo Xiang Tan 2ecff60af2 FIX: Typos. 2016-04-07 11:52:07 +08:00
Guo Xiang Tan a1add415e5 UX: Quote button covered by youtube info header on mobile. 2016-04-05 16:18:07 +08:00
Guo Xiang Tan d677f852c4 UX: Group notification level dropdown not positioned properly. 2016-04-04 22:54:21 +08:00
Guo Xiang Tan 4c855047c1 Update rails_multisite. 2016-04-04 11:26:29 +08:00
Guo Xiang Tan 1481b3420e Add more logging so that we know what is happening with Redis fallback. 2016-04-01 14:24:09 +08:00
Guo Xiang Tan 2af4e4152e Update Logster. 2016-03-29 14:02:34 +08:00
Guo Xiang Tan 8e4e545929 Bump onebox. 2016-03-29 09:35:22 +08:00
Guo Xiang Tan 6d64b6d39f FIX: Query for category hashtag should be case sensitive. 2016-03-28 11:15:10 +08:00
Guo Xiang Tan c7906d5a74 Merge pull request #4118 from gdpelican/chore/ignore-byebug-history
Add .byebug_history to gitignore
2016-03-28 08:29:28 +08:00
Guo Xiang Tan 9a5ded48cf FIX: Return a proper error message when sync sso fails. 2016-03-26 13:30:15 +08:00
Guo Xiang Tan ef6536453b UX: Logs notice close button not positioned properly. 2016-03-26 11:51:11 +08:00
Guo Xiang Tan 8a8d931688 UX: Buttons not positioned within form. 2016-03-26 10:25:33 +08:00
Guo Xiang Tan 6f16896a2c FIX: Better logging when badges fail to backfill. 2016-03-24 10:10:53 +08:00
Guo Xiang Tan 936b55faad Upgrade Rails to 4.2.6. 2016-03-24 09:31:19 +08:00
Guo Xiang Tan 621372eb7b FIX: Pluralize logs notice message. 2016-03-24 09:14:20 +08:00
Guo Xiang Tan fa56082f94 FIX: Overlapping quote reply button on Android. 2016-03-23 17:49:34 +08:00
Guo Xiang Tan 6dd6bbd509 FIX: Incorrect scope. 2016-03-23 14:30:46 +08:00
Guo Xiang Tan 2862c4e5a3 FIX: Quote reply button was covered by iOS menu. 2016-03-23 13:59:17 +08:00
Guo Xiang Tan 8fea5ad35e Update Logster. 2016-03-22 15:24:11 +08:00
Guo Xiang Tan 5dc5767851 FIX: Assigning wrong value to variable. 2016-03-21 15:18:31 +08:00
Guo Xiang Tan 779f749642 Merge pull request #4066 from tgxworld/update_meta_to_new_rate_limit_api
Update to new rate limit Redis config.
2016-03-21 15:08:00 +08:00
Guo Xiang Tan 54bdcd9b98 Update to new rate limit Redis config. 2016-03-21 14:00:50 +08:00
Guo Xiang Tan bf209d8344 FIX: Redis hostname may resolve to nothing. 2016-03-11 19:06:37 +08:00
Guo Xiang Tan 90fde5053d FIX: Load Redis patch much earlier. 2016-03-11 17:29:00 +08:00
Guo Xiang Tan 89b1998174 Add default port for redis_slave. 2016-03-11 15:07:07 +08:00
Guo Xiang Tan b1e0da2b50 Merge pull request #4056 from tgxworld/redis_failover
FEATURE: Master-Slave Redis configuration with fallback and switch over.
2016-03-11 14:54:02 +08:00
Guo Xiang Tan c07c474575 FEATURE: Master-Slave Redis configuration with fallback and switch over. 2016-03-11 12:18:58 +08:00
Guo Xiang Tan ee8be3d1a8 Merge pull request #4059 from gdpelican/feature/disable-mailing-list-mode
FEATURE: Add site setting for disabling mailing list mode site wide
2016-03-08 16:27:09 +08:00
Guo Xiang Tan db781d3349 FIX: LogsNotice does not have currentUser attribute. 2016-03-08 16:19:42 +08:00
Guo Xiang Tan d783a393ec Fix randomly failing test. 2016-03-08 12:51:51 +08:00
Guo Xiang Tan 322ee3e17c Fix the build. 2016-03-08 11:38:26 +08:00
Guo Xiang Tan 00078a438b FIX: FastImage#size returns nil if it can't fetch the image size. 2016-03-08 11:29:18 +08:00
Guo Xiang Tan fcc86d3a9d FIX: PostgreSQLFallbackHandler was bouncing in and out of readonly. 2016-03-08 10:02:38 +08:00
Guo Xiang Tan bc4087b9bb FIX: RSS description might be nil. 2016-03-07 17:42:17 +08:00
Guo Xiang Tan eb5cee3150 Make ESlint happy. 2016-03-07 17:41:00 +08:00
Guo Xiang Tan 7d92c9c738 FIX: Pin ESlint to 2.2.
See https://github.com/eslint/eslint/issues/5476
2016-03-07 10:27:27 +08:00
Guo Xiang Tan 9d24a00f2e Merge pull request #4055 from tgxworld/fix_topic_view_not_working_in_redis_readonly
FIX: Topic view not working when Redis is readonly.
2016-03-03 08:48:31 +08:00
Guo Xiang Tan 5f8e20aa1d FIX: Topic view not working when Redis is readonly. 2016-03-03 08:26:45 +08:00
Guo Xiang Tan f32f0d6337 Merge pull request #4017 from tgxworld/add_admin_banner_for_logster
FEATURE: Admin Banner when Logster logs is getting flooded.
2016-03-02 23:44:56 +08:00
Guo Xiang Tan fdd6920ae7 FEATURE: Admin Banner when Logster logs is getting flooded. 2016-03-02 22:03:16 +08:00
Guo Xiang Tan b41aa27a84 FEATURE: Support multisite in PostgreSQL fallback adapter. 2016-03-02 21:37:37 +08:00
Guo Xiang Tan bfea842d32 UX: Better error message when logging out in read only mode. 2016-03-01 17:37:50 +08:00
Guo Xiang Tan 39c3f06379 FIX: j keyboard shortcut skipping first post in topic. 2016-03-01 16:47:47 +08:00
Guo Xiang Tan 0172684719 Some fixes for phpbb importer. 2016-03-01 10:21:54 +08:00
Guo Xiang Tan 3ce4e568f4 UX: Double show double hr when there aren't any notifications. 2016-02-29 12:33:11 +08:00
Guo Xiang Tan 9e46690086 Add Permalink to phpbb3 import script. 2016-02-29 11:48:43 +08:00
Guo Xiang Tan 62011a252f FIX: Follow redirects when downloading favicons. 2016-02-25 11:50:34 +08:00
Guo Xiang Tan e8de80de98 FIX: Default to first page when page params is an array. 2016-02-25 11:32:58 +08:00
Guo Xiang Tan 84919ca43a Merge pull request #4036 from tgxworld/fix_nil_class_error
FIX: `Array#first` with block will return the first element if nothin…
2016-02-24 23:22:59 +08:00
Guo Xiang Tan e7cfbfeabb FIX: Array#first with block will return the first element if nothing matches. 2016-02-24 22:34:40 +08:00
Guo Xiang Tan a3fa80847e Return 404 instead 500 when plugin is disabled. 2016-02-24 17:09:30 +08:00
Guo Xiang Tan f89e9024ba FIX: Topic and Post may be nil. 2016-02-24 16:27:28 +08:00
Guo Xiang Tan b500f35d14 Ignore ActionController::UnknownHttpMethod error in logs. 2016-02-24 12:58:23 +08:00
Guo Xiang Tan f2db1a27cf FIX: Make sure we write inside a lock. 2016-02-23 12:10:25 -05:00
Guo Xiang Tan 8dad58ba78 FIX: N+1 query on topics view page. 2016-02-23 12:10:25 -05:00
Guo Xiang Tan c344bd3fd1 FIX: Make sure we write inside a lock. 2016-02-23 23:25:59 +08:00
Guo Xiang Tan ced86aa890 FIX: N+1 query on topics view page. 2016-02-23 16:22:40 +08:00
Guo Xiang Tan 3142eb76dc Revert "FIX: find_by_attribute method in Rails 4.5 is case insensitive."
This reverts commit 2af587005b.
2016-02-22 15:55:48 +08:00
Guo Xiang Tan c852fb83d0 Upgrade Logster. 2016-02-22 15:18:25 +08:00
Guo Xiang Tan ded9dc8734 Merge pull request #4021 from dandv/patch-1
Fix typo: are your sure
2016-02-21 22:09:11 +08:00
Guo Xiang Tan c2018ded5d Revert "SECURITY: Upgrade Sprockets."
This reverts commit 1a0a364503.
2016-02-19 15:55:44 +08:00
Guo Xiang Tan 4858187b0e UX: Don't display span if there is no count. 2016-02-19 15:55:43 +08:00
Guo Xiang Tan afa4e58efd Revert "SECURITY: Upgrade Sprockets."
This reverts commit 1a0a364503.
2016-02-19 15:52:47 +08:00
Guo Xiang Tan 5e329898f6 UX: Don't display span if there is no count. 2016-02-19 15:33:07 +08:00
Guo Xiang Tan c756ddbc2e Merge pull request #4019 from tgxworld/update_sprockets
SECURITY: Upgrade Sprockets.
2016-02-19 15:26:41 +08:00
Guo Xiang Tan 7a261e5e4f UX: Hide close mobile navigation on click. 2016-02-19 15:22:41 +08:00
Guo Xiang Tan 1a0a364503 SECURITY: Upgrade Sprockets.
* Advisory: CVE-2014-7819
* URL: https://groups.google.com/forum/#!topic/rubyonrails-security/doAVp0YaTqY
2016-02-19 10:10:25 +08:00
Guo Xiang Tan 2af587005b FIX: find_by_attribute method in Rails 4.5 is case insensitive.
* https://github.com/rails/rails/pull/23690
2016-02-15 23:05:16 +08:00
Guo Xiang Tan 6fc2d9db3a UX: Fix a bunch of overflowing links on mobile nav. 2016-02-13 00:02:53 +08:00
Guo Xiang Tan b0d2e69cc3 FIX: Update log level to warn. 2016-02-12 15:18:34 +08:00
Guo Xiang Tan f2c64a3580 FIX: Client settings were not being published. 2016-02-11 17:53:30 +08:00
Guo Xiang Tan c7186b1403 FIX: Close autocomplete is term is blank. 2016-02-10 19:50:58 +08:00
Guo Xiang Tan 39aaa181e1 FIX: Category hashtag is cooked incorrectly. 2016-02-10 17:08:57 +08:00
Guo Xiang Tan ee38572be3 UX: Set max-width on category column to trigger overflow. 2016-02-10 16:34:43 +08:00