dependabot-preview[bot]
eaf516a5ad
Build(deps-dev): Bump shoulda-matchers from 4.2.0 to 4.3.0 ( #8989 )
...
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers ) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases )
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/NEWS.md )
- [Commits](https://github.com/thoughtbot/shoulda-matchers/compare/v4.2.0...v4.3.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2020-02-19 13:41:38 -05:00
Dan Ungureanu
fd1e04ba0a
UX: Improve small buttons appearance ( #8990 )
...
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Kris <kris.aubuchon@discourse.org>
2020-02-19 12:38:46 -05:00
Penar Musaraj
6be685ac67
DEV: Find/replace deprecated decorators
2020-02-19 11:49:56 -05:00
David Taylor
8ec2d8a814
FIX: Disable save button for API key creation when invalid ( #9005 )
2020-02-19 16:33:09 +00:00
David Taylor
836ab73d59
FIX: Patch ActiveRecord SchemaCache for safe concurrency support
...
A single SchemaCache instance is maintained by the connection pool, and made available via a schema_cache method on each connection. When the SchemaCache instance is fetched from the pool, its internal connection reference is updated to equal the requesting connection. However, since there is only one instance of SchemaCache, this internal connection reference is updated everywhere, and can ultimately result in multiple threads accessing the same database connection. In Discourse, this could result in Sidekiq jobs getting 'stuck' in database connections.
This patch modifies SchemaCache so that it caches the internal connection on a per-thread basis
Co-authored-by: Sam Saffron <sam.saffron@gmail.com>
Co-authored-by: Matt Palmer <mpalmer@hezmatt.org>
2020-02-19 16:26:02 +00:00
Kris
fdb45f2ba1
Follow-up padding fix for de559f3
2020-02-19 11:24:45 -05:00
Kris
de559f3fe3
FIX: Remove border-box from modal-body to avoid iOS fixed position bug
2020-02-19 11:08:15 -05:00
Robin Ward
c954d083df
Link website when reviewing users
2020-02-19 10:18:05 -05:00
Joffrey JAFFEUX
74f2d48018
FIX: makes setting-object capable of defining value/name properties itself ( #9003 )
2020-02-19 10:01:21 +01:00
Joffrey JAFFEUX
30e2867547
FIX: prevents setting default values on setting component to reload page
...
This would happen when clicking on "add all themes" for example.
2020-02-19 09:04:57 +01:00
jjaffeux
32b3f55ef6
Revert "FIX: enums should be treated as flat arrays ( #8995 )"
...
This reverts commit 05be9beefd
2020-02-19 07:53:29 +01:00
Matt Palmer
377d2d3fad
DEV: Silence spurious rubocop lint warning
2020-02-19 13:10:30 +11:00
Matt Palmer
a14a7f1cb8
DEV: Add optional support for running byebug when a PG Clash happens
...
Tracking down concurrency issues from backtraces and manual repros is a fraught process.
Sometimes you've just got to get your hands dirty and do a live debug.
2020-02-19 12:50:37 +11:00
Jarek Radosz
9f8a27a132
DEV: Import makeArray from discourse-common instead using Ember global ( #8977 )
2020-02-19 00:57:58 +01:00
Joffrey JAFFEUX
25ebfd5998
DEV: allows to import isPresent ( #8993 )
2020-02-18 23:41:15 +01:00
Joffrey JAFFEUX
8f82d790d4
FIX: prevents notifications button to be cutoff on mobile ( #8998 )
2020-02-18 23:40:10 +01:00
Joffrey JAFFEUX
05be9beefd
FIX: enums should be treated as flat arrays ( #8995 )
2020-02-18 23:25:12 +01:00
Joffrey JAFFEUX
67ee79f023
FIX: group members dropdown was broken on mobile ( #8994 )
2020-02-18 23:23:38 +01:00
Vinoth Kannan
7a054fc142
FIX: remove anchors from banner headings.
...
Else it will create UX issues when the banner is visible on top of the banner topic.
2020-02-19 02:55:04 +05:30
Robin Ward
53054b41d2
FIX: Mentions updater should work regardless of .notify
2020-02-18 16:02:26 -05:00
Robin Ward
041168c9b6
FIX: Group mentions were not being cooked the same was as previewed
...
If a group mention could be notified on preview it was given an `<a>`
tag with the `.notify` class. When cooked it would display differently.
This patch makes the server side cooking match the client preview.
2020-02-18 15:45:02 -05:00
Robin Ward
163cbb4aa7
UX: Show mentions properly in small post messages
2020-02-18 14:38:33 -05:00
Penar Musaraj
8a0abafc9d
UX: Adjust width for topic notifications dropdown on mobile
...
Previously, the dropdown was set to 400px wide, which exceeds the available width on many mobile devices.
2020-02-18 14:17:34 -05:00
David Taylor
0b09f5299d
DEV: Improve pg connection access logging
...
`ensure` that the accessing thread is set to nil after an action
2020-02-18 16:58:47 +00:00
Joffrey JAFFEUX
99746c2850
FIX: ensures report-filter/category is correctly filtering ( #8992 )
2020-02-18 17:37:43 +01:00
David Taylor
ea49ca7ef5
DEV: Handle nil backtraces in pg access logs
2020-02-18 15:45:44 +00:00
David Taylor
2bdd1275ce
DEV: Initialize pg access log mutex in non-sidekiq processes
...
Followup to be3e4ab3f5
2020-02-18 14:20:28 +00:00
Roman Rizzi
9441362c72
FEATURE: Support uploading a csv with either user emails or usernames ( #8971 )
2020-02-18 10:53:12 -03:00
David Taylor
be3e4ab3f5
DEV: Report simultaneous use of PG::Connection objects
2020-02-18 13:50:15 +00:00
Dan Ungureanu
66893c020f
FIX: Use 'hostname' when Discourse.os_hostname is not available
...
This may be the case when DiscourseLogstashLogger is initialized before
the application (see unicorn.conf.rb)
This commit is a follow-up to 28292d2759
2020-02-18 13:37:39 +02:00
Dan Ungureanu
59db2811b0
FIX: Disable poll options if user groups do not allow them ( #8987 )
2020-02-18 12:13:19 +02:00
Martin Brennan
5122826bde
Rubocop lint
2020-02-18 15:13:34 +10:00
Martin Brennan
500185dc11
Try fix upload_spec flakys and remove logging from tasks/uploads_spec
2020-02-18 15:08:58 +10:00
Sam Saffron
64b3512084
DEV: use DiskSpace module for all disk space calculations
...
This normalizes it so we only carry one place for grabbing disk space size
It also normalizes the command made so it uses Discourse.execute_command
which splits off params in a far cleaner way.
2020-02-18 15:13:19 +11:00
Sam Saffron
28292d2759
PERF: avoid shelling to get hostname aggressively
...
Previously we had many places in the app that called `hostname` to get
hostname of a server. This commit replaces the pattern in 2 ways
1. We cache the result in `Discourse.os_hostname` so it is only ever called once
2. We prefer to use Socket.gethostname which avoids making a shell command
This improves performance as we are not spawning hostname processes throughout
the app lifetime
2020-02-18 15:13:19 +11:00
Martin Brennan
cfd56e9159
Include access control post when loading uploads in rake task
...
* to avoid N+1 query
2020-02-18 10:35:15 +10:00
Sam Saffron
59a7afbde9
DEV: flag MRI specific gems
...
byebug, ruby-prof, better_errors and rbtrace are very MRI specific, flag
them as such
This helps move forward on potential jruby and truffleruby experiments
2020-02-18 11:04:56 +11:00
Kris
ca9a5b8458
Increase topic breakpoint width to avoid small range where layout wraps
2020-02-17 16:04:24 -05:00
OsamaSayegh
3e7c4dcc57
DEV: Bump Logster version to 2.6.3
...
This version includes a fix for a bug where env wouldn't show up if
filter messages by a search term.
2020-02-17 22:52:18 +03:00
Kris
1e20bdec57
UX: Keep mobile composer category and tag inputs on one line
2020-02-17 13:55:04 -05:00
Penar Musaraj
708190802c
FIX: Strip video oneboxes from excerpts
...
Follows up on 49843f327e
2020-02-17 13:52:23 -05:00
David Taylor
cd3fab9ccc
DEV: Allow raw PG tracing to be enabled only for sidekiq processes
2020-02-17 18:14:14 +00:00
Kris
42729e6a27
Minor mobile alignment fixes
2020-02-17 13:00:31 -05:00
Kris
0c94e7b089
FIX: Some select-kit dropdowns were cut-off by hidden overflow in modals
2020-02-17 11:51:26 -05:00
romanrizzi
17aed8d84b
DEV: Add a test to make sure that flagged replies are ignored when calling the delete_and_agree_replies method
2020-02-17 13:31:01 -03:00
David Taylor
0c6f2892c6
DEV: Add raw PG connection tracing behind an environment variable
...
This should be useful for debugging connection problems. Warning: this will generate some large files, and will likely impact performance
2020-02-17 16:21:26 +00:00
Joffrey JAFFEUX
72b6f908f4
UX: minor tweaks to poll builder UI ( #8985 )
2020-02-17 11:02:44 -05:00
Vinoth Kannan
2e397c78c4
FIX: use separate site attribute for single category "top tags" list.
...
And use it only in the single category pages.
38dd184a16
2020-02-17 21:09:27 +05:30
romanrizzi
330d1ae9bc
DEV: Correct test names
2020-02-17 11:47:18 -03:00
David Taylor
f1f9648e88
Revert "FIX: sk body should follow wrapper width ( #8984 )"
...
This was causing very narrow dropdowns in the composer and notification level dropdowns.
This reverts commit d33aaa0292
2020-02-17 13:10:26 +00:00
