Commit Graph
100 Commits
Author SHA1 Message Date
Guo Xiang Tan 115a1c8680 FIX: Sort is destructive and that is not what we want. 2017-01-16 23:42:31 +08:00
Guo Xiang Tan 74d73f9e06 Merge pull request #4658 from tgxworld/fix_editing_poll_options_with_votes
FIX: Votes lost when editing a poll option with votes.
2017-01-16 23:38:58 +08:00
Guo Xiang Tan 8c4dfdfa40 FIX: Votes lost when editing a poll option with votes. 2017-01-16 22:51:57 +08:00
Guo Xiang Tan d4b2a635c7 FIX: Live updates for polls was broken. 2017-01-16 16:57:46 +08:00
Guo Xiang Tan 63954c1b33 FIX: Same user record being saved twice causing validation to fail. 2017-01-16 16:41:03 +08:00
Guo Xiang Tan e3b6f9b8ae FIX: Do not update user stats like counts for private messages. 2017-01-16 11:07:53 +08:00
Guo Xiang Tan ed5fa20b0c Revert "FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level"
This reverts commit 9c40657ba4.

Calling this whenever a user is initialize is hurting us bad
on performance.
2017-01-16 09:44:10 +08:00
Guo Xiang Tan b2162b910b Update rbtrace to work on 2.4.0. 2017-01-16 08:06:09 +08:00
Guo Xiang Tan b5d65d8dda Remove lines that are no longer valid. 2017-01-13 09:51:09 +08:00
Guo Xiang Tan 0f574f641e UX: Truncate topic link title/URL on desktop to prevent overflow. 2017-01-12 12:24:39 +08:00
Guo Xiang Tan 38496985ef Fix syntax error. 2017-01-12 10:03:37 +08:00
Guo Xiang Tan 23d4435af1 Oops. 2017-01-12 09:56:20 +08:00
Guo Xiang Tan 79c80f9974 Make mention bot assign reviewers for collaborators as well. 2017-01-12 09:44:22 +08:00
Guo Xiang Tan d0e3312d92 Merge pull request #4646 from tgxworld/log_readonly_mode_changes
FEATURE: Log admin action when readonly mode is changed.
2017-01-12 09:43:51 +08:00
Guo Xiang Tan 515f50e42e FEATURE: Log admin action when readonly mode is changed. 2017-01-12 09:41:02 +08:00
Guo Xiang Tan d6bf5b0e78 Use any orientation for web app manifest. 2017-01-11 17:32:24 +08:00
Guo Xiang Tan 1758af9a1d FIX: Perform emoji unescape for topic titles in quotes. 2017-01-11 17:23:13 +08:00
Guo Xiang Tan cdd550e947 Use a different Redis key when PG failover sets site to readonly mode. 2017-01-11 16:38:49 +08:00
Guo Xiang Tan 77045eb1f1 Merge pull request #4644 from olach/tab-size
Display tabs with smaller widths for code blocks
2017-01-11 14:49:16 +08:00
Guo Xiang Tan 429b02a5d5 oops fix specs. 2017-01-09 17:08:24 +08:00
Guo Xiang Tan 3d21ccd4a5 FIX: Add validation to disallow censored words in topic title. 2017-01-09 16:55:41 +08:00
Guo Xiang Tan cbc6aee137 UX: Display large numbers with delimiters. 2017-01-09 15:56:02 +08:00
Guo Xiang Tan 00bd782dad Merge pull request #4634 from lex111/patch-1
Update copyright year
2017-01-09 15:00:07 +08:00
Guo Xiang Tan aa9ac0d8b2 Make eslint happy. 2017-01-09 13:59:00 +08:00
Guo Xiang Tan fed7218deb UX: Observe changes to plugin to hide/show plugin admin link without refresh. 2017-01-09 13:56:15 +08:00
Guo Xiang Tan e721e31699 FIX: Login modal on mobile does not submit on enter. 2017-01-09 13:20:53 +08:00
Guo Xiang Tan e89fc5f483 Revert "Run Travis against 2.4.0 as well."
This reverts commit 0000de9501.
2017-01-09 12:21:53 +08:00
Guo Xiang Tan 98df6db0eb FIX: Respect site setting to hide username in mailing list summary. 2017-01-09 12:18:30 +08:00
Guo Xiang Tan 4a7d6ea751 Make eslint happy. 2017-01-09 11:24:55 +08:00
Guo Xiang Tan c260a4e34d FIX: Can't add categories when creating a new web hook. 2017-01-09 11:22:35 +08:00
Guo Xiang Tan 95d1ad1ab8 Fix typo. 2017-01-09 10:13:15 +08:00
Guo Xiang Tan 0000de9501 Run Travis against 2.4.0 as well. 2017-01-09 10:07:01 +08:00
Guo Xiang Tan d793a0fbfc Fix JS tests. 2017-01-06 16:00:29 +08:00
Guo Xiang Tan 58f3a2e9a9 Fix randomly failing spec. 2017-01-06 15:25:49 +08:00
Guo Xiang Tan 1cb09aec49 FIX: Suppress error when acccess is invalid. 2017-01-06 13:18:04 +08:00
Guo Xiang Tan 389e1d0bd5 Add acceptance JS tests for group membership button. 2017-01-06 11:56:10 +08:00
Guo Xiang Tan a4e7657bbf FIX: Missing action to show login modal on group page. 2017-01-06 11:40:32 +08:00
Guo Xiang Tan 68300f515c FIX: Return 404 if id is not valid. 2017-01-06 10:39:44 +08:00
Guo Xiang Tan d10fe51b72 Fix broken specs since all urls will be oneboxed. 2017-01-06 10:05:51 +08:00
Guo Xiang Tan f473a119ff Remove unnecessary stub. 2017-01-06 08:53:30 +08:00
Guo Xiang Tan a1aeedde53 FIX: Text selection disappearing when lazyYT is applied. 2017-01-05 12:06:07 +08:00
Guo Xiang Tan 5098baee2f FIX: Undefined variable. 2017-01-04 17:37:23 +08:00
Guo Xiang Tan 43d950f813 FIX CSS for autocomplete. 2017-01-04 12:37:02 +08:00
Guo Xiang Tan dfc8178308 Revert "FIX: Wait 30 days before dropping the column."
This reverts commit ffc97f2298.

Should be safe now since we didn't get any reports.
2017-01-04 11:56:43 +08:00
Guo Xiang Tan 43671b1fda UX: Display group fullname in mention autocomplete. 2017-01-04 11:40:14 +08:00
Guo Xiang Tan a89f60b85b Merge pull request #4631 from tgxworld/prevent_users_from_changing_permissions_of_non_real_users
FIX: Do not allow admins to meddle with admin and moderation access o…
2017-01-04 09:10:27 +08:00
Guo Xiang Tan a9a0e626db FIX: Group page tabs not displaying for normal users. 2017-01-03 17:56:13 +08:00
Guo Xiang Tan c68bcfeb72 Improve spec. 2017-01-03 15:36:36 +08:00
Guo Xiang Tan ad4a96d387 FIX: Only send membership request to the last 5 active group owners. 2017-01-03 15:33:57 +08:00
Guo Xiang Tan 7ce4bc2e90 UX: Show spinning icon while group members load. 2017-01-03 14:58:14 +08:00
Guo Xiang Tan 3aed15c99e FIX: Group membership button now showing properly. 2017-01-03 14:36:56 +08:00
Guo Xiang Tan 761d524024 Merge pull request #4602 from tgxworld/fix_likes_being_quoted
FIX: Only quote `.cooked` text.
2017-01-03 14:02:21 +08:00
Guo Xiang Tan 8a4e9c1940 Merge pull request #4633 from xfalcox/resize-emoji-full-path
FIX: Use full path for emoji resize job
2017-01-03 14:00:00 +08:00
Guo Xiang Tan 980cea7081 FIX: Add length validation for User#name. 2017-01-03 13:42:33 +08:00
Guo Xiang Tan 1cf0401e26 Allow option to not include title on emoji images. 2017-01-03 11:07:55 +08:00
Guo Xiang Tan ecb1078343 FIX: user-card-post-names outlet should be a div. 2017-01-03 10:39:41 +08:00
Guo Xiang Tan 40deef32e3 UX: Automatic width for fontawesome icons on groups page. 2017-01-03 10:07:59 +08:00
Guo Xiang Tan c8553315b4 UX: Add min-width to .select2-container. 2016-12-30 14:38:53 +08:00
Guo Xiang Tan c554a20c5e Run specs for canned replies as well. 2016-12-30 14:17:36 +08:00
Guo Xiang Tan dbd0fcc86d UX: Add border to .modal-header on mobile. 2016-12-30 13:58:37 +08:00
Guo Xiang Tan f1beef43a8 Merge pull request #4618 from tgxworld/fix_invalid_emails
FIX: Don't allow invalid email to be saved.
2016-12-30 07:11:48 +08:00
Guo Xiang Tan 7d307d6f29 Fix incorrect site setting. 2016-12-29 14:03:47 +08:00
Guo Xiang Tan 6d00650972 Fix JS tests. 2016-12-29 13:47:11 +08:00
Guo Xiang Tan a481bf048f FIX: Incorrect membership action buttons shown for non logged in users. 2016-12-29 12:51:36 +08:00
Guo Xiang Tan 3c4920d234 FIX: Group admin tabs showing for non logged in users. 2016-12-29 11:52:07 +08:00
Guo Xiang Tan 2165d0241e FIX: Only quote .cooked text. 2016-12-29 11:33:36 +08:00
Guo Xiang Tan c7b151683d FIX: Do not allow admins to meddle with admin and moderation access of non real users. 2016-12-29 11:11:33 +08:00
Guo Xiang Tan d46b0a7251 Merge pull request #4625 from caugner/patch-3
FIX: Add missing translation for Settings category 'groups'
2016-12-26 07:07:17 +08:00
Guo Xiang Tan 5aee2673c7 FIX: Push null fields to last when sorting group members. 2016-12-22 14:55:24 +08:00
Guo Xiang Tan 5605700fa9 UX: Sort groups by name. 2016-12-22 14:46:20 +08:00
Guo Xiang Tan 6955c39c68 UX: Fix width on avatar flair. 2016-12-22 14:30:49 +08:00
Guo Xiang Tan 8551d821a0 FEATURE: Add site setting to disable group directory. 2016-12-22 14:14:22 +08:00
Guo Xiang Tan 96c70c74a1 Merge pull request #4619 from tgxworld/group_page_design
UX: Redesign group page to follow user page.
2016-12-22 13:42:28 +08:00
Guo Xiang Tan a5fead3857 UX: Redesign group page to follow user page. 2016-12-22 13:08:59 +08:00
Guo Xiang Tan ed72920444 Make eslint happy. 2016-12-22 11:46:15 +08:00
Guo Xiang Tan 288e5faf6b FIX: Sort needs to be stable. 2016-12-22 11:45:41 +08:00
Guo Xiang Tan 28befcb5d4 Fix specs. 2016-12-21 21:21:39 +08:00
Guo Xiang Tan c897e5599a FIX: Group mobile nav not updating. 2016-12-21 21:16:52 +08:00
Guo Xiang Tan a37a6f57d9 FIX: Automatic groups should be editable via groups page. 2016-12-21 21:11:49 +08:00
Guo Xiang Tan 5e75d5c1bf PERF: N+1 query on groups page. 2016-12-21 20:59:09 +08:00
Guo Xiang Tan 076a08d8e1 FIX: Unactivated users should not be automatically added into groups as well. 2016-12-21 18:15:01 +08:00
Guo Xiang Tan 7228081820 FIX: Automatic group membership should not add staged or unactivated users. 2016-12-21 18:04:26 +08:00
Guo Xiang Tan 13c6191e89 FIX: Don't allow invalid email to be saved. 2016-12-21 17:47:11 +08:00
Guo Xiang Tan 12407484d8 Merge pull request #4601 from ibnesayeed/clean-mailcatcher
Removed the fallback mailcatcher install command
2016-12-21 17:43:02 +08:00
Guo Xiang Tan 73c98e48a3 Merge pull request #4610 from tgxworld/start_running_vaccum
Revert "Don't vacuum for a long time until we fix it"
2016-12-21 17:41:41 +08:00
Guo Xiang Tan 5d7f3223f0 SECURITY: Users can only bookmark posts which they can see. 2016-12-21 12:01:26 +08:00
Guo Xiang Tan 6461021046 FIX: Only show membership status on index page. 2016-12-20 15:50:12 +08:00
Guo Xiang Tan 9db5d5b6a7 FIX: Incorrect serializer for groups page. 2016-12-20 15:44:22 +08:00
Guo Xiang Tan 7c7c233c1c FIX: Can't update Groups#allow_membership_requests in admin. 2016-12-20 15:14:35 +08:00
Guo Xiang Tan c15bf62b43 FIX: Display empty message when no groups can be shown. 2016-12-20 14:47:39 +08:00
Guo Xiang Tan 502e114c60 FIX: Incorrect count when loading more groups. 2016-12-20 14:39:44 +08:00
Guo Xiang Tan 193f8301a4 FIX: Do not show automatic groups to normal users. 2016-12-20 14:26:49 +08:00
Guo Xiang Tan 375f3feeb8 FIX: Topic featured links not getting oneboxed immediately. 2016-12-20 10:27:12 +08:00
Guo Xiang Tan 1df8c7a4b6 Revert "Don't vacuum for a long time until we fix it"
This reverts commit 88712bc548.
2016-12-20 09:10:08 +08:00
Guo Xiang Tan 5058911a7b Merge pull request #4616 from tgxworld/fix_safe_mode_redirect
FIX: Incorrect path for redirect.
2016-12-19 19:02:39 +08:00
Guo Xiang Tan 18c8323987 FIX: Incorrect path for redirect. 2016-12-19 18:12:15 +08:00
Guo Xiang Tan 51679ef6b2 Fix JS tests. 2016-12-17 00:51:40 +08:00
Guo Xiang Tan d8541c589a FIX: Incorrect route for updating username. 2016-12-17 00:23:12 +08:00
Guo Xiang Tan e3213f127d FIX: Regression with request membership button after migrating to component. 2016-12-16 16:07:11 +08:00
Guo Xiang Tan ffc97f2298 FIX: Wait 30 days before dropping the column.
* Regressions from the past is resulting in `logo_url` with
  no uploads record.
2016-12-15 22:45:04 +08:00