IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-14 06:55:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
41,402 Commits 976 Branches 574 Tags
fa393b295624534b7de9db8469cd33d4ab2d3d21
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Arpit Jalan e53b474557 FIX: allow moderators to access /admin/customize/watched_words (#12816) 
Moderators were unable to access `/admin/customize/watched_words`
feature. This was regressed in https://github.com/discourse/discourse/commit/61860098d979933348dd95e144d1b9ccec1fcdd8
 2021-04-23 18:51:45 +05:30
Arpit Jalan 1e9301d4d8 UX: do not pre-select blank tag on append tags bulk action (#12801) 
UX: show progress screen only when more than 20 topics are selected
 2021-04-22 20:32:15 +05:30
Arpit Jalan 271a372e3d FIX: when a flag is handled archive message for moderator group (#12798) 
When a user flags a post with the “Something Else” option, a PM between
the user and the moderators group is created. If no moderators reply to
the PM, when the flag is handled at /review, an auto-reply is created
for the PM. However, the PM is not archived, it stays in the inbox.

This commit ensures that the PM is archived for moderator group when no
moderator has replied to that PM.
 2021-04-22 15:53:44 +05:30
Arpit Jalan e54b5dadab UX: show error message instead of disabling save button on tag groups page (#12767) 
https://meta.discourse.org/t/unable-to-rename-tag-groups-title-save-button-stays-grayed-out/172293/
 2021-04-20 21:40:02 +05:30
Arpit Jalan af6d0342b6 FIX: user group message route should not be case-sensitive (#12753) 2021-04-20 10:25:31 +05:30
Arpit Jalan 21664d8a1c DEV: add JS test for topic bulk action modal (#12621) 2021-04-07 06:34:36 +05:30
Arpit Jalan 6234d7455b FEATURE: add maximum limit for secondary emails (#12599) 2021-04-05 20:31:42 +05:30
Arpit Jalan b230c30249 FIX: downloading watched words was broken (#12578) 2021-04-02 23:04:35 +05:30
Arpit Jalan 3db08c073b FIX: "confirm new email" emails were failing for EmailChangeRequest records with blank requested_by_user_id field (#12579) 2021-04-01 16:39:28 +05:30
Arpit Jalan 61860098d9 UX: move logs/watched_words to customize/watched_words in admin section (#12571) 
https://meta.discourse.org/t/where-is-auto-tag-and-auto-replace/184261
 2021-04-01 11:44:17 +05:30
Arpit Jalan c478ffc662 FIX: post merging was failing silently (#12566) 
https://meta.discourse.org/t/merging-very-long-posts-removes-them/183597
 2021-04-01 06:46:18 +05:30
Arpit Jalan edcb5f77da FIX: remove @discobot likes feature on public topics (#12522) 
https://meta.discourse.org/t/discobot-is-breaking-the-meaning-of-likes-on-my-community/183804/8?u=techapj
 2021-03-25 18:23:55 +05:30
Arpit Jalan c449bf77b3 FIX: new-topic route with sub-category and tags were broken (#12503) 
https://meta.discourse.org/t/complex-url-for-creating-new-topics-results-in-server-side-error/184067/4?u=techapj
 2021-03-24 19:54:29 +05:30
Arpit Jalan dc73aadbff FIX: bulk "archive" and "move to inbox" for group messages was broken (#12488) 2021-03-23 21:34:47 +05:30
Arpit Jalan 64d2f260a9 FIX: do not convert format for site setting uploads (#12410) 2021-03-16 20:14:41 +05:30
Arpit Jalan 3eb769d03b UX: respect "prioritize username in ux" setting wherever possible (#12357) 
This commit ensures that "prioritize username in ux" setting is
respected in following places:

- user directory
- user summary
- badge detail
- group detail
 2021-03-11 21:55:14 +05:30
Arpit Jalan ae70a23525 FIX: ignore enter key press on "move to existing post" search field (#12210) 
UX: do not set focus on auto-selected radio option
 2021-02-25 23:41:12 +05:30
Arpit Jalan 93a0a906b5 FIX: allow adding user to PM when inviter is in allowed list (even (#12212) 
though other participants are not in allowed list)

If you create an allowlist of users who can PM you, and use the function
“Only specific users can send me private messages”, then you can’t be
added to group messages unless everyone in that message is already in
your allow list.

This commit allows user to be added to a group message even when other
participants are not in allowed list
 2021-02-25 22:56:49 +05:30
Arpit Jalan 73fa4263fb FIX: log warning when context is missing when a user is destroyed (#12182) 2021-02-23 16:47:54 +05:30
Arpit Jalan f75e1867ff FIX: do not send rejection emails to auto-deleted reviewable users (#12160) 
FIX: add context when user is deleted via auto handle queued reviewable
FIX: do not delete email_log when a user is deleted
 2021-02-22 18:37:47 +05:30
Arpit Jalan a174c8b8d4 FIX: hide sso payload behind a button click and log views (#12110) 2021-02-17 21:27:51 +05:30
Arpit Jalan 94036a6f49 FIX: force refresh staff action logs when transitioning from site settings (#12096) 2021-02-17 00:18:39 +05:30
Arpit Jalan 2aac657da7 DEV: fix flaky specs in ExportUserArchive (#12095) 2021-02-16 16:35:47 +05:30
Arpit Jalan 85c4e8fd32 FEATURE: support mark tag (#12088) 
This commit adds support for `mark` tag for highlighting text content.
 2021-02-15 21:47:30 +05:30
Arpit Jalan c256b94ae0 UX: when auto-selecting topic make sure the focus is on selected topic (#12083) 2021-02-15 16:12:45 +05:30
Arpit Jalan 901d6080df FIX: do not show SSO last payload to moderators (#12084) 2021-02-15 16:12:06 +05:30
Arpit Jalan 46e7d303b1 FEATURE: when moving posts to existing topic auto-select single topic (#12064) 2021-02-12 23:11:20 +05:30
Arpit Jalan 12b57c0dee FEATURE: Add "Recently read topics" tab to user activity page (#12047) 2021-02-11 22:36:50 +05:30
Arpit Jalan 309adb82ba UX: add a confirmation modal to "Remove All Tags" action (#11973) 
UX: update label for "Remove Tags" action
 2021-02-04 18:30:01 +05:30
Arpit Jalan 06225abe93 FIX: process new invites when existing users are already group members (#11971) 
If a list of email addresses is pasted into a group’s Add Members form
that has one or more email addresses of users who already belong to the
group and all other email addresses are for users who do not yet exist
on the forum then no invites were being sent. This commit ensures that
we send invites to new users.
 2021-02-04 15:36:08 +05:30
Arpit Jalan 7f86a310ef FEATURE: check blocked_onebox_domains setting for inline oneboxes (#11944) 2021-02-03 21:45:22 +05:30
Arpit Jalan 15b5bd4e14 UX: show onebox error preview image as favicon (#11810) 2021-01-22 20:05:28 +05:30
Arpit Jalan e81d93cf26 UX: specify width and height for onebox preview error image (#11807) 2021-01-22 19:02:23 +05:30
Arpit Jalan 869d25b7d3 DEV: add specs for Vanilla import script improvements (#11712) 2021-01-16 19:35:19 +05:30
Arpit Jalan bd7cbcd8f8 Improve Vanilla import script. (#11701) 
- import groups and group users
- import uploads/attachments
- improved code tag parsing
- improved text formatting
- mark topics as solved
 2021-01-13 23:10:00 +05:30
Arpit Jalan 25b4e82601 FEATURE: allow disabling self-deletions of posts (#11668) 
https://meta.discourse.org/t/restoring-deleted-messages/173647/6?u=techapj
 2021-01-08 20:35:13 +05:30
Arpit Jalan 357d698557 DEV: add support for macOS in bundler (#11600) 
see: https://github.com/discourse/discourse/commit/39ba1ae2b52fbb4ec03df390a4516e2b2414c315
 2020-12-29 15:39:50 +11:00
Arpit Jalan 0f005d0e86 Bump onebox gem to 2.2.1 (#11575) 
- allow oneboxes with title and image
 2020-12-24 10:24:59 +05:30
Arpit Jalan 6929a6bdfb Bump onebox gem to 2.2.0 (#11568) 
- do not show title only oneboxes
 2020-12-23 12:26:01 +05:30
Arpit Jalan c9381beb9c FIX: handle badge grant for deleted badge (#11558) 2020-12-22 20:24:51 +05:30
Arpit Jalan bbf6cc4f18 DEV: require fileutils gem on boot (#11542) 2020-12-21 16:31:06 +11:00
Arpit Jalan f296ca4b4a FEATURE: allow plugins to show custom HTML via renderTags (#11520) 
This commit allows discourse-assign plugin to show custom HTML via
renderTags even if topic has no tags.
 2020-12-18 09:42:42 +05:30
Arpit Jalan 29c7655221 FEATURE: allow plugins to preload custom data on search (#11518) 
This commit allows discourse-assign plugin to show assigned users on
search result topic list.
 2020-12-17 21:59:10 +05:30
Arpit Jalan 1e7d6ebb0f DEV: no need to iterate through each tag for rendering (#11508) 
This commit allows discourse-assign plugin to show assigned user next to
tags.
 2020-12-16 18:40:58 +05:30
Arpit Jalan f62ea77666 Revert "DEV: no need to iterate through each tag for rendering" (#11432) 
This reverts commit a19a3adf9e.

Need to look into failing tests.
 2020-12-08 20:35:46 +05:30
Arpit Jalan a19a3adf9e DEV: no need to iterate through each tag for rendering (#11428) 
This commit allows discourse-assign plugin to show assigned user next
to tags.
 2020-12-08 18:41:26 +05:30
Arpit Jalan d627cc6233 Fix typo. (#11395) 2020-12-02 19:08:59 +05:30
Arpit Jalan a78c64db35 FIX: on invite redemption only update pending ReviewableUser record (#11394) 
When the invite was being redeemed and the ReviewableUser record status
for the invited user was not pending an error was being raised.

This commit makes sure that we are only looking for ReviewableUser
record with status pending and updates that to approved.
 2020-12-02 18:38:26 +05:30
Arpit Jalan 86feaec9be FIX: URL encode tag name (#11393) 
Tags with emoji in the name were failing to redirect via permalink
handling. This commit percent encodes the emoji name which fixes
the issue.

https://meta.discourse.org/t/permalinks-not-working-in-unicode-tags/171757/
 2020-12-02 12:36:41 +05:30
Arpit Jalan c244214fe5 UX: update "Rebuild-HTML" icon (#11296) 2020-11-19 19:39:18 -08:00
Arpit Jalan 0a56af49f3 FIX: add missing translation for 'views' key. (#11276) 2020-11-18 16:47:43 +05:30
Arpit Jalan 2fde06ba08 UX: handle large email addresses on email skipped and bounced tabs (#11259) 2020-11-17 18:01:40 +05:30
Arpit Jalan 473f7bfe7b FIX: do not allow a tag to be synonym of its own (#11246) 
https://meta.discourse.org/t/adding-synonym-to-the-same-tag-gets-stuck/169801/
 2020-11-17 06:52:31 +05:30
Arpit Jalan 0853208d67 FIX: save draft when either title or reply is present (#11243) 
Here's how draft saving process works currently:

- if only title is present (no reply) the draft is saved
- if only reply is present (no title) the draft is saved
- if both title and reply are present, and reply length is less than
`min_post_length` and the title length is less than
`min_topic_title_length`, then the draft is saved
- if both title and reply are present, and reply length is less than
`min_post_length`, then the draft is not saved

The current draft saving conditions are complex to understand and is
causing confusion as seen here: https://meta.discourse.org/t/draft-is-not-being-saved-when-creating-a-new-pm/149990/6?u=techapj

This commit updates the process to always save the draft if either title
or reply exists.
 2020-11-16 16:43:50 +05:30
Arpit Jalan 915764922d UX: update the invite button label (#11231) 2020-11-13 17:21:41 +05:30
Arpit Jalan b81326a7dd UX: draft delete button was looking odd on user stream (#11232) 2020-11-13 17:21:06 +05:30
Arpit Jalan df003eaf7b FIX: add a way to cancel initialization of new draft (#11106) 2020-11-12 19:13:52 +05:30
Arpit Jalan 80759c9619 UX: add a confirmation dialog for draft deletion (#11198) 2020-11-11 22:02:52 +05:30
Arpit Jalan 6ea9eb0260 UX: add a link to invites on quick access profile panel (#11202) 2020-11-11 22:02:27 +05:30
Arpit Jalan fec9d6e578 FIX: when creating linked topics make sure they belong to same category (#11188) 
This PR fixes a bug where the newly created linked topic was being
assigned "uncategorized" category. Now we'll assign linked topics the
same category as that of parent topic.

Meta reference: https://meta.discourse.org/t/linked-topics-splitting-and-managing-megatopics/168992/10?u=techapj
 2020-11-11 00:44:27 +05:30
Arpit Jalan 00b41437b0 FIX: hide sso email behind a button click and log views (#11186) 2020-11-11 00:42:44 +05:30
Arpit Jalan 394f37cf66 FIX: do not use "max_tags_in_filter_list" setting for showing PM tags (#11146) 
Ensure we do not respect max_tags_in_filter_list when showing the list of PM tags.

This filter is used on a full page view and there is not point limiting it to a small number.

The expectation is that PM tags are very rarely used, so a hard limit of 1000 should be safe for now.
 2020-11-10 08:09:59 +11:00
Arpit Jalan 436bd48512 UX: update topic small action post to add link for new linked topic URL (#11132) 
https://meta.discourse.org/t/linked-topics-splitting-and-managing-megatopics/168992/4?u=techapj
 2020-11-05 22:39:21 +05:30
Arpit Jalan 3397e0e38b UX: sort user badges by Gold > Silver > Bronze. (#11117) 2020-11-04 22:17:47 +05:30
Arpit Jalan d237ada12f FIX: enqueue PostCreator jobs outside transaction block (#11120) 
The `enqueue_jobs` is not correctly post-processing the post since the
post is being created inside a transaction block. This commit explicitly
enqueues the job outside transaction block.
 2020-11-04 21:41:05 +05:30
Arpit Jalan 24d1b1f159 UX: when creating linked topic use URL and let onebox work its magic (#11118) 
When the linked topic is created we'll not hardcode the topic title and
let onebox work its magic instead so that the title can be updated
automatically.
 2020-11-04 17:19:09 +05:30
Arpit Jalan 0cb4109cbb FIX: group notification level cannot be null (#11109) 
Group's `default_notification_level` cannot be null so there is no need
to provide "none" translation for group notification level dropdown.
 2020-11-04 07:29:00 +05:30
Arpit Jalan 1476e17c35 FEATURE: new setting to create a linked topic on autoclosing mega topics (#11001) 
This commit adds a site setting `auto_close_topics_create_linked_topic`
which when enabled works in conjunction with `auto_close_topics_post_count`
setting and creates a new linked topic for the topic just closed.

The auto-created new topic contains a link for all the previous topics
and the topic titles are appended with `(Part {n})`.

The setting is enabled by default.
 2020-11-02 12:18:48 +05:30
Arpit Jalan b6aaff74be UX: update labels to indicate that invite link will be generated (not copied) (#11077) 2020-10-31 07:10:13 +05:30
Arpit Jalan 8f7f5204db UX: inform staff users that new users will be auto-approved on invite (#11062) 
When `must_approve_users` is enabled then staff users assume that all
users will have to be approved manually. But in case of invite we
auto-approve users if they are invited by users. This commit adds an
info on the bottom of invite modal informing staff users that new users
will be auto-approved as soon as they accept invite.
 2020-10-30 08:41:14 +05:30
Arpit Jalan 6d4cfbf120 FIX: show 'quote' button when topic is closed but composer is open (#11054) 2020-10-28 19:25:06 +05:30
Arpit Jalan c6bf70c870 DEV: annotate models (#11047) 2020-10-27 23:42:33 +05:30
Arpit Jalan 5ce006aea1 UX: prioritize "invite by link" option (for staff users) (#11028) 
UX: update locale for single/multiple invites tab
 2020-10-26 21:59:17 +05:30
Arpit Jalan 9aa2723d57 UX: improve error message for already logged in users (#11020) 2020-10-24 21:21:01 +05:30
Arpit Jalan 6051a3da68 FIX: enable "remove tags" button only when tagging is enabled (#10957) 
UX: remove tags button does not qualify to be a danger button
 2020-10-19 22:08:11 +05:30
Arpit Jalan f4c7c7bff3 FEATURE: bulk remove tags (#10831) 
https://meta.discourse.org/t/bulk-actions-remove-tags-in-addition-to-change-tags/52145
 2020-10-06 22:41:55 +05:30
Arpit Jalan ff44515a18 FIX: better error message if invite is expired (#10783) 
https://meta.discourse.org/t/invite-token-is-invalid/165270/5?u=techapj
 2020-09-30 20:32:33 +05:30
Arpit Jalan 025490ecb9 FEATURE: composer option to reload page and force save draft (#10773) 2020-09-29 22:29:03 +05:30
Arpit Jalan 91ac70a32d UX: increase input width on accept invite page. 2020-09-29 10:12:23 +05:30
Arpit Jalan edad403049 UX: fix styling for posts and views advanced search 2020-09-28 21:44:33 +05:30
Arpit Jalan f7940b1d20 FEATURE: advanced search option for max posts count (#10761) 
This commit adds an option to search for max posts count and updates
the UI for posts count search to show a min/max range in single line.
 2020-09-28 21:34:16 +05:30
Arpit Jalan 4fcb307f84 UX: consistent password label on signup and invites page 2020-09-28 20:45:12 +05:30
Arpit Jalan 2282fbcedd fix the build 2020-09-28 16:57:42 +05:30
Arpit Jalan 50d53508b1 UX: show range for advanced search views filter. 2020-09-28 16:07:44 +05:30
Arpit Jalan 4498c59085 FEATURE: add alias for min_post_count search filter 2020-09-28 16:07:44 +05:30
Arpit Jalan 30ffd3a44d Update locale for minimum posts filter on advanced search. 2020-09-25 08:18:03 +05:30
Arpit Jalan cdf45f4fe6 Update regex for views search filter. 2020-09-24 17:05:55 +05:30
Arpit Jalan 5b0ce25dd7 Update locale for views search filter. 2020-09-24 16:33:53 +05:30
Arpit Jalan 0c5cd0d1ef FEATURE: advanced search filters for view count 2020-09-24 15:22:18 +05:30
Arpit Jalan 3684337e4a FIX: email always settings were not being respected 
https://meta.discourse.org/t/email-notification-for-messages/163937/10?u=techapj
 2020-09-23 22:00:15 +05:30
Arpit Jalan 376255ed84 UX: add width and height to GitHub onebox inline avatar in emails. 2020-09-21 11:47:09 +05:30
Arpit Jalan 32d6286bea FIX: category slug route was not working for subfolder setup 
https://meta.discourse.org/t/relative-url-root-issues-incorrect-latest-link-incorrect-redirect/163266

URLs like `/forum/c/staff` (subfolder setup) were landing on
`/forum/forum/c/staff/3`. Note the extra "/forum". This commit
strips the redundant subfolder path from category URL.
 2020-09-16 12:09:16 +05:30
Arpit Jalan 296c707f55 FEATURE: show existing tag name on rename modal 
FIX: tags_filter_regexp was not being applied on tag rename
 2020-09-10 21:45:05 +05:30
Arpit Jalan 34478760b2 Update annotations. 2020-09-01 13:41:04 +05:30
Arpit Jalan bb2e830010 Remove out-of-date / non-core annotations. 2020-09-01 12:40:57 +05:30
Arpit Jalan e66eefe179 Annotate models. 2020-09-01 10:22:32 +05:30
Arpit Jalan db4e310376 DEV: annotate models 2020-07-22 16:02:31 +05:30
Arpit Jalan 8e2f57a498 Fix the build. 2020-07-13 18:52:04 +05:30
Arpit Jalan 7532f24668 UX: better error message if moderator is not allowed to invite to group 
UX: do not show invite to group option if mod is not owner of any group
 2020-07-13 18:09:36 +05:30
Arpit Jalan ba57dc57cc DEV: use group_ids instead of group_names in invite params 2020-07-13 17:37:04 +05:30