IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Editable sshkey, mac address field after upgrade

Browse Source 
After upgrade, sshkeys of existing users and hosts or mac address are not editable because attribute level rights are not send to Web UI due to lack of ipasshuser/ieee802device object classes.

'w_if_no_aci' attribute flag was introduced to bypass this issue. It makes attribute writable when AttributeLevelRights for the attribute are not present and only when user posses rights for modifying object class attribute.

The flag was set for sshkeys_field and mac address field.

https://fedorahosted.org/freeipa/ticket/3260
This commit is contained in:
Petr Vobornik
2012-11-19 13:22:36 +01:00
parent 730a500567
commit 0833f594c1
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
install/ui/field.js
View File

@@ -190,7 +190,17 @@ IPA.field = function(spec) {
if (record.attributelevelrights) {
var rights = record.attributelevelrights[that.param];
if (!rights || rights.indexOf('w') < 0) {
var oc_rights= record.attributelevelrights['objectclass'];
var write_oc = oc_rights && oc_rights.indexOf('w') > -1;
// Some objects in LDAP may not have set proper object class and
// therefore server doesn't send proper attribute rights. Flag
// 'w_if_no_aci' should be used when we want to ensure that UI
// shows edit interface in such cases. Usable only when user can
// modify object classes.
// For all others, lack of rights means no write.
if ((!rights && !(that.flags.indexOf('w_if_no_aci') > -1 && write_oc)) ||
(rights && rights.indexOf('w') < 0)) {
that.writable = false;
}
}
@@ -644,7 +654,10 @@ IPA.sshkeys_field = function(spec) {
var that = IPA.multivalued_field(spec);
that.sshfp_attr = 'sshpubkeyfp' || spec.sshfp_attr;
// Fixes upgrade issue. When attr rights are missing due to lack of object class.
that.flags = spec.flags || ['w_if_no_aci'];
that.sshfp_attr = spec.sshfp_attr || 'sshpubkeyfp';
that.load = function(record) {

3
install/ui/host.js
View File

@@ -71,7 +71,8 @@ IPA.host.entity = function(spec) {
},
{
type: 'multivalued',
name: 'macaddress'
name: 'macaddress',
flags: ['w_if_no_aci']
}
]
},