Pylint: enable check for unused-variables

Unused variables may:
* make code less readable
* create dead code
* potentialy hide issues/errors

Enabled check should prevent to leave unused variable in code

Check is locally disabled for modules that fix is not clear or easy or have too many occurences of
unused variables

Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>

ipapython/certdb.py

@@ -30,6 +30,8 @@ from ipapython.ipa_log_manager import root_logger
 from ipapython import ipautil
 from ipalib import x509
 
+# pylint: disable=unused-variable
+
 CA_NICKNAME_FMT = "%s IPA CA"
 
 

ipapython/certmonger.py

@@ -34,6 +34,8 @@ from ipapython.ipa_log_manager import root_logger
 from ipaplatform.paths import paths
 from ipaplatform import services
 
+# pylint: disable=unused-variable
+
 DBUS_CM_PATH = '/org/fedorahosted/certmonger'
 DBUS_CM_IF = 'org.fedorahosted.certmonger'
 DBUS_CM_NAME = 'org.fedorahosted.certmonger'

ipapython/cookie.py

@@ -27,6 +27,8 @@ from six.moves.urllib.parse import urlparse
 
 from ipapython.ipa_log_manager import log_mgr
 
+# pylint: disable=unused-variable
+
 '''
 Core Python has two cookie libraries, Cookie.py targeted to server
 side and cookielib.py targeted to client side. So why this module and

ipapython/dnssec/localhsm.py

@@ -18,6 +18,8 @@ from ipapython.dnssec.abshsm import (attrs_name2id, attrs_id2name, AbstractHSM,
                                      keytype_id2name, keytype_name2id,
                                      ldap2p11helper_api_params)
 
+# pylint: disable=unused-variable
+
 private_key_api_params = set(["label", "id", "data", "unwrapping_key",
     "wrapping_mech", "key_type", "cka_always_authenticate", "cka_copyable",
     "cka_decrypt", "cka_derive", "cka_extractable", "cka_modifiable",

ipapython/install/core.py

@@ -19,6 +19,8 @@ from ipapython.ipa_log_manager import root_logger
 from . import util
 from .util import from_
 
+# pylint: disable=unused-variable
+
 __all__ = ['InvalidStateError', 'KnobValueError', 'Property', 'Knob',
            'Configurable', 'Group', 'Component', 'Composite']
 

ipapython/ipaldap.py

@@ -44,6 +44,8 @@ from ipapython.dn import DN
 from ipapython.dnsutil import DNSName
 from ipapython.kerberos import Principal
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipapython/ipautil.py

@@ -54,6 +54,8 @@ from ipapython import config
 from ipaplatform.paths import paths
 from ipapython.dn import DN
 
+# pylint: disable=unused-variable
+
 SHARE_DIR = paths.USR_SHARE_IPA_DIR
 PLUGINS_SHARE_DIR = paths.IPA_PLUGINS
 

ipapython/p11helper.py

@@ -12,6 +12,8 @@ from cryptography.hazmat.primitives import serialization
 from cryptography.hazmat.primitives.asymmetric import dsa, ec, rsa
 from cffi import FFI
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str
 

ipapython/sysrestore.py

@@ -35,6 +35,8 @@ from six.moves.configparser import SafeConfigParser
 from ipaplatform.tasks import tasks
 from ipaplatform.paths import paths
 
+# pylint: disable=unused-variable
+
 if six.PY3:
     unicode = str