IntenseWebs/freeipa
3
0 Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2026-11-02 08:59:57 -06:00
Code Issues Packages Projects Releases Wiki Activity

ipa-extdom-extop: fix memory leaks

Browse Source 
In various code paths the `ctx` structure was freed, but not `ctx`
resources (`base_dn`, `nss_ctx`, `extdom_instance_counter`) which may
have been allocated.

Plugin didn't have SLAPI_PLUGIN_CLOSE_FN registered, so context was
never freed on server shutdown.

Related: https://pagure.io/freeipa/issue/9895
Signed-off-by: Viktor Ashirov <vashirov@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Alexander Bokovoy <abbra@users.noreply.github.com>
This commit is contained in:
Viktor Ashirov authored and Florence Blanc-Renaud committed 2025-12-12 09:40:21 +01:00
1 parent 0e409d1955
commit 4a62d6141a
1 file changed
+38 -1
Download Patch File Download Diff File Expand all files Collapse all files
daemons/ipa-slapi-plugins/ipa-extdom-extop/ipa_extdom_extop.c
+38 -1
View File
@@ -171,6 +171,26 @@ static int ipa_extdom_start(Slapi_PBlock *pb)
return LDAP_SUCCESS;
}
static int ipa_extdom_close(Slapi_PBlock *pb)
{
int ret;
struct ipa_extdom_ctx *ctx;
ret = slapi_pblock_get(pb, SLAPI_PLUGIN_PRIVATE, &ctx);
if (ret == 0 && ctx != NULL) {
if (ctx->extdom_instance_counter) {
slapi_counter_destroy(&ctx->extdom_instance_counter);
}
if (ctx->nss_ctx) {
back_extdom_free_context(&ctx->nss_ctx);
}
slapi_ch_free_string(&ctx->base_dn);
free(ctx);
}
return 0;
}
static int ipa_extdom_extop(Slapi_PBlock *pb)
{
char *oid = NULL;
@@ -360,7 +380,16 @@ static int ipa_extdom_init_ctx(Slapi_PBlock *pb, struct ipa_extdom_ctx **_ctx)
done:
if (ret) {
free(ctx);
if (ctx) {
if (ctx->extdom_instance_counter) {
slapi_counter_destroy(&ctx->extdom_instance_counter);
}
if (ctx->nss_ctx) {
back_extdom_free_context(&ctx->nss_ctx);
}
slapi_ch_free_string(&ctx->base_dn);
free(ctx);
}
} else {
*_ctx = ctx;
}
@@ -388,6 +417,10 @@ int ipa_extdom_init(Slapi_PBlock *pb)
ret = slapi_pblock_set(pb, SLAPI_PLUGIN_START_FN,
(void *)ipa_extdom_start);
}
if (!ret) {
ret = slapi_pblock_set(pb, SLAPI_PLUGIN_CLOSE_FN,
(void *)ipa_extdom_close);
}
if (!ret) {
ret = slapi_pblock_set(pb, SLAPI_PLUGIN_EXT_OP_OIDLIST,
ipa_extdom_oid_list);
@@ -405,6 +438,10 @@ int ipa_extdom_init(Slapi_PBlock *pb)
}
if (ret) {
LOG("Failed to set plug-in version, function, and OID.\n" );
slapi_counter_destroy(&extdom_ctx->extdom_instance_counter);
back_extdom_free_context(&extdom_ctx->nss_ctx);
slapi_ch_free_string(&extdom_ctx->base_dn);
free(extdom_ctx);
return -1;
}