Add title to 'Remove' dialog for 'association_table' widget of 'Vault' entity

To improve translation quality the title of 'Remove' dialog,
which is initialized within details table of the entity, should be
specified explicitly in the spec and should be an entire sentence.

Fixes: https://pagure.io/freeipa/issue/7704
Reviewed-By: Serhii Tsymbaliuk <stsymbal@redhat.com>
This commit is contained in:
Stanislav Levin 2018-09-16 23:14:45 +03:00 committed by Serhii Tsymbaliuk
parent 6eed677614
commit 57e65a5c9f
2 changed files with 33 additions and 7 deletions

View File

@ -88,7 +88,8 @@ var make_vaults_details_page_spec = function() {
name: 'member_user',
label: '@i18n:objects.vault.user'
}
]
],
remove_title: '@i18n:objects.vault.remove_member_users',
},
{
$type: 'association_table',
@ -101,7 +102,8 @@ var make_vaults_details_page_spec = function() {
name: 'member_group',
label: '@i18n:objects.vault.group'
}
]
],
remove_title: '@i18n:objects.vault.remove_member_groups',
},
{
$type: 'association_table',
@ -115,7 +117,8 @@ var make_vaults_details_page_spec = function() {
name: 'member_service',
label: '@i18n:objects.vault.service'
}
]
],
remove_title: '@i18n:objects.vault.remove_member_services',
}
]
},
@ -137,7 +140,8 @@ var make_vaults_details_page_spec = function() {
name: 'owner_user',
label: '@i18n:objects.vault.user'
}
]
],
remove_title: '@i18n:objects.vault.remove_owner_users',
},
{
$type: 'association_table',
@ -152,7 +156,8 @@ var make_vaults_details_page_spec = function() {
name: 'owner_group',
label: '@i18n:objects.vault.group'
}
]
],
remove_title: '@i18n:objects.vault.remove_owner_groups',
},
{
$type: 'association_table',
@ -168,7 +173,8 @@ var make_vaults_details_page_spec = function() {
name: 'owner_service',
label: '@i18n:objects.vault.service'
}
]
],
remove_title: '@i18n:objects.vault.remove_owner_services',
}
]
}
@ -225,7 +231,8 @@ var make_my_vault_spec = function() {
// in case that table on each facet gather more columns with these names.
// I.e. facet with user vaults get column with name 'service', then
// the value of 'service' column will be also added to command options.
additional_table_attrs: ['username', 'service', 'shared']
additional_table_attrs: ['username', 'service', 'shared'],
title: '@i18n:objects.vault.remove',
}
};

View File

@ -1245,6 +1245,25 @@ class i18n_messages(Command):
"members": _("Members"),
"my_vaults_title": _("My User Vaults"),
"owners": _("Owners"),
"remove": _("Remove vaults"),
"remove_member_groups": _(
"Remove user groups from members of vault '${primary_key}'"
),
"remove_member_services": _(
"Remove services from members of vault '${primary_key}'"
),
"remove_member_users": _(
"Remove users from members of vault '${primary_key}'"
),
"remove_owner_groups": _(
"Remove user groups from owners of vault '${primary_key}'"
),
"remove_owner_services": _(
"Remove services from owners of vault '${primary_key}'"
),
"remove_owner_users": _(
"Remove users from owners of vault '${primary_key}'"
),
"service": _("Service"),
"service_vaults_title": _("Service Vaults"),
"shared": _("Shared"),