Remove invalid error messages from topology upgrade

Return False does not mean that update failed, it mean that nothing has
been updated, respectively ldap is up to date.

https://fedorahosted.org/freeipa/ticket/5482

Reviewed-By: Tomas Babej <tbabej@redhat.com>
This commit is contained in:
Martin Basti
2015-11-25 13:58:05 +01:00
committed by Tomas Babej
parent 1904d7cc3a
commit 801672cc66
2 changed files with 3 additions and 6 deletions
+1 -3
View File
@@ -595,9 +595,7 @@ class CAInstance(DogtagInstance):
'SUFFIX': api.env.basedn,
'FQDN': self.fqdn,
})
rv = ld.update([paths.CA_TOPOLOGY_ULDIF])
if not rv:
raise RuntimeError("Failed to update CA topology configuration")
ld.update([paths.CA_TOPOLOGY_ULDIF])
def __disable_nonce(self):
# Turn off Nonces
@@ -25,9 +25,8 @@ class update_ca_topology(Updater):
'SUFFIX': self.api.env.basedn,
'FQDN': self.api.env.host,
})
rv = ld.update([paths.CA_TOPOLOGY_ULDIF])
if not rv:
self.log.error("Failed to update CA topology configuration")
ld.update([paths.CA_TOPOLOGY_ULDIF])
return False, []