Don't add 127.0.0.1 to resolv.conf twice

On systems with multiple IP addresses the update code could add
::1 and 127.0.0.1 multiple times.

Related: https://pagure.io/freeipa/issue/8275
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Christian Heimes
2020-10-06 13:55:08 +02:00
parent 6ba5a6a46e
commit 814328ea3c

View File

@@ -1121,18 +1121,18 @@ class BindInstance(service.Service):
def setup_resolv_conf(self):
searchdomains = [self.domain]
nameservers = []
nameservers = set()
resolve1_enabled = dnsforwarders.detect_resolve1_resolv_conf()
for ip_address in self.ip_addresses:
if ip_address.version == 4:
nameservers.append("127.0.0.1")
nameservers.add("127.0.0.1")
elif ip_address.version == 6:
nameservers.append("::1")
nameservers.add("::1")
try:
tasks.configure_dns_resolver(
nameservers, searchdomains,
sorted(nameservers), searchdomains,
resolve1_enabled=resolve1_enabled, fstore=self.fstore
)
except IOError as e: