IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

ipa-range-check: Fix memory leaks when freeing range object

Browse Source 
When cleaning the range_info struct, simple free of the struct
is not enough, we have to free contents of char pointers in the
struct as well.

https://fedorahosted.org/freeipa/ticket/4276
This commit is contained in:
Tomas Babej 2014-04-01 09:20:09 +02:00 committed by Martin Kosek
parent 5a0d52b939
commit 8d2b3fe7a7
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
daemons/ipa-slapi-plugins/ipa-range-check/ipa_range_check.c
View File

@ -78,6 +78,14 @@ struct range_info {
uint32_t secondary_base_rid;
};
static void free_range_info(struct range_info *range) {
if (range != NULL) {
slapi_ch_free_string(&(range->name));
slapi_ch_free_string(&(range->domain_id));
free(range);
}
}
static int slapi_entry_to_range_info(struct slapi_entry *entry,
struct range_info **_range)
{
@ -131,7 +139,7 @@ static int slapi_entry_to_range_info(struct slapi_entry *entry,
done:
if (ret != 0) {
free(range);
free_range_info(range);
}
return ret;
@ -388,7 +396,7 @@ static int ipa_range_check_pre_op(Slapi_PBlock *pb, int modtype)
}
no_overlap = ranges_overlap(new_range, old_range);
free(old_range);
free_range_info(old_range);
old_range = NULL;
if (no_overlap != 0) {
ret = LDAP_CONSTRAINT_VIOLATION;
@ -426,8 +434,8 @@ done:
slapi_free_search_results_internal(search_pb);
slapi_pblock_destroy(search_pb);
slapi_sdn_free(&dn);
free(old_range);
free(new_range);
free_range_info(old_range);
free_range_info(new_range);
if (free_entry) {
slapi_entry_free(entry);
}