Remove unused variable and finally block in SchemaCache

Handling exceptions in python is expensive operation, removing of
uneeded finally block is good for performance.

Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
This commit is contained in:
Martin Basti
2016-04-06 16:48:49 +02:00
parent ab2ebf489f
commit 93332bcf4d

View File

@@ -21,7 +21,6 @@
import time
import datetime
import shutil
from decimal import Decimal
from copy import deepcopy
import contextlib
@@ -155,7 +154,6 @@ class SchemaCache(object):
If a connection is provided then it the credentials bound to it are
used. The connection is not closed when the request is done.
"""
tmpdir = None
assert conn is not None
self.log.debug(
@@ -184,9 +182,6 @@ class SchemaCache(object):
# TODO: DS uses 'cn=schema', support for other server?
# raise a more appropriate exception
raise
finally:
if tmpdir:
shutil.rmtree(tmpdir)
return ldap.schema.SubSchema(schema_entry[1])