ipaplatform: Remove redundant imports of ipaservices

Also fixes few incorrect imports.

https://fedorahosted.org/freeipa/ticket/4052

Reviewed-By: Petr Viktorin <pviktori@redhat.com>

install/restart_scripts/renew_ca_cert

@@ -28,7 +28,6 @@ import shutil
 import traceback
 
 from ipapython import dogtag, certmonger, ipautil
-from ipapython import services as ipaservices
 from ipalib import api, errors, x509, util
 from ipaserver.install import certs, cainstance, installutils
 from ipaserver.plugins.ldap2 import ldap2

install/restart_scripts/renew_ra_cert

@@ -24,7 +24,6 @@ import sys
 import syslog
 import traceback
 
-from ipapython import services as ipaservices
 from ipalib import api
 from ipaserver.install import certs, cainstance
 from ipaplatform import services

install/restart_scripts/restart_dirsrv

@@ -22,7 +22,6 @@
 import sys
 import syslog
 import traceback
-from ipapython import services as ipaservices
 from ipalib import api
 from ipaplatform import services
 

install/restart_scripts/restart_httpd

@@ -21,7 +21,6 @@
 
 import syslog
 import traceback
-from ipapython import services as ipaservices
 from ipaplatform import services
 
 def main():

install/restart_scripts/stop_pkicad

@@ -22,7 +22,6 @@
 import sys
 import syslog
 import traceback
-from ipapython import services as ipaservices
 from ipapython import dogtag
 from ipalib import api
 from ipaplatform import services

install/tools/ipa-ca-install

@@ -24,7 +24,6 @@ import socket
 import os, shutil
 
 from ipapython import ipautil
-from ipapython import services as ipaservices
 
 from ipaserver.install import installutils, service
 from ipaserver.install import certs

install/tools/ipa-nis-manage

@@ -24,7 +24,6 @@ import os
 try:
     from optparse import OptionParser
     from ipapython import ipautil, config
-    from ipapython import services as ipaservices
     from ipaserver.install import installutils
     from ipaserver.install.ldapupdate import LDAPUpdate, BadSyntax
     from ipaserver.plugins.ldap2 import ldap2

install/tools/ipa-replica-install

@@ -46,12 +46,11 @@ from ipalib.constants import CACERT
 from ipapython import version
 from ipapython.config import IPAOptionParser
 from ipapython import sysrestore
-from ipapython import services as ipaservices
 from ipapython.ipa_log_manager import *
 from ipapython import dogtag
 from ipapython.dn import DN
 import ipaclient.ntpconf
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipaplatform import services
 
 log_file_name = "/var/log/ipareplica-install.log"

install/tools/ipa-server-install

@@ -73,12 +73,11 @@ from ipapython.config import IPAOptionParser
 from ipalib.x509 import load_certificate_from_file, load_certificate_chain_from_file
 from ipalib.util import validate_domain_name
 from ipalib.constants import CACERT
-from ipapython import services as ipaservices
 from ipapython.ipa_log_manager import *
 from ipapython.dn import DN
 
 import ipaclient.ntpconf
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipaplatform import services
 
 uninstalling = False

install/tools/ipa-upgradeconfig

@@ -36,7 +36,7 @@ import SSSDConfig
 import ipalib.util
 import ipalib.errors
 from ipaplatform import services
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipapython import ipautil, sysrestore, version
 from ipapython.config import IPAOptionParser
 from ipapython.ipa_log_manager import *

install/tools/ipactl

@@ -30,9 +30,8 @@ from ipaserver.install.installutils import is_ipa_configured, ScriptError
 from ipalib import api, errors
 from ipapython.ipaldap import IPAdmin
 from ipapython.ipautil import wait_for_open_ports, wait_for_open_socket
-from ipapython import services as ipaservices
 from ipapython import config, dogtag
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipapython.dn import DN
 from ipaplatform import services
 from ipaplatform.paths import paths

ipa-client/ipa-install/ipa-client-automount

@@ -37,8 +37,7 @@ from ipaclient import ipadiscovery
 from ipaclient import ipachangeconf
 from ipapython.ipa_log_manager import *
 from ipapython.dn import DN
-from ipapython import services as ipaservices
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipaplatform import services
 
 AUTOFS_CONF = '/etc/sysconfig/autofs'

ipa-client/ipaclient/ntpconf.py

@@ -18,10 +18,9 @@
 #
 
 from ipapython import ipautil
-from ipapython import services as ipaservices
 import shutil
 import os
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipaplatform import services
 
 ntp_conf = """# Permit time synchronization with our time source, but do not

ipapython/sysrestore.py

@@ -32,8 +32,7 @@ import random
 import string
 
 from ipapython import ipautil
-from ipapython import services as ipaservices
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 
 SYSRESTORE_PATH = "/tmp"
 SYSRESTORE_INDEXFILE = "sysrestore.index"

ipaserver/install/adtrustinstance.py

@@ -37,7 +37,6 @@ from ipapython.dn import DN
 from ipapython import sysrestore
 from ipapython import ipautil
 from ipapython.ipa_log_manager import *
-from ipapython import services as ipaservices
 
 import ipaclient.ipachangeconf
 from ipaplatform import services

ipaserver/install/cainstance.py

@@ -49,9 +49,8 @@ import subprocess
 import traceback
 
 from ipapython import ipautil
-from ipapython import services as ipaservices
 from ipapython import ipaldap
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipaserver.install import service
 from ipaserver.install import installutils
 from ipaserver.install import dsinstance

ipaserver/install/certs.py

@@ -37,7 +37,6 @@ from ipapython import sysrestore
 from ipapython import ipautil
 from ipapython import certmonger
 from ipapython.certdb import get_ca_nickname
-from ipapython import services as ipaservices
 from ipapython.dn import DN
 from ipalib import pkcs10, x509, api
 from ipalib.errors import CertificateOperationError

ipaserver/install/dsinstance.py

@@ -31,7 +31,6 @@ import grp
 
 from ipapython.ipa_log_manager import *
 from ipapython import ipautil, sysrestore, ipaldap
-from ipapython import services as ipaservices
 import service
 import installutils
 import certs
@@ -40,7 +39,7 @@ from ipaserver.install import ldapupdate
 from ipaserver.install import replication
 from ipaserver.install import sysupgrade
 from ipalib import errors
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipalib.constants import CACERT
 from ipapython.dn import DN
 from ipaplatform import services

ipaserver/install/httpinstance.py

@@ -30,12 +30,11 @@ import certs
 import installutils
 from ipapython import sysrestore
 from ipapython import ipautil
-from ipapython import services as ipaservices
 from ipapython import dogtag
 from ipapython.ipa_log_manager import *
 from ipaserver.install import sysupgrade
 from ipalib import api
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipalib.constants import CACERT
 
 HTTPD_DIR = "/etc/httpd"

ipaserver/install/installutils.py

@@ -42,7 +42,6 @@ from ipapython import config
 from ipalib import errors
 from ipapython.dn import DN
 from ipaserver.install import certs, service
-from ipapython import services as ipaservices
 from ipaplatform import services
 
 # Used to determine install status

ipaserver/install/ipa_backup.py

@@ -36,7 +36,6 @@ from ipapython.dn import DN
 from ipaserver.install.dsinstance import realm_to_serverid, DS_USER
 from ipaserver.install.replication import wait_for_task
 from ipaserver.install import installutils
-from ipapython import services as ipaservices
 from ipapython import ipaldap
 from ipalib.session import ISO8601_DATETIME_FMT
 from ipalib.constants import CACERT

ipaserver/install/ipa_restore.py

@@ -36,9 +36,8 @@ from ipaserver.install.cainstance import PKI_USER
 from ipaserver.install.replication import (wait_for_task, ReplicationManager,
                                            get_cs_replication_manager)
 from ipaserver.install import installutils
-from ipapython import services as ipaservices
 from ipapython import ipaldap
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 from ipaserver.install.ipa_backup import BACKUP_DIR
 from ipaplatform import services
 

ipaserver/install/krbinstance.py

@@ -30,7 +30,6 @@ import service
 import installutils
 from ipapython import sysrestore
 from ipapython import ipautil
-from ipapython import services as ipaservices
 from ipapython import kernel_keyring
 from ipalib import errors
 from ipalib.constants import CACERT
@@ -45,7 +44,7 @@ import struct
 
 import certs
 from distutils import version
-from ipaplatform import tasks
+from ipaplatform.tasks import tasks
 
 def update_key_val_in_file(filename, key, val):
     if os.path.exists(filename):

ipaserver/install/replication.py

@@ -26,7 +26,6 @@ import ldap
 
 from ipalib import api, errors
 from ipalib.constants import CACERT
-from ipapython import services as ipaservices
 from ipapython.ipa_log_manager import *
 from ipapython import ipautil, dogtag, ipaldap
 from ipapython.dn import DN

ipaserver/install/service.py

@@ -25,7 +25,6 @@ import time
 import datetime
 
 from ipapython import sysrestore, ipautil, dogtag, ipaldap
-from ipapython import services as ipaservices
 from ipapython.dn import DN
 from ipapython.ipa_log_manager import *
 from ipalib import errors