Remove wildcard imports

Wildcard imports should not be used.

Check for wildcard imports has been enabled in pylint.
Pylint note: options 'wildcard-import' causes too much false positive
results, so instead it I used 'unused-wildcard-import' option which has almost
the same effect.

Reviewed-By: Jan Cholasta <jcholast@redhat.com>

contrib/RHEL4/ipa-client-setup

@@ -25,7 +25,7 @@ import sys
 import os
 import string
 import shutil
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from optparse import OptionParser
 import ipachangeconf
 import ldap

install/tools/ipa-adtrust-install

@@ -23,17 +23,24 @@
 
 from __future__ import print_function
 
+import os
+import sys
+import ldap
+
 import six
 
 from ipaserver.install import adtrustinstance
-from ipaserver.install.installutils import *
+from ipaserver.install.installutils import (
+    read_password,
+    check_server_configuration,
+    run_script)
 from ipaserver.install import service
 from ipapython import version
 from ipapython import ipautil, sysrestore, ipaldap
 from ipalib import api, errors, krb_utils
 from ipapython.config import IPAOptionParser
 from ipaplatform.paths import paths
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython.dn import DN
 
 if six.PY3:

install/tools/ipa-ca-install

@@ -35,7 +35,7 @@ from ipalib import api
 from ipalib.constants import DOMAIN_LEVEL_0
 from ipapython.dn import DN
 from ipapython.config import IPAOptionParser
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipaplatform.paths import paths
 
 log_file_name = paths.IPAREPLICA_CA_INSTALL_LOG

install/tools/ipa-compat-manage

@@ -30,7 +30,7 @@ try:
     from ipaserver.install.ldapupdate import LDAPUpdate
     from ipaserver.plugins.ldap2 import ldap2
     from ipalib import api, errors
-    from ipapython.ipa_log_manager import *
+    from ipapython.ipa_log_manager import standard_logging_setup
     from ipapython.dn import DN
 except ImportError as e:
     print("""\

install/tools/ipa-csreplica-manage

@@ -25,7 +25,7 @@ from __future__ import print_function
 import sys
 import os
 
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipaserver.install import (replication, installutils, bindinstance,
     cainstance, certs)
 from ipalib import api, errors

install/tools/ipa-dns-install

@@ -21,14 +21,19 @@
 
 from __future__ import print_function
 
+import os
+import sys
+
 from optparse import SUPPRESS_HELP
 
 from ipaserver.install import bindinstance, httpinstance
-from ipaserver.install.installutils import *
 from ipaserver.install import installutils
+from ipaserver.install import service
 from ipapython import version
 from ipalib import api
 from ipaplatform.paths import paths
+from ipapython import ipautil
+from ipapython import sysrestore
 from ipapython.config import IPAOptionParser
 from ipapython.ipa_log_manager import standard_logging_setup, root_logger
 

install/tools/ipa-managed-entries

@@ -28,7 +28,7 @@ from ipapython import config, ipaldap
 from ipaserver.install import installutils
 from ipalib import api, errors
 from ipalib.constants import CACERT
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython.dn import DN
 
 def parse_options():

install/tools/ipa-nis-manage

@@ -31,7 +31,7 @@ try:
     from ipaserver.install.ldapupdate import LDAPUpdate
     from ipaserver.plugins.ldap2 import ldap2
     from ipalib import api, errors
-    from ipapython.ipa_log_manager import *
+    from ipapython.ipa_log_manager import standard_logging_setup
     from ipapython.dn import DN
     from ipaplatform import services
 except ImportError as e:

install/tools/ipa-replica-conncheck

@@ -27,7 +27,7 @@ from ipalib import api, errors, x509
 from ipaserver.install import installutils
 import ipaclient.ipachangeconf
 from optparse import OptionGroup, OptionValueError
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 import sys
 import os
 import signal

install/tools/ipa-replica-manage

@@ -38,7 +38,7 @@ from ipapython import version, ipaldap
 from ipalib import api, errors
 from ipalib.constants import CACERT
 from ipalib.util import has_managed_topology
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython.dn import DN
 from ipapython.config import IPAOptionParser
 from ipaclient import ipadiscovery

ipa-client/ipa-install/ipa-client-automount

@@ -38,7 +38,7 @@ from ipapython import sysrestore
 from ipapython import ipautil
 from ipaclient import ipadiscovery
 from ipaclient import ipachangeconf
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython.dn import DN
 from ipaplatform.constants import constants
 from ipaplatform.tasks import tasks

ipalib/plugable.py

@@ -43,7 +43,10 @@ from ipalib import text
 from ipalib.text import _
 from ipalib.base import ReadOnly, NameSpace, lock, islocked
 from ipalib.constants import DEFAULT_CONFIG
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import (
+    log_mgr,
+    LOGGING_FORMAT_FILE,
+    LOGGING_FORMAT_STDERR)
 from ipapython.version import VERSION, API_VERSION
 
 if six.PY3:

ipalib/plugins/aci.py

@@ -129,7 +129,7 @@ from ipalib import output
 from ipalib import _, ngettext
 from ipalib.plugable import Registry
 from ipalib.plugins.baseldap import gen_pkey_only_option, pkey_to_value
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython.dn import DN
 
 if six.PY3:

ipalib/plugins/automember.py

@@ -22,9 +22,18 @@ import time
 import ldap as _ldap
 import six
 
-from ipalib import api, errors, Str, StrEnum, DNParam, _, ngettext
+from ipalib import api, errors, Str, StrEnum, DNParam, Flag, _, ngettext
+from ipalib import output, Command
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    pkey_to_value,
+    entry_to_dict,
+    LDAPObject,
+    LDAPCreate,
+    LDAPUpdate,
+    LDAPDelete,
+    LDAPSearch,
+    LDAPRetrieve)
 from ipalib.request import context
 from ipapython.dn import DN
 

ipalib/plugins/automount.py

@@ -25,8 +25,17 @@ import six
 from ipalib import api, errors
 from ipalib import Flag, Str, IA5Str
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    pkey_to_value,
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPQuery,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve)
 from ipalib import _, ngettext
+from ipapython.dn import DN
 
 if six.PY3:
     unicode = str

ipalib/plugins/cert.py

@@ -31,7 +31,7 @@ from ipalib import x509
 from ipalib import util
 from ipalib import ngettext
 from ipalib.plugable import Registry
-from ipalib.plugins.virtual import *
+from ipalib.plugins.virtual import VirtualCommand
 from ipalib.plugins.baseldap import pkey_to_value
 from ipalib.plugins.service import split_any_principal
 from ipalib.plugins.certprofile import validate_profile_id
@@ -40,6 +40,7 @@ from ipalib.text import _
 from ipalib.request import context
 from ipalib import output
 from ipalib.plugins.service import validate_principal
+from ipapython.dn import DN
 
 import six
 import nss.nss as nss

ipalib/plugins/config.py

@@ -20,10 +20,15 @@
 
 from ipalib import api
 from ipalib import Bool, Int, Str, IA5Str, StrEnum, DNParam
+from ipalib import errors
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPUpdate,
+    LDAPRetrieve)
 from ipalib.plugins.selinuxusermap import validate_selinuxuser
 from ipalib import _
+from ipapython.dn import DN
 
 # 389-ds attributes that should be skipped in attribute checks
 OPERATIONAL_ATTRIBUTES = ('nsaccountlock', 'member', 'memberof',

ipalib/plugins/dns.py

@@ -36,11 +36,21 @@ import six
 from ipalib.request import context
 from ipalib import api, errors, output
 from ipalib import Command
-from ipalib.capabilities import VERSION_WITHOUT_CAPABILITIES
+from ipalib.capabilities import (
+    VERSION_WITHOUT_CAPABILITIES,
+    client_has_capability)
 from ipalib.parameters import (Flag, Bool, Int, Decimal, Str, StrEnum, Any,
                                DeprecatedParam, DNSNameParam)
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    pkey_to_value,
+    LDAPObject,
+    LDAPCreate,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPQuery,
+    LDAPDelete,
+    LDAPRetrieve)
 from ipalib import _, ngettext
 from ipalib import messages
 from ipalib.util import (normalize_zonemgr,
@@ -53,6 +63,7 @@ from ipalib.util import (normalize_zonemgr,
                          validate_dnssec_zone_forwarder_step1,
                          validate_dnssec_zone_forwarder_step2,
                          verify_host_resolvable)
+from ipapython.dn import DN
 from ipapython.ipautil import CheckedIPAddress, check_zone_overlap
 from ipapython.dnsutil import DNSName
 

ipalib/plugins/group.py

@@ -21,12 +21,28 @@
 import six
 
 from ipalib import api
-from ipalib import Int, Str
+from ipalib import Int, Str, Flag
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    add_external_post_callback,
+    pkey_to_value,
+    remove_external_post_callback,
+    LDAPObject,
+    LDAPCreate,
+    LDAPUpdate,
+    LDAPDelete,
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPAddMember,
+    LDAPRemoveMember,
+    LDAPQuery,
+)
 from ipalib.plugins.idviews import remove_ipaobject_overrides
 from ipalib.plugins import baseldap
 from ipalib import _, ngettext
+from ipalib import errors
+from ipalib import output
+from ipapython.dn import DN
 
 if six.PY3:
     unicode = str

ipalib/plugins/hbacrule.py

@@ -20,8 +20,21 @@
 from ipalib import api, errors
 from ipalib import AccessTime, Str, StrEnum, Bool, DeprecatedParam
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    pkey_to_value,
+    external_host_param,
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPRetrieve,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPQuery,
+    LDAPAddMember,
+    LDAPRemoveMember)
 from ipalib import _, ngettext
+from ipalib import output
+from ipapython.dn import DN
 
 __doc__ = _("""
 Host-based access control

ipalib/plugins/hbacsvcgroup.py

@@ -17,9 +17,17 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-from ipalib import api
+from ipalib import api, Str
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPCreate,
+    LDAPUpdate,
+    LDAPRetrieve,
+    LDAPSearch,
+    LDAPDelete,
+    LDAPAddMember,
+    LDAPRemoveMember)
 from ipalib import _, ngettext
 
 __doc__ = _("""

ipalib/plugins/netgroup.py

@@ -21,11 +21,24 @@
 import six
 
 from ipalib import api, errors
-from ipalib import Str, StrEnum
+from ipalib import Str, StrEnum, Flag
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    external_host_param,
+    add_external_pre_callback,
+    add_external_post_callback,
+    remove_external_post_callback,
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPAddMember,
+    LDAPRemoveMember)
 from ipalib import _, ngettext
 from ipalib.plugins.hbacrule import is_all
+from ipapython.dn import DN
 
 if six.PY3:
     unicode = str

ipalib/plugins/privilege.py

@@ -17,9 +17,22 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPAddMember,
+    LDAPRemoveMember,
+    LDAPAddReverseMember,
+    LDAPRemoveReverseMember)
 from ipalib import api, _, ngettext, errors
 from ipalib.plugable import Registry
+from ipalib import Str
+from ipalib import output
+from ipapython.dn import DN
 
 __doc__ = _("""
 Privileges

ipalib/plugins/pwpolicy.py

@@ -20,7 +20,14 @@
 
 from ipalib import api
 from ipalib import Int, Str, DNParam
-from ipalib.plugins.baseldap import *
+from ipalib import errors
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPRetrieve,
+    LDAPSearch)
 from ipalib import _
 from ipalib.plugable import Registry
 from ipalib.request import context

ipalib/plugins/radiusproxy.py

@@ -17,8 +17,15 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve)
 from ipalib import api, Str, Int, Password, _, ngettext
+from ipalib import errors
 from ipalib.plugable import Registry
 from ipalib.util import validate_hostname, validate_ipaddr
 from ipalib.errors import ValidationError

ipalib/plugins/role.py

@@ -19,8 +19,19 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPAddMember,
+    LDAPRemoveMember,
+    LDAPAddReverseMember,
+    LDAPRemoveReverseMember)
 from ipalib import api, Str, _, ngettext
+from ipalib import output
 
 __doc__ = _("""
 Roles

ipalib/plugins/selinuxusermap.py

@@ -17,12 +17,26 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import re
+
 from ipalib import api, errors
 from ipalib import Str, StrEnum, Bool
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    pkey_to_value,
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPQuery,
+    LDAPAddMember,
+    LDAPRemoveMember)
 from ipalib import _, ngettext
+from ipalib import output
 from ipalib.plugins.hbacrule import is_all
+from ipapython.dn import DN
 
 __doc__ = _("""
 SELinux User Mapping

ipalib/plugins/server.py

@@ -8,9 +8,14 @@ import dbus.mainloop.glib
 from ipalib import api, crud, errors, messages
 from ipalib import Int, Str
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPDelete,
+    LDAPObject)
 from ipalib.request import context
 from ipalib import _, ngettext
+from ipalib import output
 
 __doc__ = _("""
 IPA servers

ipalib/plugins/service.py

@@ -22,12 +22,29 @@
 import six
 
 from ipalib import api, errors
-from ipalib import Bytes, StrEnum, Bool
+from ipalib import Bytes, StrEnum, Bool, Str, Flag
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    host_is_master,
+    add_missing_object_class,
+    pkey_to_value,
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPAddMember,
+    LDAPRemoveMember,
+    LDAPQuery,
+    LDAPAddAttribute,
+    LDAPRemoveAttribute)
 from ipalib import x509
 from ipalib import _, ngettext
 from ipalib import util
+from ipalib import output
+from ipapython.dn import DN
+
 import nss.nss as nss
 
 

ipalib/plugins/servicedelegation.py

@@ -7,9 +7,18 @@ import six
 from ipalib import api
 from ipalib import Str
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPAddMember,
+    LDAPRemoveMember,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPSearch,
+    LDAPRetrieve)
 from ipalib.plugins.service import normalize_principal
 from ipalib import _, ngettext
+from ipalib import errors
+from ipapython.dn import DN
 
 if six.PY3:
     unicode = str

ipalib/plugins/sudocmd.py

@@ -20,8 +20,15 @@
 from ipalib import api, errors
 from ipalib import Str
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve)
 from ipalib import _, ngettext
+from ipapython.dn import DN
 
 __doc__ = _("""
 Sudo Commands

ipalib/plugins/sudocmdgroup.py

@@ -20,7 +20,15 @@
 from ipalib import api
 from ipalib import Str
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    LDAPObject,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPAddMember,
+    LDAPRemoveMember)
 from ipalib import _, ngettext
 
 __doc__ = _("""

ipalib/plugins/trust.py

@@ -21,13 +21,24 @@
 import six
 
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    pkey_to_value,
+    entry_to_dict,
+    LDAPCreate,
+    LDAPDelete,
+    LDAPUpdate,
+    LDAPSearch,
+    LDAPRetrieve,
+    LDAPObject,
+    LDAPQuery)
 from ipalib.plugins.dns import dns_container_exists
+from ipapython.dn import DN
 from ipapython.ipautil import realm_to_suffix
 from ipapython.ipa_log_manager import root_logger
-from ipalib import api, Str, StrEnum, Password, Bool, _, ngettext
+from ipalib import api, Str, StrEnum, Password, Bool, _, ngettext, Int, Flag
 from ipalib import Command
 from ipalib import errors
+from ipalib import output
 from ldap import SCOPE_SUBTREE
 from time import sleep
 

ipalib/plugins/user.py

@@ -18,14 +18,17 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import time
 from time import gmtime, strftime
 import posixpath
 import os
 
 import six
 
+from ipalib import api
+from ipalib import errors
 from ipalib import util
-from ipalib import Bool
+from ipalib import Bool, Flag, Str
 from ipalib.plugins.baseuser import (
     baseuser,
     baseuser_add,
@@ -45,13 +48,21 @@ from ipalib.plugins.baseuser import (
     baseuser_remove_manager)
 from ipalib.plugins.idviews import remove_ipaobject_overrides
 from ipalib.plugable import Registry
-from ipalib.plugins.baseldap import *
+from ipalib.plugins.baseldap import (
+    pkey_to_value,
+    LDAPCreate,
+    LDAPSearch,
+    LDAPQuery,
+    LDAPMultiQuery,
+    LDAPAddAttribute,
+    LDAPRemoveAttribute)
 from ipalib.plugins import baseldap
 from ipalib.request import context
 from ipalib import _, ngettext
 from ipalib import output
 from ipalib import x509
 from ipaplatform.paths import paths
+from ipapython.dn import DN
 from ipapython.ipautil import ipa_generate_password
 from ipalib.capabilities import client_has_capability
 

ipalib/session.py

@@ -26,10 +26,12 @@ from six.moves.urllib.parse import urlparse
 
 from ipalib import errors
 from ipalib.text import _
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, log_mgr
 from ipalib import api, errors
 from ipaplatform.paths import paths
-from ipalib.krb_utils import *
+from ipalib.krb_utils import (
+    krb5_parse_ccache,
+    krb5_unparse_ccache)
 from ipapython.cookie import Cookie
 
 __doc__ = '''

ipapython/certmonger.py

@@ -31,7 +31,7 @@ import dbus
 import shlex
 import subprocess
 import tempfile
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipaplatform.paths import paths
 from ipaplatform import services
 

ipapython/dogtag.py

@@ -28,7 +28,7 @@ from ipalib import api, errors
 from ipalib.errors import NetworkError
 from ipalib.text import _
 from ipapython import nsslib, ipautil
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 # Python 3 rename. The package is available in "six.moves.http_client", but
 # pylint cannot handle classes from that alias

ipapython/ipautil.py

@@ -46,7 +46,7 @@ import six
 from six.moves import input
 from six.moves import urllib
 
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython import config
 from ipaplatform.paths import paths
 from ipapython.dn import DN

ipapython/nsslib.py

@@ -22,7 +22,7 @@ from __future__ import print_function
 
 import getpass
 import socket
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 from nss.error import NSPRError
 import nss.io as io

ipapython/sysrestore.py

@@ -26,7 +26,7 @@
 import os
 import os.path
 import shutil
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 import random
 import string
 

ipaserver/dcerpc.py

@@ -22,11 +22,13 @@
 # Make sure we only run this module at the server where samba4-python
 # package is installed to avoid issues with unavailable modules
 
-from ipalib.plugins.baseldap import *
+import re
+import time
+
 from ipalib import api, _
 from ipalib import errors
 from ipapython import ipautil
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython.dn import DN
 from ipaserver.install import installutils
 from ipalib.util import normalize_name

ipaserver/install/bindinstance.py

@@ -34,7 +34,7 @@ from ipaserver.install import installutils
 from ipaserver.install import service
 from ipaserver.install.cainstance import IPA_CA_RECORD
 from ipapython import sysrestore, ipautil, ipaldap
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython.dn import DN
 import ipalib
 from ipalib import api, errors

ipaserver/install/dnskeysyncinstance.py

@@ -17,7 +17,7 @@ import _ipap11helper
 from ipapython.dnsutil import DNSName
 from ipaserver.install import service
 from ipaserver.install import installutils
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython.dn import DN
 from ipapython import ipaldap
 from ipapython import sysrestore, ipautil

ipaserver/install/dsinstance.py

@@ -31,7 +31,7 @@ import stat
 
 import ldap
 
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython import ipautil, sysrestore, ipaldap
 from ipaserver.install import service
 from ipaserver.install import installutils

ipaserver/install/krbinstance.py

@@ -32,7 +32,7 @@ from ipapython import sysrestore
 from ipapython import ipautil
 from ipapython import kernel_keyring
 from ipalib.constants import CACERT
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython.dn import DN
 
 from ipaserver.install import replication

ipaserver/install/ldapupdate.py

@@ -41,7 +41,7 @@ from ipalib import constants
 from ipaplatform.paths import paths
 from ipaplatform import services
 from ipapython.dn import DN
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import log_mgr
 from ipapython.ipautil import wait_for_open_socket
 
 UPDATES_DIR=paths.UPDATES_DIR

ipaserver/install/ntpinstance.py

@@ -23,7 +23,7 @@ from ipapython import sysrestore
 from ipapython import ipautil
 from ipaplatform.constants import constants
 from ipaplatform.paths import paths
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 NTPD_OPTS_VAR = constants.NTPD_OPTS_VAR
 NTPD_OPTS_QUOTE = constants.NTPD_OPTS_QUOTE

ipaserver/install/odsexporterinstance.py

@@ -10,7 +10,7 @@ import ldap
 
 from ipaserver.install import service
 from ipaserver.install import installutils
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython.dn import DN
 from ipapython import sysrestore, ipautil, ipaldap
 from ipaplatform.paths import paths

ipaserver/install/opendnssecinstance.py

@@ -12,7 +12,7 @@ from subprocess import CalledProcessError
 import _ipap11helper
 from ipaserver.install import service
 from ipaserver.install import installutils
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython.dn import DN
 from ipapython import sysrestore, ipautil, ipaldap, p11helper
 from ipaplatform import services

ipaserver/install/plugins/adtrust.py

@@ -20,7 +20,7 @@
 from ipalib import api, errors
 from ipalib import Updater
 from ipapython.dn import DN
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 DEFAULT_ID_RANGE_SIZE = 200000
 

ipaserver/install/plugins/dns.py

@@ -27,7 +27,7 @@ from ipalib import api, errors, util
 from ipalib import Updater
 from ipapython.dn import DN
 from ipalib.plugins.dns import dns_container_exists
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 
 class update_dnszones(Updater):

ipaserver/install/plugins/update_idranges.py

@@ -20,7 +20,7 @@
 from ipalib import api, errors
 from ipalib import Updater
 from ipapython.dn import DN
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 
 class update_idrange_type(Updater):

ipaserver/install/plugins/update_services.py

@@ -20,7 +20,7 @@
 from ipalib import api, errors
 from ipalib import Updater
 from ipapython.dn import DN
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 
 class update_service_principalalias(Updater):

ipaserver/install/plugins/update_uniqueness.py

@@ -20,7 +20,7 @@
 from ipalib import api, errors
 from ipalib import Updater
 from ipapython.dn import DN
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 
 class update_uniqueness_plugins_to_new_syntax(Updater):

ipaserver/install/replication.py

@@ -30,7 +30,7 @@ import ldap
 from ipalib import api, errors
 from ipalib.constants import CACERT
 from ipalib.util import create_topology_graph, get_topology_connection_errors
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython import ipautil, ipaldap
 from ipapython.dn import DN
 from ipaplatform import services

ipaserver/install/server/upgrade.py

@@ -22,7 +22,7 @@ from ipaplatform import services
 from ipaplatform.tasks import tasks
 from ipapython import ipautil, sysrestore, version, certdb
 from ipapython import ipaldap
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipapython import certmonger
 from ipapython.dn import DN
 from ipaplatform.paths import paths

ipaserver/install/service.py

@@ -25,7 +25,7 @@ import traceback
 
 from ipapython import sysrestore, ipautil, ipaldap
 from ipapython.dn import DN
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipalib import api, errors, certstore
 from ipaplatform import services
 from ipaplatform.paths import paths

ipaserver/install/sysupgrade.py

@@ -22,7 +22,7 @@ import os.path
 
 from ipapython import sysrestore
 from ipaplatform.paths import paths
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 STATEFILE_FILE = 'sysupgrade.state'
 

ipaserver/install/upgradeinstance.py

@@ -23,7 +23,7 @@ import random
 import traceback
 from ipaplatform.paths import paths
 from ipaplatform import services
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 
 from ipaserver.install import installutils
 from ipaserver.install import schemaupdate

ipatests/test_ipapython/test_dn.py

@@ -1,7 +1,6 @@
 import contextlib
 import unittest
 import pytest
-from ipapython.dn import *  # FIXME
 
 import six
 

make-lint

@@ -243,6 +243,7 @@ def main():
         linter.set_option('enable', 'F')
         linter.set_option('enable', 'E')
         linter.set_option('enable', 'unused-import')
+        linter.set_option('enable', 'unused-wildcard-import')
 
     linter.set_reporter(TextReporter())
     linter.set_option('msg-template',