IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2026-08-09 12:38:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

crash when removing a replica

Browse Source 
when a server is removed from the topology the plugin tries to remove the
credentials from the replica and the bind dn group.
It performs an internal search for the ldap principal, but can fail if it was already removed
Due to an unitialized variable in this case it can eitehr crash or erroneously remove all
principals.

Reviewed-By: Fraser Tweedale <ftweedal@redhat.com>
Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
This commit is contained in:
Ludwig Krispenz
2015-06-04 11:42:44 +02:00
committed by Petr Vobornik
parent 4e05ffa22c
commit f87324df54
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
daemons/ipa-slapi-plugins/topology/topology_util.c
+11 -3
View File
@@ -1201,7 +1201,15 @@ void
ipa_topo_util_disable_repl_from_host(char *repl_root, char *delhost)
{
char *principal = ipa_topo_util_get_ldap_principal(repl_root, delhost);
ipa_topo_util_disable_repl_for_principal(repl_root, principal);
if (principal) {
ipa_topo_util_disable_repl_for_principal(repl_root, principal);
slapi_ch_free_string(&principal);
} else {
slapi_log_error(SLAPI_LOG_PLUGIN, IPA_TOPO_PLUGIN_SUBSYSTEM,
"ipa_topo_util_disable_repl_from_host: "
"failed to get ldap principal for host: %s \n",
delhost);
}
}
void
@@ -1322,10 +1330,10 @@ char *
ipa_topo_util_get_ldap_principal(char *repl_root, char *hostname)
{
int rc = 0;
Slapi_Entry **entries;
Slapi_Entry **entries = NULL;
Slapi_PBlock *pb = NULL;
char *filter;
char *dn;
char *dn = NULL;
filter = slapi_ch_smprintf("krbprincipalname=ldap/%s*",hostname);
pb = slapi_pblock_new();