IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Fix failing test_ipalib/test_parameters

Browse Source 
Parameters test fails because of KeyError caused by improper manipulation with
kwargs in Param.__init__ method. During initialization, if kwargs['required']
or kwargs['multivalue'] is None, it is delete from dictionary and hence the
missing key. Small change of the condition prevents this from happening.

Partially fixes https://fedorahosted.org/freeipa/ticket/6292

Backported to ipa-4-4 branch as per
https://fedorahosted.org/freeipa/ticket/6395

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
This commit is contained in:
Lenka Doudova
2016-10-06 10:54:07 +02:00
committed by Martin Babinsky
parent 0e2818d9aa
commit ff60afcadd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ipalib/parameters.py
View File

@@ -472,7 +472,7 @@ class Param(ReadOnly):
CALLABLE_ERROR % (key, value, type(value))
)
kw[key] = value
else:
elif key not in ('required', 'multivalue'):
kw.pop(key, None)
# We keep these values to use in __repr__():