Commit Graph

833 Commits

Author SHA1 Message Date
Jim Meyering
0d2212fe2f remove useless if-before-free tests
I've been on a crusade (;-) to remove useless if-before-free tests,
so ran a script that spotted some here.  I think I removed the first
batch (without braces) automatically, then manually removed the ones
with curly braces around the free statements.

You may well have doubts about the portability of removing those
tests, but as long as you don't care about SunOS4 or earlier, you'll
be fine.  I've done similar things for e.g., coreutils, glibc, and git,
and have had no problems.
2008-05-15 12:59:28 -04:00
Jim Meyering
3256365277 * ipa_pwd_extop.c (encrypt_encode_key): Handle malloc failure. 2008-05-15 12:59:28 -04:00
Simo Sorce
d0f0d97be6 If there is an error we need to send back a reply ourselves.
Return also an intelligible error message.
2008-05-15 12:59:28 -04:00
Simo Sorce
fb3555c483 For some unknown reason the sort control returns values sorted in reverse.
Ask for inverse order to get them straight ...
2008-05-15 12:59:28 -04:00
Simo Sorce
10f0881dba Implement checks to make sure we are not assigning a number that is in use.
Change config to support a maximum value so that ranges can be defined.
Add stubs to reach out and ask to swap in new ranges and notify that new
chuncks are needed/used.
2008-05-15 12:59:28 -04:00
Martin Nagy
2d608a8354 Don't ask the user again if he wants to replace bind configuration files if he specified --setup-bind.
430090
2008-05-14 16:25:10 -04:00
Martin Nagy
28f312664e Fix typo, /etc/resolve.conf -> /etc/resolv.conf.
444660
2008-05-14 16:25:06 -04:00
Rob Crittenden
2b05d973a4 Fix typo in ipa-client-install manpage.
446201
2008-05-14 11:41:56 -04:00
Rob Crittenden
92d7f9c28a Make sure all services are stopped during uninstall.
We were just shutting down the KDC if it had been started prior to IPA
installation. We need to stop it in all cases.

And we should restart nscd as it may have made an LDAP connection.

440322
2008-05-14 09:57:09 -04:00
Rob Crittenden
99141e3a04 Enforce the maximum username length set by IPA Policy
439891
2008-05-14 09:48:21 -04:00
Rob Crittenden
319cb38e28 Do a more thorough job of removing an existing DS instance.
Add /usr/lib/dirsrv/slapd-INSTANCE to the list of directories removed.

442753
2008-05-13 22:53:01 -04:00
Rob Crittenden
3daa94ccc0 Catch name resolution errors coming from the socket module.
442650
2008-05-13 12:00:21 -04:00
Rob Crittenden
b1cc4199fa The admin user doesn't have the inetorgperson objectclass so don't have a givenname attribute. The UI is currently hardcoded to require "first name" which renders the admin user uneditable via the UI.
This is a hack that will allow admin to be edited, assuming that one doesn't
try to add a firstname field.

440548
2008-05-13 11:59:46 -04:00
Simo Sorce
a86b1eaeed fix stupid typo,
thanks Nalin for spotting this.
2008-05-10 11:25:31 -04:00
Simo Sorce
0b2756bed7 Fix existence check, default_server is an array so we need to
check its length to determine if it is empty
2008-05-10 11:25:31 -04:00
Rob Crittenden
41457f0e81 Display information on how to uninstall a partially installed server.
This may have failed either because the user pressed ^C or something
failed during installation.

442454
2008-05-09 14:05:47 -04:00
Rob Crittenden
ae641ed31b Include information on where to look if a hostname resolves to localhost.
442812
2008-05-09 14:04:04 -04:00
Rob Crittenden
9fe649b804 Convert mercurial command to git equivalent for creating an archive.
By default it will use the master branch of the repo this is run from.
To specify a different branch use the argument TARGET=<branch>

e.g. make dist TARGET=ipa-1-0

442419
2008-05-09 11:09:49 -04:00
Simo Sorce
5c4b1770c0 On IPA Servers connect to ourselves using localhost,
and avoid searching for KDC servers via DNS, we just connect
to ourselves.
2008-05-08 17:31:19 -04:00
Simo Sorce
34c6ac06c6 Return better ewrror message that gives a hint about who actually returned it
+ Some cleanups (trainling spaces and such).
2008-05-08 17:03:43 -04:00
Rob Crittenden
6538c150b1 Detect existing DS instances and prompt for removal during replica install.
442454
2008-05-08 15:56:10 -04:00
Rob Crittenden
318c6adfae Add missing colon to function definition that broke the build 2008-05-08 15:17:59 -04:00
Rob Crittenden
bd9dea888d Add a version API to the server so it knows what version it is.
435019
2008-05-08 13:01:27 -04:00
Rob Crittenden
24f43bc846 Don't allow the IPA server service principals to be removed.
440282
2008-05-08 12:57:31 -04:00
Rob Crittenden
2bb64e404c Don't prompt for confirmation of DM password when installing a replica.
It implies that you are setting a new password and you really aren't.

Also added a catch for KeyboardInterrupt with instructions on how to
recover from a partial install.

441607
2008-05-08 12:01:38 -04:00
Rob Crittenden
570b71372f Second half of the redoing how the version is managed. 2008-05-07 18:26:03 -04:00
Simo Sorce
6f4d71d2cc Indent the plugin accordingly to our style guidelines.
Used indent -kr -nut dna.c for most of the changes
2008-05-07 14:45:46 -04:00
Simo Sorce
70d5209b11 Fix a bug in our dns library, do not return the query as a reply if 0 replies were returned. 2008-05-07 14:42:49 -04:00
Rob Crittenden
8e7561cff6 Refine our web space some more so that everything we reference is in /ipa
UI: /ipa/ui
XML-RPC: /ipa/xml
errors: /ipa/errors
config: /ipa/config

I had to hardcode that URI into the CSS pages but TurboGears handles the
rest of the translations with tg.url().

Added a version to ipa.conf and ipa-rewrite.conf so we can update them
in the future if needed with ipa-upgradeconfig

440443
2008-05-07 09:41:32 -04:00
Rob Crittenden
5ad2af3429 Redo the way versioning works in freeIPA.
The file VERSION is now the sole-source of versioning.

The generated .spec files will been removed in the maintainer-clean targets
and have been removed from the repository.

By default a GIT build is done. To do a non-GIT build do:

 $ make TARGET IPA_VERSION_IS_GIT_SNAPSHOT=no

When updating the version you can run this to regenerate the version:

 $ make version-update

The version can be determined in Python by using ipaserver.version.VERSION
2008-05-05 13:53:57 -04:00
Rob Crittenden
23fe67996c Remove duplicated "the" and add some formatting to the EXAMPLE for clarity.
443012
2008-05-05 11:10:40 -04:00
W. Michael Petullo
29ddbc610c This patch begins the process of replacing OpenLDAP with mozldap.
FreeIPA relies on RedHat's Directory Server, which uses mozldap.
A FreeIPA build using mozldap would reduce the project's dependencies and
redundant code. In addition, mozldap uses NSS instead of OpenSSL.
This is beneficial for the reasons listed in [1].

[1] http://fedoraproject.org/wiki/FedoraCryptoConsolidation
2008-05-01 09:59:43 -04:00
Rob Crittenden
274eb708c2 Fix ownership of the Apache NSS cert and key databases.
The group "apache" needs to have read access to them so they will work in
Fedora 9+.
2008-04-30 09:44:48 -04:00
Rob Crittenden
306d8241b3 Fix the client-side search size limit.
I've changed the variable name searchlimit to sizelimit to match the
name in python-ldap (and hopefully therefore be more readable).

The big change was changing the default value from 0 to -1. As 0 we were
never using the value from cn=ipaconfig

python-ldap expects this to be an int type

In the UI sizelimit was hardcoded at 0 for users

439880
2008-04-25 16:46:13 -04:00
Simo Sorce
1e3276cec1 Make sure recent ldapmodify tool (as in F9) do not complain by splitting the
operation into 2 modify operations
2008-04-25 14:18:39 -04:00
Rob Crittenden
12ea8efc0b Add --verbose option so the HTTP headers and XML request/response can be seen.
Also re-do the way modules are imported. I was attemping to have ^C handled
gracefully but the way I did it could mask other problems.

443987
2008-04-25 10:35:22 -04:00
Rob Crittenden
47e6a75cff Add nfs as a service principal type.
440242
2008-04-23 15:42:41 -04:00
Rob Crittenden
03b3dbd2ab Don't let a user change their own uid. Fix some related errors if they try.
440895
2008-04-23 15:36:14 -04:00
Rob Crittenden
2427e7c130 Don't allow a replica to prepare a replica for itself.
442756
2008-04-23 15:36:13 -04:00
Nathan Kinder
d854d25483 Fixed various memory leaks in memberOf plug-in.
440474
2008-04-22 16:55:50 -04:00
Simo Sorce
298747e15a Make sure we always have the [domain-realm] section or kerberos libs misbheave. 2008-04-22 15:28:42 -04:00
Rob Crittenden
def28f3d5b Become version 1.0.0 2008-04-16 14:29:17 -07:00
Rob Crittenden
dce8008167 Catch all errors when obtaining an LDAP connection.
442582
2008-04-15 21:08:55 -07:00
Rob Crittenden
78bdb75291 Move print statement to the correct scope so it displays both lock and unlock.
442625
2008-04-15 21:27:04 -04:00
Rob Crittenden
4eb7c51e59 Better detection of DS not starting.
The dirsrv init script always returns 0 on status checks, even if an
instance is not started. So we have to look through the output instead.

442452
2008-04-14 23:14:16 -04:00
Rob Crittenden
b1f58e5441 Don't quit trying to lock a user if they aren't in the activated group.
Users are considered activated by default so don't need to be in the
activated group explicitly. Ignore the "not in group" error when trying
to remove them.

442470
2008-04-14 23:13:58 -04:00
Rob Crittenden
ff3ca61f73 Handle exceptions more gracefully on systems with python-ldap 2.2.0
442136
2008-04-14 18:23:29 -04:00
Rob Crittenden
ce3f79e51c Configure the ipa_pwd_extop plugin on replicas.
If plugin isn't configured then the kerberos attributes don't get populated.
User's will get Preauthentication errors from the kerberos libraries
because there is no krbPrincipalKey to match against.

442134
2008-04-14 17:55:25 -04:00
Rob Crittenden
27691b9e1c Use the same kpasswd.keytab on all replicas.
If we generate a new keytab for each replica then effectively password
changes can only occur on the last replica created.

439905
2008-04-09 16:57:41 -04:00
Simo Sorce
24a7cf3714 Fix client discovery and make sure command line options are not overwritten
with discovered options, just verified.
2008-04-09 15:55:46 -04:00