Fixed Tag Attributes 'enter' key causing the value to get lost while triggering the Apply (fixes #1860)

This commit is contained in:
Djamil Legato
2017-06-27 18:55:28 -07:00
parent e0661cb7b6
commit 09208eccf0
3 changed files with 28 additions and 7 deletions
+2 -1
View File
@@ -2,12 +2,13 @@
## mm/dd/2017
1. [Common](#common)
2. [](#bugfix)
2. [](#improved)
- Accessibility: Menu / Offcanvas: Offcanvas and hamburger toggle menu are now ARIA compatible (#1891)
3. [](#bugfix)
- Menu: Disable Dropdowns still Shows Indicator (#2031)
- Menu: Fixed frontend menu 'Extended' option, resetting heights of wrapping containers not necessarily related to the menu itself (#2025)
- Menu / Offcanvas: Fixed issue preventing the offcanvas toggle to show when Menu set with only icons (#1939)
- Fixed Tag Attributes 'enter' key causing the value to get lost while triggering the Apply (#1860)
3. [WordPress](#wordpress)
1. [](#new)
- Updated Timber to v1.3.2
@@ -102,8 +102,7 @@ ready(function() {
body.emit('change', { target: dataField });
});
// Change values
body.delegate('blur', '[data-keyvalue-item] input[type="text"]', function(event, element) {
var onBlur = function(event, element) {
var parent = element.parent('[data-keyvalue-item]'),
wrapper = parent.find('.g-keyvalue-wrapper'),
keyElement = parent.find('[data-keyvalue-key]'),
@@ -151,7 +150,18 @@ ready(function() {
dataField.value(escapeUnicode(JSON.stringify(data)));
body.emit('change', { target: dataField });
}, true);
};
// Catch return key
body.delegate('keydown', '[data-keyvalue-item] input[type="text"]', function(event, element) {
var key = (event.which ? event.which : event.keyCode);
if (key === 13) { // Enter
onBlur(event, element);
}
});
// Change values
body.delegate('blur', '[data-keyvalue-item] input[type="text"]', onBlur, true);
body.delegate('update', '[data-keyvalue-data]', function(event, element) {
var parent = element.parent(),
+13 -3
View File
@@ -9270,8 +9270,7 @@ ready(function() {
body.emit('change', { target: dataField });
});
// Change values
body.delegate('blur', '[data-keyvalue-item] input[type="text"]', function(event, element) {
var onBlur = function(event, element) {
var parent = element.parent('[data-keyvalue-item]'),
wrapper = parent.find('.g-keyvalue-wrapper'),
keyElement = parent.find('[data-keyvalue-key]'),
@@ -9319,7 +9318,18 @@ ready(function() {
dataField.value(escapeUnicode(JSON.stringify(data)));
body.emit('change', { target: dataField });
}, true);
};
// Catch return key
body.delegate('keydown', '[data-keyvalue-item] input[type="text"]', function(event, element) {
var key = (event.which ? event.which : event.keyCode);
if (key === 13) { // Enter
onBlur(event, element);
}
});
// Change values
body.delegate('blur', '[data-keyvalue-item] input[type="text"]', onBlur, true);
body.delegate('update', '[data-keyvalue-data]', function(event, element) {
var parent = element.parent(),