IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

chore: Rename renderHelper > renderDataPanel and move logic to smaller functions

Browse Source
This commit is contained in:
Johannes Schill
2019-02-12 12:25:10 +01:00
parent b5dbf26dc4
commit 01208ccd68
1 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
public/app/features/dashboard/dashgrid/PanelChrome.tsx
View File

@@ -94,6 +94,25 @@ export class PanelChrome extends PureComponent<Props, State> {
return !this.props.dashboard.otherPanelInFullscreen(this.props.panel);
}
get hasPanelSnapshot() {
const { panel } = this.props;
return panel.snapshotData && panel.snapshotData.length;
}
get hasDataPanel() {
return !this.props.plugin.noQueries && !this.hasPanelSnapshot;
}
get getDataForPanel() {
const { panel, plugin } = this.props;
if (plugin.noQueries) {
return null;
}
return this.hasPanelSnapshot ? snapshotDataToPanelData(panel) : null;
}
renderPanelPlugin(loading: LoadingState, panelData: PanelData, width: number, height: number): JSX.Element {
const { panel, plugin } = this.props;
const { timeRange, renderCounter } = this.state;
@@ -121,20 +140,14 @@ export class PanelChrome extends PureComponent<Props, State> {
);
}
renderHelper = (width: number, height: number): JSX.Element => {
const { panel, plugin } = this.props;
renderDataPanel = (width: number, height: number): JSX.Element => {
const { panel } = this.props;
const { refreshCounter, timeRange } = this.state;
const { datasource, targets } = panel;
return (
<>
{panel.snapshotData && panel.snapshotData.length > 0 ? (
this.renderPanelPlugin(LoadingState.Done, snapshotDataToPanelData(panel), width, height)
) : (
<>
{plugin.noQueries ?
this.renderPanelPlugin(LoadingState.Done, null, width, height)
: (
<DataPanel
{this.hasDataPanel ? (
<DataPanel
panelId={panel.id}
datasource={datasource}
queries={targets}
@@ -142,20 +155,18 @@ export class PanelChrome extends PureComponent<Props, State> {
isVisible={this.isVisible}
widthPixels={width}
refreshCounter={refreshCounter}
onDataResponse={this.onDataResponse}
>
onDataResponse={this.onDataResponse} >
{({ loading, panelData }) => {
return this.renderPanelPlugin(loading, panelData, width, height);
}}
</DataPanel>
)}
</>
)}
) : (
this.renderPanelPlugin(LoadingState.Done, this.getDataForPanel, width, height)
)}
</>
);
}
render() {
const { dashboard, panel } = this.props;
const { timeInfo } = this.state;
@@ -180,7 +191,7 @@ export class PanelChrome extends PureComponent<Props, State> {
scopedVars={panel.scopedVars}
links={panel.links}
/>
{this.renderHelper(width, height)}
{this.renderDataPanel(width, height)}
</div>
);
}}