XY Chart: fix editor error with empty frame (no fields) (#30573)

This commit is contained in:
Ryan McKinley 2021-01-24 08:58:18 -08:00 committed by GitHub
parent 2a21f067b7
commit 08312897c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -28,7 +28,7 @@ export const XYDimsEditor: FC<StandardEditorProps<XYDimensionConfig, any, Option
}
const frameNames = useMemo(() => {
if (context.data && context.data.length > 0) {
if (context?.data?.length) {
return context.data.map((f, idx) => ({
value: idx,
label: getFrameDisplayName(f, idx),
@ -56,7 +56,7 @@ export const XYDimsEditor: FC<StandardEditorProps<XYDimensionConfig, any, Option
};
const frame = context.data ? context.data[value?.frame ?? 0] : undefined;
if (frame) {
const xName = getFieldDisplayName(dims.x, dims.frame, context.data);
const xName = dims.x ? getFieldDisplayName(dims.x, dims.frame, context.data) : undefined;
for (let field of frame.fields) {
if (isGraphable(field)) {
const name = getFieldDisplayName(field, frame, context.data);