IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: assign owner for prometheusAzureOverrideAudience (#64620)

Browse Source 
assign the last owner
This commit is contained in:
Artur Wierzbicki
2023-03-13 16:56:55 +04:00
committed by GitHub
parent c363a81806
commit 08f2791b22
2 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/services/featuremgmt/registry.go
View File

@@ -69,6 +69,7 @@ var (
Name: "prometheusAzureOverrideAudience",
Description: "Experimental. Allow override default AAD audience for Azure Prometheus endpoint",
State: FeatureStateBeta,
Owner: grafanaObservabilityMetricsSquad,
},
{
Name: "publicDashboards",

18
pkg/services/featuremgmt/toggles_gen_test.go
View File

@@ -41,26 +41,10 @@ func TestFeatureToggleFiles(t *testing.T) {
}
})
ownerlessFeatures := map[string]bool{
"prometheusAzureOverrideAudience": true,
}
t.Run("all new features should have an owner", func(t *testing.T) {
for _, flag := range standardFeatureFlags {
if flag.Owner == "" {
if _, ok := ownerlessFeatures[flag.Name]; !ok {
t.Errorf("feature %s does not have an owner", flag.Name)
}
}
}
})
t.Run("features with assigned owner should not be on the ownerless list", func(t *testing.T) {
for _, flag := range standardFeatureFlags {
if flag.Owner != "" {
if _, ok := ownerlessFeatures[flag.Name]; ok {
t.Errorf("feature %s should be removed from the ownerless list", flag.Name)
}
t.Errorf("feature %s does not have an owner. please fill the FeatureFlag.Owner property", flag.Name)
}
}
})