IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

dashboard: Close/hide 'Add Panel' before saving a dashboard (#10482)

Browse Source 
Fixes #10472
This commit is contained in:
Marcus Efraimsson
2018-01-11 08:56:19 +01:00
committed by Torkel Ödegaard
parent 9606a34e0a
commit 2843961677
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
public/app/features/dashboard/dashboard_model.ts
View File

@@ -145,7 +145,10 @@ export class DashboardModel {
};
// get panel save models
copy.panels = _.map(this.panels, panel => panel.getSaveModel());
copy.panels = _.chain(this.panels)
.filter(panel => panel.type !== 'add-panel')
.map(panel => panel.getSaveModel())
.value();
// sort by keys
copy = sortByKeys(copy);

17
public/app/features/dashboard/specs/dashboard_model.jest.ts
View File

@@ -49,6 +49,23 @@ describe('DashboardModel', function() {
expect(keys[0]).toBe('annotations');
expect(keys[1]).toBe('autoUpdate');
});
it('should remove add panel panels', () => {
var model = new DashboardModel({});
model.addPanel({
type: 'add-panel',
});
model.addPanel({
type: 'graph',
});
model.addPanel({
type: 'add-panel',
});
var saveModel = model.getSaveModelClone();
var panels = saveModel.panels;
expect(panels.length).toBe(1);
});
});
describe('row and panel manipulation', function() {