IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Reduce strict error in DataSourceHttpSettings.onChange callback (#40497)

Browse Source 
* Reduce strict TS errors

* Update ERROR_COUNT_LIMIT after merging from main

* Update number of errors
This commit is contained in:
Piotr Jamróz 2021-10-18 10:40:43 +02:00 committed by GitHub
parent 6201b5b1d9
commit 2de769420e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/grafana-ui/src/components/DataSourceSettings/types.ts
View File

@ -6,11 +6,11 @@ export interface AzureAuthSettings {
azureSettingsUI?: React.ComponentType<HttpSettingsBaseProps>;
}
export interface HttpSettingsBaseProps {
export interface HttpSettingsBaseProps<JSONData = any, SecureJSONData = any> {
/** The configuration object of the data source */
dataSourceConfig: DataSourceSettings<any, any>;
dataSourceConfig: DataSourceSettings<JSONData, SecureJSONData>;
/** Callback for handling changes to the configuration object */
onChange: (config: DataSourceSettings) => void;
onChange: (config: DataSourceSettings<JSONData, SecureJSONData>) => void;
/** Show the Forward OAuth identity option */
showForwardOAuthIdentityOption?: boolean;
}

2
scripts/ci-check-strict.sh
View File

@ -3,7 +3,7 @@ set -e
echo -e "Collecting code stats (typescript errors & more)"
ERROR_COUNT_LIMIT=17
ERROR_COUNT_LIMIT=13
ERROR_COUNT="$(./node_modules/.bin/tsc --project tsconfig.json --noEmit --strict true | grep -oP 'Found \K(\d+)')"
if [ "$ERROR_COUNT" -gt $ERROR_COUNT_LIMIT ]; then