TemplateSrv: Fix ad hoc filters not applying correctly when using datasource variables (#75977)

This commit is contained in:
kay delaney
2023-10-05 10:18:38 +00:00
committed by GitHub
parent 3e2ca29c8d
commit 374e2a68f6
2 changed files with 6 additions and 2 deletions
@@ -198,7 +198,7 @@ describe('templateSrv', () => {
{
type: 'datasource',
name: 'ds',
current: { value: 'logstash', text: 'logstash' },
current: { value: 'logstash-id', text: 'logstash' },
},
{ type: 'adhoc', name: 'test', datasource: { uid: 'oogle' }, filters: [1] },
{ type: 'adhoc', name: 'test2', datasource: { uid: '$ds' }, filters: [2] },
@@ -209,6 +209,10 @@ describe('templateSrv', () => {
name: 'oogle',
uid: 'oogle',
}),
logstash: mockDataSource({
name: 'logstash',
uid: 'logstash-id',
}),
})
);
});
@@ -142,7 +142,7 @@ export class TemplateSrv implements BaseTemplateSrv {
if (variableUid === ds.uid) {
filters = filters.concat(variable.filters);
} else if (variableUid?.indexOf('$') === 0) {
if (this.replace(variableUid) === datasourceName) {
if (this.replace(variableUid) === ds.uid) {
filters = filters.concat(variable.filters);
}
}