IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bookmarks: Do not show on navigation or button for unauthed users (#96836)

Browse Source
This commit is contained in:
Joao Silva
2024-11-21 15:32:38 +00:00
committed by GitHub
parent 35d1274919
commit 3ceaa42d20
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/services/navtree/navtreeimpl/navtree.go
View File

@@ -172,7 +172,7 @@ func (s *ServiceImpl) GetNavTree(c *contextmodel.ReqContext, prefs *pref.Prefere
treeRoot.RemoveSectionByID(navtree.NavIDCfg)
}
if s.features.IsEnabled(c.Req.Context(), featuremgmt.FlagPinNavItems) {
if s.features.IsEnabled(c.Req.Context(), featuremgmt.FlagPinNavItems) && c.IsSignedIn {
treeRoot.AddSection(&navtree.NavLink{
Text: "Bookmarks",
Id: navtree.NavIDBookmarks,

3
public/app/core/components/AppChrome/MegaMenu/MegaMenuItemText.tsx
View File

@@ -6,6 +6,7 @@ import { selectors } from '@grafana/e2e-selectors';
import { config } from '@grafana/runtime';
import { Icon, IconButton, Link, useTheme2 } from '@grafana/ui';
import { t } from 'app/core/internationalization';
import { contextSrv } from 'app/core/services/context_srv';
export interface Props {
children: React.ReactNode;
@@ -50,7 +51,7 @@ export function MegaMenuItemText({ children, isActive, onClick, target, url, onP
>
{linkContent}
</LinkComponent>
{config.featureToggles.pinNavItems && url && url !== '/bookmarks' && (
{config.featureToggles.pinNavItems && contextSrv.isSignedIn && url && url !== '/bookmarks' && (
<IconButton
name="bookmark"
className={'pin-icon'}