IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Panel: Keyboard focus shortcuts prioritization (#86772)

Browse Source 
* Panel: Keyboard shortcuts prio

* Remove redundant Array.from

* Simplify

* Handle Scenes use case
This commit is contained in:
Tobias Skarhed 2024-04-24 13:46:40 +02:00 committed by GitHub
parent f382bd402c
commit 3e450ec4bf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
public/app/core/services/withFocusedPanelId.ts
View File

@ -2,6 +2,14 @@ export function withFocusedPanel(fn: (panelId: number) => void) {
return () => {
const elements = document.querySelectorAll(':hover');
// Handle keyboard focus first
const focusedGridElement = document.activeElement?.closest('[data-panelid]');
if (focusedGridElement instanceof HTMLElement && focusedGridElement.dataset?.panelid) {
fn(parseInt(focusedGridElement.dataset?.panelid, 10));
return;
}
for (let i = elements.length - 1; i > 0; i--) {
const element = elements[i];
if (element instanceof HTMLElement && element.dataset?.panelid) {

10
public/app/features/dashboard-scene/scene/keyboardShortcuts.ts
View File

@ -146,6 +146,16 @@ export function setupKeyboardShortcuts(scene: DashboardScene) {
export function withFocusedPanel(scene: DashboardScene, fn: (vizPanel: VizPanel) => void) {
return () => {
const elements = document.querySelectorAll(':hover');
const focusedGridElement = document.activeElement?.closest('[data-viz-panel-key]');
if (focusedGridElement instanceof HTMLElement && focusedGridElement.dataset?.vizPanelKey) {
const panelKey = focusedGridElement.dataset?.vizPanelKey;
const vizPanel = sceneGraph.findObject(scene, (o) => o.state.key === panelKey);
if (vizPanel && vizPanel instanceof VizPanel) {
fn(vizPanel);
return;
}
}
for (let i = elements.length - 1; i > 0; i--) {
const element = elements[i];