snapshots: Close response body after error check

This commit is contained in:
Victor Cinaglia 2018-12-18 08:32:49 -05:00
parent 411d67cae7
commit 48fe92a945

View File

@ -51,13 +51,10 @@ func createExternalDashboardSnapshot(cmd m.CreateDashboardSnapshotCommand) (*Cre
}
response, err := client.Post(setting.ExternalSnapshotUrl+"/api/snapshots", "application/json", bytes.NewBuffer(messageBytes))
if response != nil {
defer response.Body.Close()
}
if err != nil {
return nil, err
}
defer response.Body.Close()
if response.StatusCode != 200 {
return nil, fmt.Errorf("Create external snapshot response status code %d", response.StatusCode)
@ -159,14 +156,10 @@ func GetDashboardSnapshot(c *m.ReqContext) {
func deleteExternalDashboardSnapshot(externalUrl string) error {
response, err := client.Get(externalUrl)
if response != nil {
defer response.Body.Close()
}
if err != nil {
return err
}
defer response.Body.Close()
if response.StatusCode == 200 {
return nil