IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix: use type=button in editor (#55731)

Browse Source
This commit is contained in:
Giordano Ricci 2022-09-27 09:20:23 +01:00 committed by GitHub
parent 2bbc7c40e9
commit 4cd4bc84b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
public/app/plugins/datasource/elasticsearch/components/QueryEditor/QueryEditorRow.tsx
View File

@ -35,6 +35,7 @@ export const QueryEditorRow = ({
aria-pressed={hidden} aria-pressed={hidden}
aria-label="hide metric" aria-label="hide metric"
className={styles.icon} className={styles.icon}
type="button"
/> />
)} )}
<IconButton <IconButton
@ -44,6 +45,7 @@ export const QueryEditorRow = ({
onClick={onRemoveClick || noop} onClick={onRemoveClick || noop}
disabled={!onRemoveClick} disabled={!onRemoveClick}
aria-label="remove metric" aria-label="remove metric"
type="button"
/> />
</span> </span>
</InlineLabel> </InlineLabel>

1
public/app/plugins/datasource/elasticsearch/components/QueryEditor/SettingsEditorContainer.tsx
View File

@ -47,6 +47,7 @@ export const SettingsEditorContainer = ({ label, children, hidden = false }: Pro
className={cx('gf-form-label query-part', styles.button, segmentStyles)} className={cx('gf-form-label query-part', styles.button, segmentStyles)}
onClick={() => setOpen(!open)} onClick={() => setOpen(!open)}
aria-expanded={open} aria-expanded={open}
type="button"
> >
<Icon name={open ? 'angle-down' : 'angle-right'} aria-hidden="true" className={styles.icon} /> <Icon name={open ? 'angle-down' : 'angle-right'} aria-hidden="true" className={styles.icon} />
{label} {label}