Public Dashboards: Fixing annotations validations for public dashboards (#57455)

This commit is contained in:
lean.dev 2022-10-21 12:06:39 -03:00 committed by GitHub
parent 07ac388e8b
commit 654db452cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -4,10 +4,10 @@ import { catchError, filter, finalize, map, mergeAll, mergeMap, reduce, takeUnti
import { AnnotationQuery, DataSourceApi } from '@grafana/data';
import { getDataSourceSrv } from '@grafana/runtime';
import { getConfig } from 'app/core/config';
import { AnnotationQueryFinished, AnnotationQueryStarted } from '../../../../types/events';
import { PUBLIC_DATASOURCE, PublicDashboardDataSource } from '../../../dashboard/services/PublicDashboardDataSource';
import { DashboardModel } from '../../../dashboard/state';
import { AnnotationsQueryRunner } from './AnnotationsQueryRunner';
import { getDashboardQueryRunner } from './DashboardQueryRunner';
@ -47,7 +47,8 @@ export class AnnotationsWorker implements DashboardQueryRunnerWorker {
}
const observables = annotations.map((annotation) => {
let datasourceObservable;
if (dashboard.meta.publicDashboardAccessToken !== '') {
if (getConfig().isPublicDashboardView) {
const pubdashDatasource = new PublicDashboardDataSource(PUBLIC_DATASOURCE);
datasourceObservable = of(pubdashDatasource).pipe(catchError(handleDatasourceSrvError));
} else {
@ -109,8 +110,4 @@ export class AnnotationsWorker implements DashboardQueryRunnerWorker {
private static getAnnotationsToProcessFilter(annotation: AnnotationQuery): boolean {
return annotation.enable && !Boolean(annotation.snapshotData);
}
publicDashboardViewMode(dashboard: DashboardModel): boolean {
return dashboard.meta.publicDashboardAccessToken !== undefined && dashboard.meta.publicDashboardAccessToken !== '';
}
}