IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

toolkit linter line number off by one (#19782)

Browse Source 
it is actually an intended feature by tslint:
https://github.com/palantir/tslint/issues/4528

So adding 1 to the line number here in the plugin
This commit is contained in:
Huan Wang 2019-10-12 00:48:22 -06:00 committed by Torkel Ödegaard
parent 0b1913af6f
commit 7562959e44
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/grafana-toolkit/src/cli/tasks/plugin.build.ts
View File

@ -152,9 +152,11 @@ export const lintPlugin = useSpinner<Fixable>('Linting', async ({ fix }) => {
failures.forEach(f => {
// tslint:disable-next-line
console.log(
`${f.getRuleSeverity() === 'warning' ? 'WARNING' : 'ERROR'}: ${f.getFileName().split('src')[1]}[${
f.getStartPosition().getLineAndCharacter().line
}:${f.getStartPosition().getLineAndCharacter().character}]: ${f.getFailure()}`
`${f.getRuleSeverity() === 'warning' ? 'WARNING' : 'ERROR'}: ${
f.getFileName().split('src')[1]
}[${f.getStartPosition().getLineAndCharacter().line + 1}:${
f.getStartPosition().getLineAndCharacter().character
}]: ${f.getFailure()}`
);
});
console.log('\n');