IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Enable useUnknownInCatchVariables for stricter type checking in catch blocks (#50591)

Browse Source 
* wrap a bunch of errors

* wrap more things!

* fix up some unit tests

* wrap more errors

* tiny bit of tidy up
This commit is contained in:
Ashley Harrison
2022-06-15 08:59:29 +01:00
committed by GitHub
parent 2fbe99c1be
commit 803473f479
62 changed files with 364 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
public/app/features/dashboard/components/DashboardSettings/AutoRefreshIntervals.tsx
View File

@@ -82,7 +82,7 @@ export const validateIntervals = (
getValidIntervals(intervals, dependencies);
return null;
} catch (err) {
return err.message;
return err instanceof Error ? err.message : 'Invalid intervals';
}
};

6
public/app/features/dashboard/components/PanelEditor/PanelEditor.tsx
View File

@@ -6,7 +6,7 @@ import { Subscription } from 'rxjs';
import { FieldConfigSource, GrafanaTheme2 } from '@grafana/data';
import { selectors } from '@grafana/e2e-selectors';
import { locationService } from '@grafana/runtime';
import { isFetchError, locationService } from '@grafana/runtime';
import {
HorizontalGroup,
InlineSwitch,
@@ -163,7 +163,9 @@ export class PanelEditorUnconnected extends PureComponent<Props> {
await saveAndRefreshLibraryPanel(this.props.panel, this.props.dashboard.meta.folderId!);
this.props.notifyApp(createPanelLibrarySuccessNotification('Library panel saved'));
} catch (err) {
this.props.notifyApp(createPanelLibraryErrorNotification(`Error saving library panel: "${err.statusText}"`));
if (isFetchError(err)) {
this.props.notifyApp(createPanelLibraryErrorNotification(`Error saving library panel: "${err.statusText}"`));
}
}
return;
}

2
public/app/features/dashboard/components/SaveDashboard/forms/SaveDashboardAsForm.tsx
View File

@@ -64,7 +64,7 @@ export const SaveDashboardAsForm: React.FC<SaveDashboardAsFormProps> = ({
await validationSrv.validateNewDashboardName(getFormValues().$folder.id, dashboardName);
return true;
} catch (e) {
return e.message;
return e instanceof Error ? e.message : 'Dashboard name is invalid';
}
};