IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Enable useUnknownInCatchVariables for stricter type checking in catch blocks (#50591)

Browse Source 
* wrap a bunch of errors

* wrap more things!

* fix up some unit tests

* wrap more errors

* tiny bit of tidy up
This commit is contained in:
Ashley Harrison
2022-06-15 08:59:29 +01:00
committed by GitHub
parent 2fbe99c1be
commit 803473f479
62 changed files with 364 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
public/app/features/dashboard/state/initDashboard.ts
View File

@@ -1,5 +1,5 @@
import { locationUtil, setWeekStart } from '@grafana/data';
import { config, locationService } from '@grafana/runtime';
import { config, isFetchError, locationService } from '@grafana/runtime';
import { notifyApp } from 'app/core/actions';
import { createErrorNotification } from 'app/core/copy/appNotification';
import { backendSrv } from 'app/core/services/backend_srv';
@@ -90,7 +90,7 @@ async function fetchDashboard(
}
} catch (err) {
// Ignore cancelled errors
if (err.cancelled) {
if (isFetchError(err) && err.cancelled) {
return null;
}
@@ -184,7 +184,9 @@ export function initDashboard(args: InitDashboardArgs): ThunkResult<void> {
keybindingSrv.setupDashboardBindings(dashboard);
} catch (err) {
dispatch(notifyApp(createErrorNotification('Dashboard init failed', err)));
if (err instanceof Error) {
dispatch(notifyApp(createErrorNotification('Dashboard init failed', err)));
}
console.error(err);
}