IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-11 16:15:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

LogRowMessage: remove hardcoded true from condition (#72976)

Browse Source
This commit is contained in:
Matias Chomicki 2023-08-07 16:41:03 +02:00 committed by GitHub
parent ba3cbbef7f
commit 869d3fc8b1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
public/app/features/logs/components/LogRowMessage.test.tsx
View File

@ -42,6 +42,11 @@ describe('LogRowMessage', () => {
expect(screen.queryByText('test123')).toBeInTheDocument();
});
it('should hide the menu if the mouse is not over', async () => {
setup({ showContextToggle: () => true, mouseIsOver: false });
expect(screen.queryByLabelText('Show context')).not.toBeInTheDocument();
});
describe('with show context', () => {
it('should show context button', async () => {
setup({ showContextToggle: () => true });

2
public/app/features/logs/components/LogRowMessage.tsx
View File

@ -80,7 +80,7 @@ export const LogRowMessage = React.memo((props: Props) => {
} = props;
const { hasAnsi, raw } = row;
const restructuredEntry = useMemo(() => restructureLog(raw, prettifyLogMessage), [raw, prettifyLogMessage]);
const shouldShowMenu = useMemo(() => mouseIsOver || pinned || true, [mouseIsOver, pinned]);
const shouldShowMenu = useMemo(() => mouseIsOver || pinned, [mouseIsOver, pinned]);
return (
<>
{