IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

tech(alerting): refactored save alerts code

Browse Source
This commit is contained in:
bergquist
2016-04-26 16:31:13 +02:00
parent 55e83a3d62
commit 996eec3ce2
1 changed files with 63 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

122
pkg/services/sqlstore/alerting.go
View File

@@ -1,7 +1,6 @@
package sqlstore
import (
"fmt"
"github.com/go-xorm/xorm"
"github.com/grafana/grafana/pkg/bus"
m "github.com/grafana/grafana/pkg/models"
@@ -62,73 +61,81 @@ func alertIsDifferent(rule1, rule2 m.AlertRule) bool {
}
func SaveAlerts(cmd *m.SaveAlertsCommand) error {
//this function should be refactored
return inTransaction(func(sess *xorm.Session) error {
fmt.Printf("Saving alerts for dashboard %v\n", cmd.DashboardId)
alerts, err := GetAlertsByDashboardId2(cmd.DashboardId, sess)
if err != nil {
return err
}
for _, alert := range *cmd.Alerts {
update := false
var alertToUpdate m.AlertRule
upsertAlerts(alerts, cmd.Alerts, sess)
for _, k := range alerts {
if alert.PanelId == k.PanelId {
update = true
alert.Id = k.Id
alertToUpdate = k
}
}
if update {
if alertIsDifferent(alertToUpdate, alert) {
_, err = sess.Id(alert.Id).Update(&alert)
if err != nil {
return err
}
SaveAlertChange("UPDATED", alert, sess)
}
} else {
_, err = sess.Insert(&alert)
if err != nil {
return err
}
SaveAlertChange("CREATED", alert, sess)
}
}
for _, missingAlert := range alerts {
missing := true
for _, k := range *cmd.Alerts {
if missingAlert.PanelId == k.PanelId {
missing = false
}
}
if missing {
_, err = sess.Exec("DELETE FROM alert_rule WHERE id = ?", missingAlert.Id)
if err != nil {
return err
}
err = SaveAlertChange("DELETED", missingAlert, sess)
if err != nil {
return err
}
}
}
deleteMissingAlerts(alerts, cmd.Alerts, sess)
return nil
})
}
func upsertAlerts(alerts []m.AlertRule, posted *[]m.AlertRule, sess *xorm.Session) error {
for _, alert := range *posted {
update := false
var alertToUpdate m.AlertRule
for _, k := range alerts {
if alert.PanelId == k.PanelId {
update = true
alert.Id = k.Id
alertToUpdate = k
}
}
if update {
if alertIsDifferent(alertToUpdate, alert) {
_, err := sess.Id(alert.Id).Update(&alert)
if err != nil {
return err
}
SaveAlertChange("UPDATED", alert, sess)
}
} else {
_, err := sess.Insert(&alert)
if err != nil {
return err
}
SaveAlertChange("CREATED", alert, sess)
}
}
return nil
}
func deleteMissingAlerts(alerts []m.AlertRule, posted *[]m.AlertRule, sess *xorm.Session) error {
for _, missingAlert := range alerts {
missing := true
for _, k := range *posted {
if missingAlert.PanelId == k.PanelId {
missing = false
}
}
if missing {
_, err := sess.Exec("DELETE FROM alert_rule WHERE id = ?", missingAlert.Id)
if err != nil {
return err
}
err = SaveAlertChange("DELETED", missingAlert, sess)
if err != nil {
return err
}
}
}
return nil
}
func GetAlertsByDashboardId2(dashboardId int64, sess *xorm.Session) ([]m.AlertRule, error) {
alerts := make([]m.AlertRule, 0)
err := sess.Where("dashboard_id = ?", dashboardId).Find(&alerts)
@@ -152,9 +159,6 @@ func GetAlertsByDashboardId(dashboardId int64) ([]m.AlertRule, error) {
}
func GetAlertsByDashboardAndPanelId(dashboardId, panelId int64) (m.AlertRule, error) {
// this code should be refactored!!
// uniqueness should be garanted!
alerts := make([]m.AlertRule, 0)
err := x.Where("dashboard_id = ? and panel_id = ?", dashboardId, panelId).Find(&alerts)