Alerting: Fix state age test failures (#22606)

- use output from relative time instead of static string to prevent
clock issues
This commit is contained in:
Lukas Siatka 2020-03-06 00:28:20 +01:00 committed by GitHub
parent 6af45bf4ac
commit 99daa4454b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -4,9 +4,9 @@ import { AlertRuleDTO, AlertRulesState } from 'app/types';
import { reducerTester } from '../../../../test/core/redux/reducerTester';
describe('Alert rules', () => {
const newStateDate = dateTime()
.subtract(1, 'y')
.format('YYYY-MM-DD');
const newStateDate = dateTime().subtract(1, 'y');
const newStateDateFormatted = newStateDate.format('YYYY-MM-DD');
const newStateDateAge = newStateDate.fromNow(true);
const payload: AlertRuleDTO[] = [
{
id: 2,
@ -16,7 +16,7 @@ describe('Alert rules', () => {
panelId: 4,
name: 'TestData - Always Alerting',
state: 'alerting',
newStateDate: `${newStateDate}T10:00:30+02:00`,
newStateDate: `${newStateDateFormatted}T10:00:30+02:00`,
evalDate: '0001-01-01T00:00:00Z',
evalData: { evalMatches: [{ metric: 'A-series', tags: null, value: 215 }] },
executionError: '',
@ -30,7 +30,7 @@ describe('Alert rules', () => {
panelId: 3,
name: 'TestData - Always OK',
state: 'ok',
newStateDate: `${newStateDate}T10:01:01+02:00`,
newStateDate: `${newStateDateFormatted}T10:01:01+02:00`,
evalDate: '0001-01-01T00:00:00Z',
evalData: {},
executionError: '',
@ -44,7 +44,7 @@ describe('Alert rules', () => {
panelId: 3,
name: 'TestData - ok',
state: 'ok',
newStateDate: `${newStateDate}T10:01:01+02:00`,
newStateDate: `${newStateDateFormatted}T10:01:01+02:00`,
evalDate: '0001-01-01T00:00:00Z',
evalData: {},
executionError: 'error',
@ -58,7 +58,7 @@ describe('Alert rules', () => {
panelId: 3,
name: 'TestData - Paused',
state: 'paused',
newStateDate: `${newStateDate}T10:01:01+02:00`,
newStateDate: `${newStateDateFormatted}T10:01:01+02:00`,
evalDate: '0001-01-01T00:00:00Z',
evalData: {},
executionError: 'error',
@ -72,7 +72,7 @@ describe('Alert rules', () => {
panelId: 3,
name: 'TestData - Ok',
state: 'ok',
newStateDate: `${newStateDate}T10:01:01+02:00`,
newStateDate: `${newStateDateFormatted}T10:01:01+02:00`,
evalDate: '0001-01-01T00:00:00Z',
evalData: {
noData: true,
@ -126,10 +126,10 @@ describe('Alert rules', () => {
executionError: '',
id: 2,
name: 'TestData - Always Alerting',
newStateDate: `${newStateDate}T10:00:30+02:00`,
newStateDate: `${newStateDateFormatted}T10:00:30+02:00`,
panelId: 4,
state: 'alerting',
stateAge: 'a year',
stateAge: newStateDateAge,
stateClass: 'alert-state-critical',
stateIcon: 'icon-gf icon-gf-critical',
stateText: 'ALERTING',
@ -144,10 +144,10 @@ describe('Alert rules', () => {
executionError: '',
id: 1,
name: 'TestData - Always OK',
newStateDate: `${newStateDate}T10:01:01+02:00`,
newStateDate: `${newStateDateFormatted}T10:01:01+02:00`,
panelId: 3,
state: 'ok',
stateAge: 'a year',
stateAge: newStateDateAge,
stateClass: 'alert-state-ok',
stateIcon: 'icon-gf icon-gf-online',
stateText: 'OK',
@ -163,10 +163,10 @@ describe('Alert rules', () => {
id: 3,
info: 'Execution Error: error',
name: 'TestData - ok',
newStateDate: `${newStateDate}T10:01:01+02:00`,
newStateDate: `${newStateDateFormatted}T10:01:01+02:00`,
panelId: 3,
state: 'ok',
stateAge: 'a year',
stateAge: newStateDateAge,
stateClass: 'alert-state-ok',
stateIcon: 'icon-gf icon-gf-online',
stateText: 'OK',
@ -181,10 +181,10 @@ describe('Alert rules', () => {
executionError: 'error',
id: 4,
name: 'TestData - Paused',
newStateDate: `${newStateDate}T10:01:01+02:00`,
newStateDate: `${newStateDateFormatted}T10:01:01+02:00`,
panelId: 3,
state: 'paused',
stateAge: 'a year',
stateAge: newStateDateAge,
stateClass: 'alert-state-paused',
stateIcon: 'fa fa-pause',
stateText: 'PAUSED',
@ -202,10 +202,10 @@ describe('Alert rules', () => {
id: 5,
info: 'Query returned no data',
name: 'TestData - Ok',
newStateDate: `${newStateDate}T10:01:01+02:00`,
newStateDate: `${newStateDateFormatted}T10:01:01+02:00`,
panelId: 3,
state: 'ok',
stateAge: 'a year',
stateAge: newStateDateAge,
stateClass: 'alert-state-ok',
stateIcon: 'icon-gf icon-gf-online',
stateText: 'OK',