IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Code: Ownership for alerting feature toggles (#64426)

Browse Source 
* add alerting squad as an owner of some feature flags

* remove flags from owneless

---------

Co-authored-by: Artur Wierzbicki <artur.wierzbicki@grafana.com>
This commit is contained in:
Yuri Tseretyan 2023-03-08 11:03:06 -05:00 committed by GitHub
parent f0529430ff
commit a5133d61b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/services/featuremgmt/codeowners.go
View File

@ -17,4 +17,5 @@ const (
grafanaAuthnzSquad codeowner = "@grafana/grafana-authnz-team" grafanaAuthnzSquad codeowner = "@grafana/grafana-authnz-team"
grafanaObservabilityLogsSquad codeowner = "@grafana/observability-logs" grafanaObservabilityLogsSquad codeowner = "@grafana/observability-logs"
grafanaObservabilityTracesAndProfilingSquad codeowner = "@grafana/observability-traces-and-profiling" grafanaObservabilityTracesAndProfilingSquad codeowner = "@grafana/observability-traces-and-profiling"
grafanaAlertingSquad codeowner = "@grafana/alerting-squad"
) )

3
pkg/services/featuremgmt/registry.go
View File

@ -13,6 +13,7 @@ var (
Name: "alertingBigTransactions", Name: "alertingBigTransactions",
Description: "Use big transactions for alerting database writes", Description: "Use big transactions for alerting database writes",
State: FeatureStateAlpha, State: FeatureStateAlpha,
Owner: grafanaAlertingSquad,
}, },
{ {
Name: "trimDefaults", Name: "trimDefaults",
@ -356,6 +357,7 @@ var (
Name: "alertingBacktesting", Name: "alertingBacktesting",
Description: "Rule backtesting API for alerting", Description: "Rule backtesting API for alerting",
State: FeatureStateAlpha, State: FeatureStateAlpha,
Owner: grafanaAlertingSquad,
}, },
{ {
Name: "editPanelCSVDragAndDrop", Name: "editPanelCSVDragAndDrop",
@ -369,6 +371,7 @@ var (
Description: "Stop maintaining state of alerts that are not firing", Description: "Stop maintaining state of alerts that are not firing",
State: FeatureStateBeta, State: FeatureStateBeta,
RequiresRestart: false, RequiresRestart: false,
Owner: grafanaAlertingSquad,
}, },
{ {

3
pkg/services/featuremgmt/toggles_gen_test.go
View File

@ -42,7 +42,6 @@ func TestFeatureToggleFiles(t *testing.T) {
}) })
ownerlessFeatures := map[string]bool{ ownerlessFeatures := map[string]bool{
"alertingBigTransactions": true,
"database_metrics": true, "database_metrics": true,
"prometheusAzureOverrideAudience": true, "prometheusAzureOverrideAudience": true,
"tracing": true, "tracing": true,
@ -59,8 +58,6 @@ func TestFeatureToggleFiles(t *testing.T) {
"datasourceOnboarding": true, "datasourceOnboarding": true,
"secureSocksDatasourceProxy": true, "secureSocksDatasourceProxy": true,
"disablePrometheusExemplarSampling": true, "disablePrometheusExemplarSampling": true,
"alertingBacktesting": true,
"alertingNoNormalState": true,
"individualCookiePreferences": true, "individualCookiePreferences": true,
} }