IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

PanelOptions: fix array with siblings (#39620)

Browse Source
This commit is contained in:
Ryan McKinley
2021-09-25 08:22:52 -07:00
committed by GitHub
parent 0db6ba9d70
commit c9ae46a9ad
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
public/app/features/dashboard/components/PanelEditor/utils.test.ts
View File

@@ -98,6 +98,7 @@ describe('setOptionImmutably', () => {
${{}} | ${'a.b[2]'} | ${'x'} | ${{ a: { b: [undefined, undefined, 'x'] } }}
${{}} | ${'a[0]'} | ${1} | ${{ a: [1] }}
${{}} | ${'a[0].b.c'} | ${1} | ${{ a: [{ b: { c: 1 } }] }}
${{ a: [{ b: 1 }] }} | ${'a[0].c'} | ${2} | ${{ a: [{ b: 1, c: 2 }] }}
`('property value:${value', ({ source, path, value, expected }) => {
expect(setOptionImmutably(source, path, value)).toEqual(expected);
});

1
public/app/features/dashboard/components/PanelEditor/utils.ts
View File

@@ -75,6 +75,7 @@ export function setOptionImmutably<T extends object>(options: T, path: string |
let current = (options as Record<string, any>)[propKey];
const arr = Array.isArray(current) ? [...current] : [];
if (splat.length) {
current = arr[index];
if (current == null || typeof current !== 'object') {
current = {};
}