IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

OpenTSDB: consistent options for http requests (#5233)

Browse Source 
* OpenTSDB: consistent options for http requests

 . the get function wasn't using the same request options wrt to credentials/auth as
   the timeseries http request

* OpenTSDB: `_get` `_performTimeSeriesQuery` refactor copied code
This commit is contained in:
Drew Farris
2016-06-17 08:04:40 -04:00
committed by Torkel Ödegaard
parent 9bcd5de8ff
commit cb2b8dea96
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
public/app/plugins/datasource/opentsdb/datasource.js
View File

@@ -128,13 +128,7 @@ function (angular, _, dateMath) {
data: reqBody
};
if (this.basicAuth || this.withCredentials) {
options.withCredentials = true;
}
if (this.basicAuth) {
options.headers = {"Authorization": this.basicAuth};
}
this._addCredentialOptions(options);
// In case the backend is 3rd-party hosted and does not suport OPTIONS, urlencoded requests
// go as POST rather than OPTIONS+POST
@@ -210,11 +204,24 @@ function (angular, _, dateMath) {
};
this._get = function(relativeUrl, params) {
return backendSrv.datasourceRequest({
var options = {
method: 'GET',
url: this.url + relativeUrl,
params: params,
});
};
this._addCredentialOptions(options);
return backendSrv.datasourceRequest(options);
};
this._addCredentialOptions = function(options) {
if (this.basicAuth || this.withCredentials) {
options.withCredentials = true;
}
if (this.basicAuth) {
options.headers = {"Authorization": this.basicAuth};
}
};
this.metricFindQuery = function(query) {
@@ -435,7 +442,6 @@ function (angular, _, dateMath) {
date = dateMath.parse(date, roundUp);
return date.valueOf();
}
}
return {