IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2026-08-26 05:17:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

TraceView: Fix for toString() usage in span filters (#93648)

Browse Source 
Fix for toString() usage
This commit is contained in:
Joey
2024-09-24 14:47:22 +01:00
committed by GitHub
parent ae6ea459b9
commit d30dc3ad50
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/explore/TraceView/components/utils/filter-spans.tsx
+7 -3
View File
@@ -78,7 +78,7 @@ export function getQueryMatches(query: string, spans: TraceSpan[] | TNil) {
const isTextInKeyValues = (kvs: TraceKeyValuePair[]) =>
kvs
? kvs.some((kv) => {
return isTextInQuery(queryParts, kv.key) || isTextInQuery(queryParts, kv.value.toString());
return isTextInQuery(queryParts, kv.key) || isTextInQuery(queryParts, getStringValue(kv.value));
})
: false;
@@ -190,11 +190,15 @@ const checkKeyForMatch = (tagKey: string, key: string) => {
};
const checkKeyAndValueForMatch = (tag: Tag, kv: TraceKeyValuePair) => {
return tag.key === kv.key.toString() && tag.value === kv.value.toString();
return tag.key === kv.key && tag.value === getStringValue(kv.value);
};
const checkKeyAndValueForRegex = (tag: Tag, kv: TraceKeyValuePair) => {
return kv.key.toString().includes(tag.key || '') && kv.value.toString().includes(tag.value || '');
return kv.key.includes(tag.key || '') && getStringValue(kv.value).includes(tag.value || '');
};
const getStringValue = (value: string | number | boolean | undefined) => {
return value ? value.toString() : '';
};
const getServiceNameMatches = (spans: TraceSpan[], searchProps: SearchProps) => {