IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2024-12-26 00:41:20 -06:00
Code Issues Packages Projects Releases Wiki Activity

ReturnToPrevious: Fix e2e test (#84938)

Browse Source 
refactor: remove some waiting for elements that seem to have been removed
This commit is contained in:
Laura Benz 2024-03-22 14:26:09 +01:00 committed by GitHub
parent df2d0574c1
commit e51a8c25d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
e2e/various-suite/return-to-previous.spec.ts
View File

@ -1,6 +1,6 @@
import { e2e } from '../utils';
describe.skip('ReturnToPrevious button', () => {
describe('ReturnToPrevious button', () => {
beforeEach(() => {
e2e.flows.login(Cypress.env('USERNAME'), Cypress.env('PASSWORD'));
cy.window().then((win) => {
@ -16,9 +16,6 @@ describe.skip('ReturnToPrevious button', () => {
});
it('should appear when changing context and go back to alert rule when clicking "Back"', () => {
// make sure the dashboard finished loading
cy.get('button[aria-label*="BarChart - Label Rotation & Skipping"]').should('be.visible');
// check whether all elements of RTP are available
e2e.components.ReturnToPrevious.buttonGroup().should('be.visible');
e2e.components.ReturnToPrevious.dismissButton().should('be.visible');
@ -42,9 +39,6 @@ describe.skip('ReturnToPrevious button', () => {
it('should not persist when going back to the alert rule details view', () => {
e2e.components.ReturnToPrevious.buttonGroup().should('be.visible');
// make sure the dashboard finished loading
cy.get('button[aria-label*="BarChart - Label Rotation & Skipping"]').should('be.visible');
cy.visit('/alerting/list');
e2e.components.AlertRules.groupToggle().first().click();
cy.get('a[title="View"]').click();
@ -52,9 +46,6 @@ describe.skip('ReturnToPrevious button', () => {
});
it('should override the button label and change the href when user changes alert rules', () => {
// make sure the dashboard finished loading
cy.get('button[aria-label*="BarChart - Label Rotation & Skipping"]').should('be.visible');
e2e.components.ReturnToPrevious.backButton()
.find('span')
.contains('Back to e2e-ReturnToPrevious-test')
@ -67,9 +58,6 @@ describe.skip('ReturnToPrevious button', () => {
cy.url().as('alertRule2Url');
cy.get('a').contains('View panel').click();
// make sure the dashboard finished loading
cy.get('button[aria-label*="BarChart - Label Rotation & Skipping"]').should('be.visible');
e2e.components.ReturnToPrevious.backButton()
.find('span')
.contains('Back to e2e-ReturnToPrevious-test-2')