GrafanaUI: Set default value for QueryField onBlur prop (#69487)

This commit is contained in:
Ida Štambuk
2023-06-06 10:44:27 +02:00
committed by GitHub
parent e8cea27051
commit f6d3a5cc94
5 changed files with 7 additions and 14 deletions

View File

@@ -241,6 +241,12 @@ export class UnThemedQueryField extends PureComponent<QueryFieldProps, QueryFiel
export const QueryField = withTheme2(UnThemedQueryField);
// By default QueryField calls onChange if onBlur is not defined, this will trigger a rerender
// And slate will claim the focus, making it impossible to leave the field.
QueryField.defaultProps = {
onBlur: () => {},
};
const getStyles = (theme: GrafanaTheme2) => {
const focusStyles = getFocusStyles(theme);
return {

View File

@@ -102,9 +102,6 @@ export const CloudWatchLogsQueryField = (props: CloudWatchLogsQueryFieldProps) =
cleanText={cleanText}
placeholder="Enter a CloudWatch Logs Insights query (run with Shift+Enter)"
portalOrigin="cloudwatch"
// By default QueryField calls onChange if onBlur is not defined, this will trigger a rerender
// And slate will claim the focus, making it impossible to leave the field.
onBlur={() => {}}
/>
</div>
{ExtraFieldElement}

View File

@@ -59,7 +59,6 @@ export const FiltersSettingsEditor = ({ bucketAgg }: Props) => {
<QueryField
placeholder="Lucene Query"
portalOrigin="elasticsearch"
onBlur={() => {}}
onChange={(query) => dispatch(changeFilter({ index, filter: { ...filter, query } }))}
query={filter.query}
/>

View File

@@ -82,15 +82,7 @@ export const ElasticSearchQueryField = ({ value, onChange }: { value?: string; o
return (
<div className={styles.queryItem}>
<QueryField
query={value}
// By default QueryField calls onChange if onBlur is not defined, this will trigger a rerender
// And slate will claim the focus, making it impossible to leave the field.
onBlur={() => {}}
onChange={onChange}
placeholder="Enter a lucene query"
portalOrigin="elasticsearch"
/>
<QueryField query={value} onChange={onChange} placeholder="Enter a lucene query" portalOrigin="elasticsearch" />
</div>
);
};

View File

@@ -43,7 +43,6 @@ export function QueryEditor({ datasource, query, onChange, onRunQuery }: Props)
query={query.query}
onChange={onChangeQuery}
onRunQuery={onRunQuery}
onBlur={() => {}}
placeholder={'Enter a Trace ID (run with Shift+Enter)'}
portalOrigin="jaeger"
/>