IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Search: Fix not being able to clear sort value (#62557)

Browse Source 
* user essentials mob! 🔱

lastFile:public/app/features/search/state/SearchStateManager.ts

* user essentials mob! 🔱

lastFile:public/app/features/search/page/components/ActionRow.tsx

* user essentials mob! 🔱

* remove searchSort state from localStorage when cleared

---------

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
This commit is contained in:
Josh Hunt
2023-02-03 13:44:57 +00:00
committed by GitHub
parent 12d192d80e
commit f8809eef59
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
public/app/features/search/page/components/ActionRow.tsx
View File

@@ -106,10 +106,10 @@ export const ActionRow: FC<Props> = ({
/>
)}
<SortPicker
onChange={(change) => onSortChange(change.value)}
onChange={(change) => onSortChange(change?.value)}
value={state.sort}
getSortOptions={getSortOptions}
placeholder={sortPlaceholder}
placeholder={sortPlaceholder || 'Sort'}
isClearable
/>
</HorizontalGroup>

6
public/app/features/search/state/SearchStateManager.ts
View File

@@ -115,6 +115,8 @@ export class SearchStateManager extends StateManagerBase<SearchState> {
onSortChange = (sort: string | undefined) => {
if (sort) {
localStorage.setItem(SEARCH_SELECTED_SORT, sort);
} else {
localStorage.removeItem(SEARCH_SELECTED_SORT);
}
if (this.state.layout === SearchLayout.Folders) {
@@ -171,10 +173,6 @@ export class SearchStateManager extends StateManagerBase<SearchState> {
q.kind = ['dashboard', 'folder']; // skip panels
}
if (q.query === '*' && !q.sort?.length) {
q.sort = 'name_sort';
}
return q;
}