Snapshots: Sanitize orignal url (#23254)

This commit is contained in:
Torkel Ödegaard 2020-04-01 16:04:46 +02:00 committed by GitHub
parent ea35ae4d1f
commit fb114a7524
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -17,6 +17,7 @@ import { DashboardModel } from '../../state';
import { CoreEvents, StoreState } from 'app/types'; import { CoreEvents, StoreState } from 'app/types';
import { ShareModal } from 'app/features/dashboard/components/ShareModal'; import { ShareModal } from 'app/features/dashboard/components/ShareModal';
import { SaveDashboardModalProxy } from 'app/features/dashboard/components/SaveDashboard/SaveDashboardModalProxy'; import { SaveDashboardModalProxy } from 'app/features/dashboard/components/SaveDashboard/SaveDashboardModalProxy';
import { sanitizeUrl } from 'app/core/utils/text';
export interface OwnProps { export interface OwnProps {
dashboard: DashboardModel; dashboard: DashboardModel;
@ -134,6 +135,7 @@ export class DashNav extends PureComponent<Props> {
const { canStar, canSave, canShare, showSettings, isStarred } = dashboard.meta; const { canStar, canSave, canShare, showSettings, isStarred } = dashboard.meta;
const { snapshot } = dashboard; const { snapshot } = dashboard;
const snapshotUrl = snapshot && snapshot.originalUrl; const snapshotUrl = snapshot && snapshot.originalUrl;
return ( return (
<div className="navbar"> <div className="navbar">
{isFullscreen && this.renderBackButton()} {isFullscreen && this.renderBackButton()}
@ -222,7 +224,7 @@ export class DashNav extends PureComponent<Props> {
tooltip="Open original dashboard" tooltip="Open original dashboard"
classSuffix="snapshot-origin" classSuffix="snapshot-origin"
icon="gicon gicon-link" icon="gicon gicon-link"
href={snapshotUrl} href={sanitizeUrl(snapshotUrl)}
/> />
)} )}