Commit Graph

46839 Commits

Author SHA1 Message Date
Jack Westbrook
1112e9006b
Bug: Fix broken ui components when angular is disabled (#78208)
fix(frontend): move bootstrap import to app so disabling angular doesnt break ui
2023-11-27 10:43:55 +01:00
Oscar Kilhed
1ab23108c4
Transformations: Handle undefined values when calculating mean and total in add field from calculations (#78645)
* Transformations: Handle undefined values when calculating mean and total in add field from calculations

* fix typo

* change to != and add tests
2023-11-27 10:25:55 +01:00
Dominik Prokop
703deeff0b
DashboardScene: Add time picker keybindings (#78632)
* grafana/data: Add time range zoom out util

* Add keybindings for time range zoom out

* TimeRangePicker: change the way absolute time range is detected

* Depend on dashboard scene tructure rather

* Revert "grafana/data: Add time range zoom out util"

This reverts commit bc1602db57.

* Lint

* Lint

* dashboardSceneGraph tests
2023-11-27 00:32:23 -08:00
Ezequiel Victorero
0f25f18739
Analytics: Refactor dashboard sharing analytics (#78612) 2023-11-24 15:10:48 -03:00
Xavi Lacasa
29853f624e
Lock when cleaning-up external services (#78589) 2023-11-24 17:44:14 +01:00
Matthew Jacobson
4b439b7f52
Alerting: In migration, fallback to '1s' for malformed min interval (#78614)
* Alerting: In migration, fallback to '1s' for malformed min interval

During legacy migration, when we encounter an alert datasource query 
with a min interval (interval field in the query model) that is not 
parseable, instead of failing the migration we fallback to a min interval 
of 1s and continue.

The reason for this is a bug in legacy alerting (existing for a few major 
versions) which allows arbitrary dashboard variables to be used as the 
min interval, even though those variables do not work and will cause 
the legacy alert to fail with `interval calculation failed: time: invalid 
duration`.
2023-11-24 11:27:44 -05:00
Fabrizio
6c7beb1ec3
Tempo: Allow quotes in tag names and attributes (#77864) 2023-11-24 17:24:40 +01:00
Darren Janeczek
53e6182257
Data-trails: prevent creating new metrics node when clicking on historical metric node (#78569)
* fix: prevent creating new metrics node when clicking on historical metric node

* Adding some initial tests

---------

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-11-24 11:21:19 -05:00
Gabriel MABILLE
24a6ee4a91
Plugins: Check installer's permissions include plugins' permissions (#78211)
* Check installer perm

* Failed eval better output

* Switch fetching json data in the repo

* Comment

* Account for feedback

* Mv single_organization config option

* Inline error check

* Starting to replace errors not to have to do the management in two places

* Continue error translation

* Cover ErrChecksumMismatch

* Refactor a bit

* Lint. Tab

* log instead of erroring out

* Nit.

* Revert change on kinds

* revert file again

* Fix tests

* Match core plugin error status code

* Skip permission check for Grafana Admin

* Use errutil templates

* Use errutil templating

* Inline

* Test templating

* revert error changes

* Remove isGrafanaAdmin skip

* Feature toggle check

* Small refactor on hasPluginRequestedPermissions

* Add test

* Imports

* Post install check

* change log messages so that they make sense

* Cover no scope case

* Inline

* Nit.

* Fix test
2023-11-24 16:02:44 +01:00
Oscar Kilhed
ab982e7bd3
Transformations: Add regression analysis transformation (#78457)
* regression analysis first dragt

* Swap to better regression libraries

* fix name

* Interpolate x points instead of using source x points

* clean up ui and add feature toggle

* fix merge error

* change to loop for finding min max, rename resolution

* Add docs

* add docs and tests

* change name to regression analysis

* update docs

* Fix editor labels

* add regression images

* fix docs
2023-11-24 15:49:16 +01:00
Isabel
7fa73d2b21
add Jev as codeowner for transform-data.md (#78611) 2023-11-24 09:46:24 -05:00
Torkel Ödegaard
54bca5e590
DashboardSchema: Remove some old panel types (#78590) 2023-11-24 14:53:28 +01:00
Esteban Beltran
02a079e64a
Plugins: Fix outline for elements inside a plugin page (#78004) 2023-11-24 14:21:17 +01:00
John Martins
4f5db5f177
Azure Monitor: Add Azure Infrastructure Monitoring Dashboard (#78498)
Add Azure Infrastructure Monitoring dashboard
2023-11-24 14:58:48 +02:00
Oscar Kilhed
7a46d6a1b3
Transformations: Move transformation variables to public preview (#78148)
move transformation variables to public preview
2023-11-24 13:22:54 +01:00
Gábor Farkas
5be99912ff
mssql: adjust unit test to minimize xorm-usage (#78597)
* mssql: adjust unit test to minimize xorm-usage

* lint fix
2023-11-24 13:12:19 +01:00
Ashley Harrison
441d24f955
Chore: Remove some gf-form classes (#78601)
* remove some gf-form

* couple more transformations

* clean up Playlists

* review comments

* fix unit tests
2023-11-24 12:09:09 +00:00
Ivana Huckova
8a7eb4b484
Loki: Refactor template variable logic and remove reliance on timeSrv (#78586)
* Loki: Refactor variables support to reuse loic

* Remove redundant methods

* Make parseStringToVariableQuery private
2023-11-24 12:52:29 +01:00
gotjosh
8120306fea
Remote Alertmanager(refactor): Only parse the URL once (#78631)
* Remote Alertmanager(refactor): Only parse the URL once

Exactly what it says in the tin.

Signed-off-by: gotjosh <josue.abreu@gmail.com>

* use the existing tests

Signed-off-by: gotjosh <josue.abreu@gmail.com>

---------

Signed-off-by: gotjosh <josue.abreu@gmail.com>
2023-11-24 11:05:13 +00:00
Ivana Huckova
9306020426
Loki: Update getStats logic and remove reliance on timeSrv (#78603)
* Loki: For stats queries, use timeRange provided by query editor

* Add comment

* Update public/app/plugins/datasource/loki/components/LokiQueryEditor.tsx

Co-authored-by: Matias Chomicki <matyax@gmail.com>

* Rebane variable

---------

Co-authored-by: Matias Chomicki <matyax@gmail.com>
2023-11-24 11:38:36 +01:00
Gábor Farkas
710248674d
postgres: update unit test to be ready for the xorm-removal (#78537)
postgres: removed xorm from unit tests
2023-11-24 11:11:18 +01:00
Mihai Doarna
27d8b68c9c
Auth: Add more tests for the SSO settings upsert function (#78544)
* add more tests for the SSO settings upsert function

* fix client id to match provider

* use time now in tests
2023-11-24 12:02:05 +02:00
Jo
7d559bc69a
AuthProxy: Do not allow sessions to be assigned with other methods (#78602)
do not allow login token with other methods
2023-11-24 11:00:53 +01:00
Jean-Philippe Quéméner
11d4f604f5
fix(alerting): proper handling for queries with multiple conditions in migration (#78591)
fix(alerting): proper handling for queries with multiple conditions
2023-11-23 18:05:44 +01:00
gotjosh
23fe8f4e9c
Alerting: Introduce a Mimir client as part of the Remote Alertmanager (#78357)
* Alerting: Introduce a Mimir client as part of the Remote Alertmanager

This is our first attempt at making Grafana communicate use Mimir as a backend - it uses a new set of APIs that we've developed on the Mimir side to upload the grafana configuration and alertmanager state so that it can then be ported over.

Codewise, we've introduced a couple of things:

A client to isolate in its own package all the communication that happens with Mimir
A few changes to the remote/alertmanager to include uploading the configuration and state when it starts
A few refactors that align a bit better with the design approach that we're thinking
An integration tests again these newly developed APIs using a custom image

---------

Signed-off-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>
2023-11-23 16:59:36 +00:00
Jack Westbrook
eedc19f9f0
Chore: Refresh lock file with correct scenes version info (#78605)
chore(yarn): refresh lock file with correct scenes version info
2023-11-23 18:08:15 +02:00
Misi
7128415529
Auth: Add more context to logs around token rotation, revocation (#78600)
Add more context to logs around token rotation, revocation

Co-authored-by: Karl Persson <kalle.persson@grafana.com>
2023-11-23 16:48:54 +01:00
Ivana Huckova
0893fa1e84
Loki: Fix trailing comma in renderers for json, logfmt, keep and drop operations (#78594)
* Loki: Fix renderers for json, logfmt, keep and drop pipe operations

* Make spacing and trimming more consistent

* Fix
2023-11-23 15:39:10 +01:00
Torkel Ödegaard
a98a39c418
DashboardScene: Fixes angular panels inside collapsed rows (#78532)
* DashboardScene: Fixes angular panels inside collapsed rows

* Update
2023-11-23 15:15:36 +01:00
Agnès Toulet
41713353eb
Doc: Update image rendering configuration (#77042)
* Doc: Update image rendering configuration

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* Update docs/sources/setup-grafana/configure-grafana/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

* Update docs/sources/setup-grafana/image-rendering/_index.md

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>

---------

Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
2023-11-23 15:03:13 +01:00
Sven Grossmann
762c7b6fe1
Loki: improve structured metadata in devenv (#78587) 2023-11-23 14:40:17 +01:00
Joey
4f46fb412c
Tempo: Embed flame graph in span details (#77537)
* Embed flame graph

* Update test

* Update test

* Use toggle

* Update test

* Add tests

* Use const

* Cleanup

* Update profile tag

* Move flame graph out of tags, remove request and other cleanup + tests

* Update test

* Set flame graph by profile id and simplify logic

* Cleanup and redrawListView

* Create/use feature toggle
2023-11-23 13:36:53 +00:00
Sven Grossmann
be157399d0
Loki: Add structured metadata keys to autocomplete (#78584)
* wip

* remove import

* scope to monaco completions for now

* use `LabelType` enum

* change strucutred metadata documentation

* fix import

* add `responseUtils` tests

* update tests

* fix completions.ts tests

* fix LabelType enum

* fix CompletionDataProvider test
2023-11-23 13:26:57 +01:00
Domas
2402ad67af
Chore: Update "Observability" nav group subtitle (#78579)
Update observability nav group subtitle
2023-11-23 13:53:40 +02:00
Brendan O'Handley
7cf173b651
Opentsdb: Add variables to select when interacting with the metric select (#78558)
add variables to select when interacting with the metric select
2023-11-23 12:32:35 +01:00
Dominik Prokop
58a0ff7459
DashboardScene: Share library panel (#78421)
* DashboardScene: Share library panel

* Add menu item to create library panel

* Test update
2023-11-23 03:30:25 -08:00
Gabriel MABILLE
91a5c3803c
RBAC: GrafanaAdmin users are admins of the Global Organization (#78559) 2023-11-23 12:17:28 +01:00
Ashley Harrison
5355131aed
Tab: Only make Tab an anchor if a href is passed (#78540)
* initial work

* only make the tab an anchor if it has a href

* move things around for smaller diff

* use content()

* eslint-disable the type assertions

* extract props into common object and add missing return statement
2023-11-23 10:51:07 +00:00
Ieva
778841cabe
Annotations: Remove dashboard permission checks for annotations (#78352)
remove checks for access to dashboard if FlagAnnotationPermissionUpdate is enabled
2023-11-23 10:47:37 +00:00
Josh Hunt
05070385cd
Chore: Refactor TimeRangePicker for aria-label selectors (#78399)
* Change from aria-label to data-testid for e2e selectors

* translate

* update tests

* swap buttons:
2023-11-23 10:39:26 +00:00
Matias Chomicki
02068662c1
Logs: create DataSourceWithQueryModificationSupport + determine popover menu support (#78322)
* DataSourceWithQueryModificationSupportSupport: create interface

* Loki: implement DataSourceWithQueryModificationSupportSupport

* Elasticsearch: implement DataSourceWithQueryModificationSupportSupport

* DataSourceWithQueryModificationSupportSupport: add type guard

* DataSourceWithQueryModificationSupport: rename

* Check for nullish values in guards

* Logs container: replace support map with ds instances map

* Log rows: refactor deselection listener

* Formatting

* Formatting

* DataSourceWithQueryModificationSupport: add missing comment

* Logs container: update method name

* Logs container: check for query modification support

* Create QueryFixType

* QueryFixAction: move back to ds types

* getSupportedQueryModifications: update signature

* getSupportedQueryModifications: update signature
2023-11-23 11:04:23 +01:00
Ivana Huckova
fd5f66083c
Loki: Move convertToWebSocketUrl from Explore to Loki (#78542)
* Move convertToWebSocketUrl to Loki

* Add tests

* Fix test
2023-11-23 11:43:48 +02:00
Jo
5dd5ed9b30
SignedInUser: Only register echo backend if user is signed in (#78545)
fix SignedIn checks
2023-11-23 10:11:53 +01:00
Erik Sundell
f3d742caeb
Variables: Remove alpha flag from variable support API (#78573)
remove alpha flag
2023-11-23 09:58:26 +01:00
Kevin Wang
8bdfb7e1cf
chore(authn.service): fix typo in log statement (#76205) 2023-11-23 09:06:19 +01:00
ismail simsek
2e756395f7
InfluxDB SQL: Fix sql query template variable interpolation (#78557)
interpolate sql too
2023-11-23 08:06:20 +01:00
Adela Almasan
5b851d7410
Timeseries: Remove cursor sync when x is not time (#78496) 2023-11-22 16:23:16 -06:00
Todd Treece
4203a83538
K8s: Prevent user impersonation (#78555) 2023-11-22 15:55:37 -05:00
Nathan Marrs
d269a123e7
XYChart: Minor improvements (#78506)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
2023-11-22 11:50:02 -08:00
Isabel
72e8672203
docs: 404 fixes - what's new Alerting content (#78549)
* Updated links in what's new 10.2 and what's new next

* Attempted to add alias

* Fix alias

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2023-11-22 14:40:05 -05:00