Commit Graph

3641 Commits

Author SHA1 Message Date
Joao Silva
1aac15f383
Select: Performance improvements when opening menu and when hovering over options (#69230) 2023-06-21 18:28:46 +09:00
Torkel Ödegaard
7b9e047ffd
TopNav: Cleanup theme flags (#67990)
* TopNav: Cleanup theme flags

* Update

* update
2023-06-20 13:58:57 +02:00
Sonia Aguilar
9a252c763a
Alerting: Add notification policies preview in alert creation (#68839)
* Add notification policies preview in alert rule form
Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>

* Refactor using new useGetPotentialInstances hook and apply some style changes

* Add notification policy detail modal

* Use backtesting api for simulating  potential alert instances

* Fix logic to travserse all the children from the root route

* Split notification preview by alert manager

* Add instance count to matching policy header and fix some styles

* Move some logic to a new hook useGetAlertManagersSourceNames to make the code more clean

* Fix some tests

* Add initial test for NotificationPreview

* Use button to preview potential instances

* Add link to contact point details

* Add route matching result details

* Show AlertManager image in the routing preview list

* Add tests setup, add single AM preview test

* Handle no matchers and no labels use case

* Update some style in collapse component and fix policy path in modal

* Update modal styles

* Update styles

* Update collapse header styling

* Normalize tree nodes should happen before findMatchingRoutes call

* Fix findMatchingRoutes and findMatchingAlertGroups methods after reabasing

* Move instances matching to the web worker code

* Fix config fetching for vanilla prometheus AMs

* Add tests

* Add tests mocks

* Fix tests after adding web worker

* Display matching labels for each matching alert instance

* Add minor css improvements

* Revert changes added in Collapse component as we don't use it anymore

* Move the route details modal to a separate file

* Move NotificationRoute and preview hook into separate files

* Fix Alertmanager preview tests

* Fix tests

* Move matcher code to a separate file, improve matcher mock

* Add permissions control for contact point edit view link

* Fix from and to for the temporal use of backtesting api

* Fix tests, add lazy loading of the preview component

Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>

* Fix preview test

* Add onclick on the header div so it collapse and expands when clicking on it, and update styles to be consistent with the rest of tables

* Adapt the code to the new rule testing endpoint definition

* Fix tests

* small changes after reviewing the final code

* compute entire inherited tree before computing the routes map

* Throw error in case of not having receiver in routesByIdMap and add test for the use case of inheriting receiver from parent to check UI throws no errors

* Add list of labels in the policy route path that produces the policy matchers to match potential instances

* Use color determined by the key, in label tags when hovering matchers in the policy tree

* Remove labels in modal and handle empty string as receiver to inherit from parent as we do with undefined

* Revert "Add list of labels in the policy route path that produces the policy matchers to match potential instances"

This reverts commit ee73ae9cf9.

* fix inheritance for computeInheritedTree

* Fix message shown when preview has not been executed yet

* First round for adressing PR review comments

* Adress the rest of PR review commments

* Update texts and rename id prop in NotificaitonStep to alertUid

---------

Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-06-19 13:32:17 +02:00
Leon Sorokin
66b0e6b77f
XYChart/Trend: Fix min/max and units/decimals x-field overrides (#70214) 2023-06-16 11:10:53 -05:00
Ashley Harrison
61dbad6905
CodeEditor: Ensure suggestions only apply to the instance of the editor that registered them (#69995)
* user essentials mob! 🔱

lastFile:packages/grafana-ui/src/components/Monaco/CodeEditor.internal.story.tsx

* user essentials mob! 🔱

lastFile:packages/grafana-ui/src/components/Monaco/suggestions.ts

* user essentials mob! 🔱

lastFile:packages/grafana-ui/src/components/Monaco/CodeEditor.internal.story.tsx

* user essentials mob! 🔱

lastFile:packages/grafana-ui/src/components/Monaco/suggestions.ts

* remove duplicate editor from story

* remove suggestions from story

---------

Co-authored-by: Laura Benz <laura.benz@grafana.com>
Co-authored-by: Tobias Skarhed <tobias.skarhed@gmail.com>
2023-06-14 13:51:03 +01:00
Victor Marin
9f7776f073
Replace non-finite values and null-fill across timerange (#69919)
* Replace non-finite values and null-fill across timerange

* PR mods, fix tests, add test dashboard

* regen jsonnet

* poke gdev dash

* pr mods

---------

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2023-06-14 09:18:51 +03:00
Gilles De Mey
a00d7770bc
Alerting: Show disabled provisioned evaluation group (#69932) 2023-06-13 11:26:01 +02:00
Ashley Harrison
266751b96d
NestedFolders: stay in the modal whilst actions complete (#69730)
* stay in the modal whilst actions complete

* don't return anything here to fix types

* ensure we're always resetting button state
2023-06-12 16:53:17 +01:00
Ben Simpson
d363741d39
Grafana UI: Add scroll handlers to the Select component (#65069)
* [feat] Add scroll handlers to the Select component

* [refactor] Update Select component

- Update how `captureMenuScroll` boolean is set
- Update props

* [fix] revert unexpected changes
2023-06-12 12:52:23 +00:00
renovate[bot]
176a98dda8
Update dependency date-fns to v2.30.0 (#69905)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-12 11:08:23 +00:00
kay delaney
2fd7d95d7e
PanelChrome: Fix tabbing to panel menu button (#69861)
Closes #66256
2023-06-12 11:53:22 +01:00
renovate[bot]
3f56939212
Update dependency core-js to v3.31.0 (#69902)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-12 10:43:55 +00:00
renovate[bot]
380843de36
Update dependency @grafana/faro-core to v1.1.0 (#69834)
* Update dependency @grafana/faro-core to v1.1.0

* dedupe

* update faro-web-sdk as well

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-06-12 09:20:50 +01:00
Andrej Ocenas
417f6ceeb6
Grafana/ui: Fix margin in RadioButtonGroup option when only icon is present (#68899) 2023-06-09 10:54:06 +02:00
renovate[bot]
6e3ff5c265
Update dependency css-loader to v6.8.1 (#69805)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-09 08:35:11 +01:00
renovate[bot]
a2b3a70b62
Update dependency core-js to v3.30.2 (#69799)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-08 15:38:26 +00:00
renovate[bot]
02a3bc9b25
Update dependency @types/node to v18.16.16 (#69787)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-08 08:28:18 -04:00
renovate[bot]
49ad802ca6
Update dependency @testing-library/dom to v9.3.0 (#69768)
* Update dependency @testing-library/dom to v9.3.0

* dedupe versions in the lockfile

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-06-08 12:54:42 +01:00
Laura Benz
24502c4c4a
Add tooltip to instances of IconButton (#68880)
* refactor: tooltip is required

* refactor: add tooltips

* refactor: add tooltips

* refactor: add tooltips

* refactor: add tooltips

* refactor: add tooltips

* refactor: add tooltips

* refactor: adjust tests

* refactor: apply changes from code review

* refactor: adjust component for e2e test

* refactor: adjust fallback

* refactor: apply changes from code review

* refactor: apply changes from code review

* refactor: set IconButton default as type=button and remove from use cases

* refactor:  remove aria-labels when duplicated and type=button from use cases

* refactor: clean up

* refactor: fix tests

* refactor: fix type errors

* refactor: remove changes in order in order to add them to a separate PR

* refactor: set IconButton default as type=button

* refactor: remove tooltip

* refactor: apply changes requested in review
2023-06-08 10:23:28 +02:00
renovate[bot]
c826739ee8
Update dependency @rollup/plugin-node-resolve to v15.1.0 (#69738)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-08 09:10:16 +01:00
Ashley Harrison
0e28d6143b
Nested folders: Improve loading states (#69556)
* loading states!

* fix uncontrolled checkbox

* cleaner css

* improve flickering title

* make sure @grafana/ui has the same version of react-loading-skeleton

* fix unit test + add tooltip text

* better way of restoring focus

* only restore focus when loading

* missing !

* use aria-label instead of tooltip
2023-06-07 11:21:44 +01:00
Adela Almasan
76b05b80a4
Legend: Sort by name (#69490) 2023-06-06 15:16:16 -05:00
renovate[bot]
6900336f09
Update dependency @monaco-editor/react to v4.5.1 (#69633)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-06-06 14:58:58 +01:00
kay delaney
c1d3a2d81e
PanelChrome: Show pointer when hovering cancel query button (#69391) 2023-06-06 11:19:14 +01:00
Ida Štambuk
f6d3a5cc94
GrafanaUI: Set default value for QueryField onBlur prop (#69487) 2023-06-06 10:44:27 +02:00
renovate[bot]
31ecbf7062
Update babel monorepo (#69358)
* Update babel monorepo

* clean up lockfile

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
2023-06-02 12:00:12 +03:00
renovate[bot]
1fbff3c807
Update dependency esbuild to v0.17.19 (#61522)
* Update dependency esbuild to v0.17.18

* chore(npm): update all esbuild dependencies to use esbuild@0.17.18

* build(esbuild): update configs so esbuild-loader matches loader from file extension

* build(webpack): fix failed monaco editor loading due to require not existing

* chore(esbuild): bump to 0.17.19

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2023-06-01 10:23:09 +02:00
Ashley Harrison
fd7f2d4a5e
ConfirmModal: Ignore case for confirmation text (#69000)
* ignore case for confirmation text, add a couple of unit tests

* just have 1 test

* fix related unit tests
2023-05-31 16:20:36 +01:00
Jack Westbrook
82f353c696
Grafana UI: Fix plugin unit test errors (#69210)
* fix(grafana-ui): import from package to prevent import errors occurring in plugin tests

* style(grafana-ui): add e2e-selectors path to restricted imports rule
2023-05-30 15:34:13 +02:00
Levente Balogh
fa6afc7ea4
ZoomPlugin: Remove the timeRange prop (#69148)
* fix: remove a breaking change

---------

Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2023-05-26 11:52:09 -05:00
Domas
283c1c7dbe
SparklineCell: Allow specifying time range (#69130)
add timeRange optional prop to Table and TablePanel
2023-05-26 13:50:42 +03:00
Reem Tariq
cebc8853f2
grafana/ui: add icon as a prefix in time range input component (#66084) 2023-05-26 10:59:02 +02:00
Laura Fernández
4cf77424fd
Grafana UI: Add invalid state to Checkbox component (#68242) 2023-05-26 10:11:48 +02:00
Simon Podlipsky
f515d2efac
[Timeseries] Place legend to bottom when on <lg display (#69045)
Place timeseries legend to bottom when on <lg display
2023-05-26 01:07:09 -07:00
Simon Podlipsky
a69ff6c311
TimeSeries: Add zoom-out functionality on double click (#68936) 2023-05-25 21:04:02 -05:00
Leon Sorokin
014126a43e
TimeSeries: Fix centeredZero y axis ranging when all values are 0 (#69034) 2023-05-25 13:25:26 -06:00
Torkel Ödegaard
1eed40fcf6
Drawer: Fixes closeOnMaskClick false issue (#69083) 2023-05-25 19:43:48 +02:00
Alex Khomenko
6393e2e713
UserIcon: Fix mdx docs (#69079)
UserIcon: Fix mdx
2023-05-25 17:06:34 +03:00
Alex Khomenko
41b609de14
Grafana/ui: Add UserIcon and UsersIndicator components (#66906)
* UserIcon: Move to grafana/ui

* UserIcon: Add story and docs

* UserIcon: Add multiple use case

* UserIcon: Use theme2

* UserIcon: Update props

* UserIcon: Export components

* UserIcon: Update story

* UserIcon: Allow children

* UserIcon: Simplify the rendering logic

* UserIcon: Use button

* UserIcon: Add UsersIndicator component

* UserIcon: Add tests

* UserIcon: Rename folder

* UserIcon: More examples

* UserIcon: Display UserView type

* UserIcon: Update tests

* UserIcon: Expand example

* UserIcon: Export UserView type

* Fixes after review
2023-05-25 15:57:30 +03:00
Tobias Skarhed
25b89babac
CodeEditor: Save with Ctrl+S via onKeyDown instead of addCommand (#68955)
Change addCommand to onKeyDown
2023-05-25 10:49:23 +02:00
Khushi Jain
649c68aafb
Storybook: Added Viztooltip under Visualizations (#68992)
Co-authored-by: Nathan Marrs <nathanielmarrs@gmail.com>
2023-05-24 18:32:15 +02:00
Torkel Ödegaard
2966989525
ResourcePicker: Fix missing border bug on cancel button (#68966)
* ResourcePicker: Fix missing border bug

* remove unused imports
2023-05-24 15:10:46 +02:00
Ashley Harrison
09a0c1e1bb
Checkbox: Fix extraneous right hand margin when no label is present (#68885)
* remove explicit grid columns, let it automatically work it out

* restore position: relative;
2023-05-24 10:52:21 +01:00
Ashley Harrison
2ceed6a169
Preferences: Can reset timezone preference back to default correctly (#68881)
* user essentials mob! 🔱

lastFile:public/app/core/components/SharedPreferences/SharedPreferences.tsx

* invert menuShouldPortal logic on TimeZonePicker and fix unit test

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>

---------

Co-authored-by: eledobleefe <laura.fernandez@grafana.com>
Co-authored-by: Joao Silva <joao.silva@grafana.com>
Co-authored-by: L-M-K-B <48948963+L-M-K-B@users.noreply.github.com>
Co-authored-by: joshhunt <josh@trtr.co>
2023-05-24 09:28:14 +01:00
Tobias Skarhed
e3e8a7965a
A11y: Make list type picker display tooltip on hover (#68798)
* Change ariaLabel to description

* Description fallback for aria-label

* Add ariaLabel ass fallback for description
2023-05-23 17:19:10 +02:00
Torkel Ödegaard
d4df5e0519
Themes: Unify secondary button and ToolbarButton (#68250)
* Themes: Unify secondary button and ToolbarButton

* Update

* Update light theme

* fix test

* fix toolbar button border

* fix disabled outline button style

* Use transparent color instead of dynamic computed color for hover bg for text/outline versions. this is what figma components do
2023-05-22 14:55:16 +02:00
Ashley Harrison
e8ca3c0409
Chore: More typescript improvements 💪 (#68699)
* fix some anys

* some canvas/geomap improvements

* some more panel type fixes

* just omit the type in TagOption
2023-05-22 11:53:58 +01:00
Josh Hunt
e17f676a98
NestedFolders: Style tweaks (#68532)
* Center align cell items

* Change empty folder message + style

* Use new Text components in TypeCell

* Use new components in Move and Delete modals

* fix test

* Change spinner in DescendantsCount to the same font size as the text to prevent layout shift
2023-05-22 08:59:46 +00:00
renovate[bot]
1e6eae3913
Update babel monorepo (#68212)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-05-17 09:37:43 +01:00
Victor Marin
94801c9c75
Sparkline: Sort dataframe (#68007)
* Sort sparkline dataframe

* Sort frame only if needed

* add utils test
2023-05-17 08:09:06 +03:00