Commit Graph
100 Commits
Author SHA1 Message Date
Joey 2258e6bd16 Traces: Add traces panel suggestion (#83089)
* Add traces panel suggestion

* Render suggestion

* Update styling

* Update styling
2024-02-21 13:49:41 +00:00
Joey 1744487487 Tempo: Upgrade @grafana/lezer-traceql patch version to use trace metrics syntax (#82532)
* Upgrade patch version

* Update autocomplete/highlighting to be more specific

* Update test
2024-02-16 11:17:41 +00:00
Joey b81c3ab9c1 Tempo: Improve UX of the query editors status select (#82167)
Improve status UX
2024-02-15 09:34:14 +00:00
Joey a922ce86c8 Pyroscope: Add Pyroscope to build and release step (#82363)
Add Pyro to release step
2024-02-15 09:33:29 +00:00
Joey 2ef17efaf9 Tempo: Reset tag value when key changed in Search tab (#82365)
Reset tag value when key changed
2024-02-15 09:33:15 +00:00
Joey d33a087756 Tempo: Remove unused code (#82151)
Remove unused code
2024-02-13 10:56:46 +00:00
Joey 4054590526 Tempo: Use grafana/ui divider (#82141)
* Use Grafana divider

* Remove custom divider
2024-02-13 10:56:37 +00:00
Joey ea96c83a2c Tempo: Improve tags UX (#81166)
* Only show add/remove tag when necessary in span filters

* Only show add/remove tag when necessary in traceql

* Only show add/remove tag when necessary in aggregateBy

* Update styles

* Add tests

* Show remove tag for all if more than one tag

* Also check for value only in search editor and update tests
2024-02-08 09:24:23 +00:00
Joey ff21f941df Parca: Fix flaky test (#81968)
Fix flaky test
2024-02-07 10:21:53 +00:00
Joey 390461f9e1 Tempo: Move query ref to TraceQLEditor (#81686)
Move ref to TraceQLEditor
2024-02-06 13:30:59 +00:00
JoeyandKim Nylander 96301ce533 Tempo: Trace to metrics docs (#81548)
* Trace to metrics docs and share variables that can be used in query section

* Update text

* Add span start/end

* Update docs/sources/shared/datasources/tempo-traces-to-profiles.md

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>

* Update docs/sources/datasources/tempo/configure-tempo-data-source.md

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>

* Update docs/sources/datasources/tempo/configure-tempo-data-source.md

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>

* Update text

* Update docs/sources/datasources/tempo/configure-tempo-data-source.md

---------

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
2024-02-06 08:58:08 +00:00
Joey fd54d25496 Tempo: Fix issue with button click area being too large (#81500)
Fix issue with button click area being too large
2024-02-01 09:48:18 +00:00
Joey 1606095a5c Tempo: Remove unused code (#81568)
* Remove unused code

* Remove unused code from tests
2024-02-01 09:48:04 +00:00
Joey 3517f0075b Tempo: Add webpack to package.json (#81577)
Add webpack to package.json
2024-01-31 09:08:32 +00:00
JoeyandFabrizio b9f5042044 Tempo: Add query ref in the query editor (#81343)
* Add query ref

* Fix lint

* Add comment

* Update public/app/plugins/datasource/tempo/traceql/QueryEditor.tsx

Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>

---------

Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>
2024-01-31 09:08:06 +00:00
Joey 0d9886a654 Tempo: Add span, trace vars to trace to metrics interpolation (#81046)
* Add scoped vars to query

* Update import

* Remove ternary
2024-01-31 09:07:35 +00:00
Joey d8d9121b6d Tempo: Clean up older styles (#81247)
* Clean up uber styles

* Use theme spacing
2024-01-29 09:12:49 +00:00
JoeyandKim Nylander 467f293948 Tempo: Upgrade trace to profiles docs (#81002)
* Update docs to use embedded flame graph image

* Update headings

* Update link type

* Add embedded flame graph content

* Minor text changes

* Add provisioning example

* Move configure table into  section

* Add configure section

* Update provisioning example

* Update docs/sources/shared/datasources/tempo-traces-to-profiles.md

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>

* Update docs/sources/shared/datasources/tempo-traces-to-profiles.md

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>

* Update wording

---------

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
2024-01-26 10:56:46 +00:00
Joey 5b4a984b78 Tempo: Add warning message when scope missing in TraceQL (#80472)
* Add warning message when scope missing in TraceQL

* Check for warnings in nodes

* Update formattiing

* Tidy up logic

* Tests

* Rename files and move tests for highlighting queries with errors
2024-01-24 11:41:13 +00:00
Joey 6d15e16d2e Pyroscope: Fix stale value for query in query editor (#80753)
* Fix stale value for query in query editor

* Separate out onLabelSelectorChange into its own hook

* Move queryRef inside hook
2024-01-22 15:02:55 +00:00
Joey f3c64a7337 Tempo: Remove profiling toggles (#80792)
* Remove traceToProfiles toggle

* Remove tracesEmbeddedFlameGraph toggle

* Remove superfluous import

* Update ConfigDescriptionLink

* Update getting of profiles from standalone build PR
2024-01-22 14:21:14 +00:00
Joey 9d8f4228bb UX: Remove spacing in duration row in the Tempo query editor (search tab) (#80373)
Remove spacing in duration group
2024-01-17 17:33:59 +00:00
Joey 6796e66fb8 Pyroscope: Add standalone build (#80222)
* Pyroscope standalone build

* Fix for tests

* Add missing packages

* Remove import

* Update trace to profiles

* Update test
2024-01-16 12:46:15 +00:00
Joey dd9b3d65d4 Tempo: Update trace to profiles link (#80364)
Update trace to profiles link
2024-01-12 10:20:01 +00:00
Joey e054ef7c98 Tempo: Add template vars to embedded flamegraph (#80363)
* Add template vars to embedded flamegraph

* Update location of templateSrv.replace in spanFlameGraph
2024-01-11 16:28:59 +00:00
Joey 314cdaf618 Pyroscope: Decouple frontend (#80066)
* Decouple query options

* Decouple Variable support

* Fix after merge
2024-01-09 11:40:39 +00:00
Joey 81f8c022a0 Pyroscope: Decouple backend from infra imports (#80018)
Decouple backend from infra imports
2024-01-08 13:11:46 +00:00
JoeyandFabrizio f0cb88e3b5 Pyroscope: Add Span ID to options collapsed info (#79981)
* Pyroscope: Add Span ID to options collapsed info

* Update for multiple

* Update public/app/plugins/datasource/grafana-pyroscope-datasource/QueryEditor/QueryOptions.tsx

Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>

---------

Co-authored-by: Fabrizio <135109076+fabrizio-grafana@users.noreply.github.com>
2024-01-08 12:07:19 +00:00
Joey ef6b35ad3b Tempo: Copy trace query to TraceQL tab (#79935)
* Copy trace query to TraceQL tab

* Remove datasourceType

* Update button position

* Update test

* Remove extra check

* Update text
2024-01-04 16:10:09 +00:00
Joey 70a25eaf2c Pyroscope: Update data source name in variable editor tooltip (#79974)
Update data source name in tooltip
2024-01-04 11:24:01 +00:00
Joey 00bc13e37c Pyroscope: Remove unnecessary import and logic (#79568)
* Remove unecessary import and logic

* Update test
2024-01-03 11:25:38 +00:00
Joey e372b54722 Tempo: Easily filter by trace duration (#79931)
* Easily filter by trace duration

* Add test

* Update onChange
2024-01-03 10:00:22 +00:00
Joey 7451f41967 Tempo: Carry over query from Search tab to TraceQL tab (#79442)
* Carry over query from Search tab to TraceQL tab

* Update tracking

* Update flow

* Updates to logic
2023-12-15 12:46:32 +00:00
Joey 8a6ea4bfad Tempo: Fix graph dragging (#79508)
* Fix graph dragging

* Add comment
2023-12-15 10:43:35 +00:00
Joey f053cc7aae Tempo: Allow usage of template vars with service map query (#79382)
* Apply template vars to serviceMapQuery

* Add test
2023-12-15 09:03:00 +00:00
Joey eff9374a63 Tempo: Update cheatsheet (#78797)
* Tempo: Update cheatsheet

* Update text
2023-12-12 11:46:43 +00:00
Joey e00e4d9ec6 Pyroscope: Switch to sdk httpclient from infra httpclient (#79373)
Decouple httpclient
2023-12-12 11:14:26 +00:00
Joey 4751013a91 Pyroscope: Decouple from templateSrv (#79068)
* Decouple templateSrv

* Update test
2023-12-11 13:14:22 +00:00
Joey 58c5e5c9dc Tempo: Update the embedded flame graph labelSelector (#79061)
* Update the embedded flame graph labelSelector

* Update labelSelector
2023-12-08 09:44:51 +00:00
Joey f51ad749ab Pyroscope: Decouple config editor (#79027)
Decouple config editor
2023-12-05 10:57:49 +00:00
Joey ea3dda60ce TraceView: Improve small screen design in TracePageSearchBar (#78807)
Improve small screen design in TracePageSearchBar
2023-11-30 10:26:52 +00:00
Joey 5a6ac44902 Tempo: Update status operators (#78730)
* Set keyword operators

* Tests for keyword, string, number option types
2023-11-29 11:07:35 +00:00
Joey a49e1ded8f Tracing: Full text search (#78628)
* Full text search

* Tests
2023-11-28 13:29:04 +00:00
Joey add096ac8c Tempo: Switch to sdk logger from infra logger (#78524)
Switch to sdk logger from infra logger
2023-11-28 09:41:26 +00:00
Joey 4f46fb412c Tempo: Embed flame graph in span details (#77537)
* Embed flame graph

* Update test

* Update test

* Use toggle

* Update test

* Add tests

* Use const

* Cleanup

* Update profile tag

* Move flame graph out of tags, remove request and other cleanup + tests

* Update test

* Set flame graph by profile id and simplify logic

* Cleanup and redrawListView

* Create/use feature toggle
2023-11-23 13:36:53 +00:00
Joey 61553e1693 Tempo: Switch to sdk httpclient from infra httpclient (#78446)
Switch to sdk httpclient from infra httpclient
2023-11-22 09:14:53 +00:00
Joey c9faaf7600 Tempo: Fix missing deep span link (#77936)
* Fix span deep link not showing

* Update test
2023-11-13 11:10:19 +00:00
Joey de9ee2e127 Tempo: Update tag in span based on Pyroscope API (#77701)
* Update tags key

* Update link tags

* Update test
2023-11-07 08:45:09 +00:00
Joey 6e929b2b53 Tempo: Update the traces data in the testdata data source (#77198)
Update the traces data in the testdata data source
2023-11-07 08:24:11 +00:00
Joey c39e9a8f52 Tracing: Trace to profiles (#76670)
* Update Tempo devenv to include profiles

* Update devenv to scrape profiles from local services

* Cleanup devenv

* Fix issue with flame graph

* Add width prop to ProfileTypeCascader

* Add trace to profiles settings

* Add new spanSelector API

* Add spanSelector to query editor

* Update span link query

* Conditionally show span link

* Combine profile and spanProfile query types and run specific query type in backend based on spanSelector presence

* Update placeholder

* Create feature toggle

* Remove spanProfile query type

* Cleanup

* Use feeature toggle

* Update feature toggle

* Update devenv

* Update devenv

* Tests

* Tests

* Profiles for this span

* Styling

* Types

* Update type check

* Tidier funcs

* Add config links from dataframe

* Remove time shift

* Update tests

* Update range in test

* Simplify span link logic

* Update default keys

* Update pyro link

* Use const
2023-11-01 10:14:24 +00:00
Joey 266b3fd41b Pyroscope: Simplify and update query options to include max nodes in summary (#76942)
Simplify and update query options to include max nodes
2023-11-01 08:47:01 +00:00
Joey 37dbf037de Tracing: Improve frame type checking (#76898)
Improve frame type checking
2023-10-25 10:16:17 +01:00
Joey a851750b1c Tracing: Update configuration editor links (#76678)
Update doc links
2023-10-18 12:30:38 +01:00
Joey 4c22027ab7 Tracing: Do not try to render trace view in dashboard if data missing (#76630)
* Check for process and span id

* Remove log

* Update tests

* Check for key
2023-10-17 14:27:27 +01:00
Joey 8ebbe06377 Tracing: Remove unused code (#76538)
Remove unused code
2023-10-17 09:19:37 +01:00
JoeyandIsabel 7680576c6a Docs: Whats new for multiple spansets (#76447)
* Whats new for multiple spansets

* Added date

* Updated link format

* Updated version syntax

---------

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
2023-10-16 09:53:54 -04:00
Joey 07b08fc09f Tempo: Disable show matches only button when no matches (#76124)
* Disable show matches only button when there are no matches

* Update tests
2023-10-11 09:51:48 +01:00
Joey 9101eb219c Tempo: Improve UX of service graph related warnings (#76134)
Improve UX of service graph related warnings
2023-10-11 09:43:05 +01:00
Joey d57aef2eda Tempo: Normalize static filter queries (#72794)
* Only show static filter if tag is defined

* Update previosuly left out test

* Add test

* Add warning if tag is missing
2023-09-27 09:03:37 +01:00
Joey 4155f0a92e Tracing: Fix cannot assign to read only property in TagMappingInput (#75070)
* Fix cannot assign to read only property in TagMappingInput

* cloneDeep and updates

* Update assignment

* Updates state change
2023-09-22 15:03:42 +01:00
Joey e0659c05da Tracing: Span filters reset show matches only (#75150)
* Reset show matches only when clear button pressed

* Add test

* Update test
2023-09-22 09:02:38 +01:00
Joey a8a8c9849d Tempo: Metrics summary update sorting no values (#74818)
* Update sorting when there is no value

* Update test
2023-09-13 14:23:17 +01:00
Joey a12c224cc0 Tempo: Metrics summary no value (#74582)
Metrics summary no value
2023-09-13 10:22:22 +01:00
Joey ee96b08f4b Table: Add dataframe name to single table (#74584)
* Add dataframe name to single table

* Extract method

* Update name
2023-09-13 10:16:02 +01:00
Joey 16bdd55696 Tempo: Fix metricSummary sorting in spanCount and errorPercentage (#74542)
* Fix sorting in spanCount and errorPercentage

* Update types

* Spelling

* Update errorPercentage
2023-09-13 08:48:58 +01:00
Joey 3a90e2d13c Tempo: Remove noop (#74207)
Remove noop
2023-09-04 15:55:22 +01:00
Joey 7f2841aeca Tempo: Update default editor to TraceQL tab (#74153)
Update default editor to TraceQL tab
2023-09-04 15:53:03 +01:00
Joey a8fcbe75ea Trace View: Use number instead of array for last color index (#74115)
* Use integer instead of array for last color index

* Update naming
2023-08-31 16:27:09 +01:00
Joey dc26cdf6c9 Tempo: Reset metrics summary tag when scope changes (#74028)
Reset tag when scope changes
2023-08-30 11:26:09 +01:00
Joey 61fd34ca2b Tempo Config editor updates (#73992)
Config editor updates
2023-08-30 08:53:13 +01:00
Joey e8aa74aba2 Rename Group By Metrics to Aggregate by (#73980)
* Rename Group By Metrics to Aggregate by

* Update test
2023-08-29 09:28:55 +01:00
Joey 59e4c257bb Tempo: Metrics summary (#73201)
* Metrics summary

* Update query

* Remove colors

* Update states

* Add group by into its own component

* Add group by to search and traceql tabs

* Add spacing for group by

* Update span kind values

* Update span status code values

* Update query based on target + group by

* Cleanup

* Only add targetQuery if not empty

* Add kind=server to table

* Update groupBy query logic

* Add feature toggle

* Use feature toggle

* Self review

* Update target query

* Make gen-cue

* Tweak query

* Update states

* useRef for onChange

* Fix for steaming in search tab

* Add loading state tests

* metricsSummary tests

* Datasource tests

* Review updates

* Update aria-label

* Update test

* Simplify response state

* More manual testing and feedback from sync call

* Prettier and fix test

* Remove group by component from traceql tab

* Cleanup, tests, error messages

* Add feature tracking
2023-08-28 15:02:12 +01:00
Joey ab94c9d730 Tempo: Only add option to values dropdown if there is a value (#72524)
Only add option to list if there is a values
2023-08-18 08:17:56 +01:00
Joey e6c96e7308 Tracing: Split name column in search results (#72449)
* Split name column

* Add tests

* Update test
2023-08-14 13:26:08 +01:00
8c2f439cd7 Table: Support display of multiple sub tables (#71953)
* Add nested option to DataFrame. Refactor Table to use nested dataframes for sub-tables

* Use nested frames for TraceQL response

* debugging

* Fix cell text and table position

* Update getItemSize

* noHeader size

* Update sub table renderer

* Update table container height

* Cleanup and fix RawPrometheusContainer height

* Update resultTransformer and docker script

* Updates to TableContainer, resultTransformer after merge

* Fixes for table pagination in dashboards

* Cell height and show footer enhancement/fix

* Sub table links

* Update RawPrometheusContainer

* Remove console log

* Update tests

* Update storybook

* Remove Tempo demo

* Store nested data in single field via its values

* Move nested prop into custom

* Tempo demo

* Add field type & update incorrect logic

* Update docker compose image for Tempo

* Update packages/grafana-data/src/field/fieldOverrides.ts

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>

* Simplify logic for getting nestedFrames and rendering sub tables

* Update docs for table

* Update nested table bg color

* Lighten nested table bg color

* Renames

* Migrate frames using parentRowIndex and add deprecation notice

* Update title

* Align expander icon size between Table and interactive table

* Table: Refactor out the expanded rows bits

* fix spacing

* Add line along left side for expanded rows

* Disable hover row background when expanded

---------

Co-authored-by: André Pereira <adrapereira@gmail.com>
Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
2023-08-10 12:33:46 +01:00
Joey b4c55765fe Tempo: Only get span_names when they are in the response (#72663)
* Only get span names when they are in the response

* Find span_name field/labels
2023-08-03 07:55:32 +01:00
Joey 7612f3d955 Tempo: If no search tag then do not query API for tag values (#72522)
* If no tag then do not query api for tag values

* Update test
2023-08-01 08:44:13 +01:00
Joey 813e47103b Tracing: Trace to metrics default range (#72433)
* Update default range

* Update tests
2023-07-31 11:24:12 +01:00
Joey c1c8b4d368 Tracing: Span filters UI enhancements (#72245)
* Update margin between inputs

* Updated spacing between toggle and text

* Add more spacing
2023-07-25 13:31:44 +01:00
Joey e4f419b84f Tempo: Use new configuration editor components (#71288)
* Use new config components in Tempo

* Update Grafana experimental version
2023-07-25 12:50:12 +01:00
Joey 8afd216397 Tracing: New images in trace-integration docs (#72034)
* Update span filtering docs

* Update images
2023-07-25 08:52:49 +01:00
Joey 090b8d61e2 Tracing: Remove newTraceViewHeader feature toggle (#71818)
* Remove TracePageHeader, uiFind, setTrace and many spanFindMatches

* Removed TracePageSearchBar

* Update useSearch

* Update filterSpans

* Update docs

* Updated tests

* Add trace to tests

* Remove feature toggle

* Renames in useSearch

* Renames in filter-spans

* Cleanup fixes

* Rename TracePageHeader

* Rename TracePageSearchBar

* Update test

* Update style for long urls

* Style and check
2023-07-19 14:31:58 +01:00
Joey 76224c88bb Tracing: Add services, depth to span filters metadata (#71084)
* Add services, depth to span filters metadata

* Add default metadata to method
2023-07-14 09:31:00 +01:00
Joey 76a83dd540 Traces: Add inline validation and greater precision to duration fields in span filters (#71404)
* Add inline validation to span filters

* Update filter spans by duration precision

* Update IntervalInput props

* Update validation

* Update span filters

* Update props

* Update test

* Update defaults and duration aria labels
2023-07-13 10:48:31 +01:00
Joey 6615418df8 Tracing: Show next/prev buttons when span filters are collapsed (#71025)
* Show next/prev buttons when span filters are collapsed

* Update test

* Remove imports

* Update lint

* Prettier

* Update test

* Update styling
2023-07-12 07:52:07 +01:00
Joey a56a279c67 Traces: Filtering by span id (#71275)
* Filter by span id

* Update test
2023-07-11 08:59:36 +01:00
Joey f98f6ea391 Tracing: Make show filters only keyboard accessible (#70890)
* Make show filters only keyboard accessible

* Update test

* Update styling
2023-07-11 08:05:11 +01:00
Joey 280f259f73 Tracing: Remove unused selectors (#71038)
Remove unused selectors
2023-07-05 10:42:12 +01:00
Joey f1338cee60 Tracing: Add inline validation to time shift configuration fields (#70879)
* Inline validation

* Update invalidTimeShiftError after self review

* Renames and moved err msg

* Update validation

* Remove local state
2023-07-04 10:49:21 +01:00
Joey 0668fcdf95 Tempo: Update error messages (#70448)
Update error messages
2023-06-28 10:34:11 +01:00
Joey 5b13b71ed0 TraceView: Remove unused trace selectors (#70527)
Remove unused selectors
2023-06-27 09:01:35 +01:00
Joey 8f7e1f36ab Traces: Remove noop functions (#70392)
Remove unused functions
2023-06-21 14:49:04 +01:00
Joey 00ec9fceb9 Tempo: Represent OTLP Span Intrinsics correctly (#69394)
* Span intrinsics

* Update intrinsics and add to span details

* Remove intrinsics section

* Update tests

* Update status code text

* Self review

* Move previously intrinsic values to span

* Remove few methods
2023-06-21 11:39:12 +01:00
Joey 06a4b6da62 Tempo: Use pipe in TraceQL by default for multi-value variables (#70051)
* Use pipe in traceQL by default for multi value variables

* Use constant
2023-06-19 13:28:56 +01:00
Joey 5c45b8724b Tracing: Use new DataSourceDescription component (#69443)
Use new DataSourceDescription component
2023-06-14 10:45:36 +01:00
Joey 0e90dfcc9c Tracing: Upgrade tracing data source configuration editors (#68764)
* Add tracing config sub sections

* Export common sections and update divider in additional settings section

* Max width and margin bottom

* Add feature name to config link

* Update SpanBarSettings

* remove import
2023-06-01 15:52:40 +01:00
Joey e6c8ba56c8 Tracing: Rename reset to clear for consistency (#68821)
Rename reset to clear for consistency
2023-05-23 09:54:51 +01:00
Joey 6a12673f8b Tempo: Update devenv (#68675)
* Update docker-compose.yaml and tempo.yaml

* Add in job label
2023-05-22 08:34:51 +01:00
Joey fb3437586e Accessibility: Make QueryOptions in Phlare and Parca accessible (#68515)
Fix accessibility issues for QueryOptions in Phlare and Parca
2023-05-18 09:39:18 +01:00
Joey caba156488 Tempo: Integrate scoped tags API (#68106)
* Support scoped tags API

* Tests

* Updates

* Updated components and language provider to certralize tag retrieval

* Update tests and add new tests for language provider

* Minor update

* Update test
2023-05-17 07:50:27 +01:00