Commit Graph

50424 Commits

Author SHA1 Message Date
Matthew Jacobson
533bed6d94 Alerting: Fix simplified routes '...' groupBy creating invalid routes (#86006)
* Alerting: Fix simplified routes '...' groupBy creating invalid routes

There were a few ways to go about this fix:
1. Modifying our copy of upstream validation to allow this
2. Modify our notification settings validation to prevent this
3. Normalize group by on save
4. Normalized group by on generate

Option 4. was chosen as the others have a mix of the following cons:
- Generated routes risk being incompatible with upstream/remote AM
- Awkward FE UX when using '...'
- Rule definition changing after save and potential pitfalls with TF

With option 4. generated routes stay compatible with external/remote AMs, FE
doesn't need to change as we allow mixed '...' and custom label groupBys, and
settings we save to db are the same ones requested.

In addition, it has the slight benefit of allowing us to hide the internal
implementation details of `alertname, grafana_folder` from the user in the
future, since we don't need to send them with every FE or TF request.

* Safer use of DefaultNotificationSettingsGroupBy

* Fix missed API tests
2024-04-16 12:14:39 -04:00
Arati R
79eab65f94 Storage: Add mode-specific DeleteCollection implementations (#86065)
* Add DeleteCollection methods to modes 1 and 4
* Add DeleteCollection implementations for modes 2 and 3
2024-04-16 17:05:31 +02:00
Nick Richmond
d3fee607e2 Expressions: sort numeric metrics behind feature toggle (#85911)
* feat: sort numeric metrics behind feature toggle

* chore: upgrade `dataplane/sdata` to latest tag

* chore: `go work sync`
2024-04-16 10:52:47 -04:00
Ieva
036f826b87 AuthZ: Further protect admin endpoints (#86285)
* only users with Grafana Admin role can grant/revoke Grafana Admin role

* check permissions to user amdin endpoints globally

* allow checking global permissions for service accounts

* use a middleware for checking whether the caller is Grafana Admin
2024-04-16 15:48:12 +01:00
Karl Persson
0f06120b56 User: Clean up update functions (#86341)
* User: remove unused function

* User: Remove UpdatePermissions and support IsGrafanaAdmin flag in Update function instead

* User: Remove Disable function and use Update instead
2024-04-16 16:33:50 +02:00
owensmallwood
8c8885ef23 Storage Api: Adds traces (#85391)
- adds traces and improved logging to the unified storage server
- add a configurable logger to the gRPC server service
2024-04-16 08:30:51 -06:00
Kyle Brandt
a12669951b Prometheus: Add BE support for Adhoc Filters (#85969)
---------

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
2024-04-16 16:56:50 +03:00
Karl Persson
8520892923 User: Fix GetByID (#86282)
* Auth: Remove unused lookup param

* Remove case sensitive lookup for GetByID
2024-04-16 15:24:34 +02:00
Victor Marin
b9285e320a Fix new dashboard save name validation (#86290) 2024-04-16 15:46:25 +03:00
Piotr Jamróz
ccd660d559 Explore: Skip flaky test (#86289)
Skip flakey test
2024-04-16 12:42:22 +00:00
brendamuir
0cb3e8bc49 Alerting docs: adds roles docs (#86261)
* Alerting docs: adds roles docs

* adds header

* adds link

* spacing

* prettier

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* prettier

* Update docs/sources/alerting/set-up/configure-roles/index.md

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* corrects link

---------

Co-authored-by: Pepe Cano <825430+ppcano@users.noreply.github.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2024-04-16 14:33:15 +02:00
Ezequiel Victorero
7c7cdf7c3d Docs: Update broken links to grafana play (#86233)
* Docs: Update broken links to grafana play

* Update docs/sources/datasources/graphite/template-variables/index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Update docs/sources/datasources/influxdb/template-variables/index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

---------

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
2024-04-16 09:32:52 -03:00
kay delaney
3795f0d5a9 Dashboards: Fix issue when importing external dashboard with datasource variables (#86273) 2024-04-16 13:29:27 +01:00
Tom Ratcliffe
8f0f0387b8 Simplify providers used for test utils method
For now, keep the providers down to just what was already in TestProvider
2024-04-16 12:23:50 +01:00
Tom Ratcliffe
45949e7684 Simplify import logic for test utils 2024-04-16 12:23:50 +01:00
Tom Ratcliffe
488c5b8396 Use PropsWithChildren and allow router configuration in test utils render 2024-04-16 12:23:50 +01:00
Tom Ratcliffe
045ec86984 Add typing for react-inlinesvg mock now its included in tsconfig 2024-04-16 12:23:50 +01:00
Tom Ratcliffe
0f88075e4c Mark TestProvider as deprecated
(up for discussion, depending on adoption of test utils. Alternative approach could be to re-use TestProvider in test-utils)
2024-04-16 12:23:50 +01:00
Tom Ratcliffe
9ad87de0b8 Alias @grafana/test-utils for easier imports in tests 2024-04-16 12:23:50 +01:00
Tom Ratcliffe
c0cb36c9d6 Add initial test-utils file with render helper, wrapping in (most) required providers 2024-04-16 12:23:50 +01:00
Josh Hunt
f90e3b2ebc I18N: Warn if t() called before init (#86222)
* I18N: Warn if t() called before init

* don't log in tests

* fix double assignemnt!
2024-04-16 12:47:24 +02:00
Gábor Farkas
2379498228 mysql additional decoupling steps (#86168)
* mysql additional decoupling steps

* updated snapshot test
2024-04-16 11:50:41 +02:00
Leonard Gram
2c304c5fdf Cloudmigration: org admin can migrate (#85256) 2024-04-16 11:36:10 +02:00
Josh Hunt
b5337ba419 I18N: Fix untranslated descriptions in data source picker (#86216)
I18n: Remove t() call from root module scope
2024-04-16 10:28:24 +01:00
Josh Hunt
f110c05797 I18N: Split loadTranslations i18next plugin into seperate file (#86217) 2024-04-16 09:53:23 +01:00
Laura Fernández
f1de8940dc Grafana UI: StackingEditor and addHideFrom - Replace HorizontalGroup with Stack (#86192) 2024-04-16 10:46:01 +02:00
Alexa V
40f1b2c92c Dashboard: Migration - Add public dashboard tag in the nav bar (#86204)
Migrate public dashboard badge to scenes dashboard
2024-04-16 10:04:25 +02:00
Gábor Farkas
9015bfa3f4 mssql: decouple sqleng (#86130)
* mssql: decouple sqleng

* fix codeowners-file
2024-04-16 08:00:14 +00:00
Fabrizio
538db9ab1c Docs: Fix typos (#85651) 2024-04-16 09:58:40 +02:00
Ryan McKinley
ba510d1a7d Playlists: Enable kubernetesPlaylists by default in OSS (#86259) 2024-04-16 09:19:35 +02:00
Torkel Ödegaard
e15beab362 DashboardScene: Fixes saving dashboard with angular panels (#86098)
* DashboardScene: Fixes saving angularOptions

* Update

* Update
2024-04-16 03:13:42 +02:00
Torkel Ödegaard
869814ea3e DashboardScene: Fix empty row repeat issue (#86095) 2024-04-16 03:10:24 +02:00
Brendan O'Handley
f85470d652 Prometheus: Use the frontend package in Prometheus and remove feature toggle (#86080)
* add history links for monaco completion provider folder

* add history links for monaco query field folder

* add history links for components folder

* add history links for configuration folder

* add history links for dashboard json folder

* add history links for gcopypaste folder

* add history link for variableMigration

* add history link for querybuilder/components/metrics-modal folder

* add history link for querybuilder/components/promqail folder

* add history links for querybuilder/components folder

* add history links for querybuilder/hooks folder

* add history links for querybuilder/shared folder

* add history links for querybuilder folder

* add history links for querycache folder

* add history links for src folder

* use frontend package and custom auth in module.ts

* remove files and fix import issues

* remove usePrometheusFrontendPackage

* remove extra files

* update betterer

* remove extra files after rebase

* fix betterer for rebase

* fix e2e flakiness
2024-04-15 16:45:23 -05:00
David Allen
c9350a25c4 docs: add annotations play link (#86206)
* docs: add annotations play link

* PR feedback
2024-04-15 17:30:48 -04:00
Nick Richmond
63aa8a6035 Chore: add missing modowner (#86234)
* chore: add modowner

* fix: modowner
2024-04-15 23:17:15 +02:00
David Allen
f50e29e004 docs: add thresholds play link (#86212)
* docs: add thresholds play link

* PR review
2024-04-15 17:16:04 -04:00
David Allen
19ae9377b9 docs: added logs panel play link; added dedup options, reformatted fig (#86209)
* docs: added logs panel play link; added dedup options, reformatted fig

* Update docs/sources/panels-visualizations/visualizations/logs/index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Update docs/sources/panels-visualizations/visualizations/logs/index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

---------

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
2024-04-15 17:08:06 -04:00
David Allen
c450d61d32 docs: query data/relative time range override play link (#86213) 2024-04-15 15:51:13 -04:00
David Allen
04e127b368 Docs: added bar gauge play link (#86205)
* docs: added bar gauge play link

* Update docs/sources/panels-visualizations/visualizations/bar-gauge/index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

---------

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
2024-04-15 15:50:53 -04:00
David Allen
5a57c31607 Docs: add template var Play link; cleanup existing (#86074)
* Docs: add template var Play link; cleanup existing

* Update docs/sources/dashboards/variables/_index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Update docs/sources/dashboards/variables/_index.md

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>

---------

Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
2024-04-15 15:32:09 -04:00
Brendan O'Handley
7c156274cd Prometheus: Add native histogram functions (#86002)
* add native histogram functions to code editor

* add native histogram function types for query builder

* add functions to query builder

* add test to show parsing breaks from code to builder

* add histogram_avg to code editor

* add histogram_avg to builder and make parity between package and core

* add functions to hard coded promql file for highlighting

* remove native histogram test so that it can be added in #85942

* remove functions from core prometheus js to prevent merge conflict in #86080

* use xit for test instead of removing it
2024-04-15 14:26:51 -05:00
Charandas
2aedd9dacf K8s: add ID token to requests outbound to new query endpoint (#86214) 2024-04-15 20:34:20 +02:00
ismail simsek
cc87281d71 Prometheus: Respect dashboard queries when querying ad hoc filter labels (#85674)
* use queries

* extract metric name from query

* unit tests
2024-04-15 19:05:19 +02:00
Laura Fernández
82f910c0c5 Chore: Use handleReducedMotion to smooth the animation in LoadingBar (#85808) 2024-04-15 17:27:08 +02:00
Isabel Matwawana
219c2c761e Docs: add dashboards landing page (#86001)
* Added template from existing landing page

* Added dashboards content

* Fixed front matter

* Referenced existing icon to test

* Added test icon

* Edited text

* Fixed link formatting

* Finalized description and overview text

* Updated description'

* Updated tile text

* Updated docs/ref section
2024-04-15 11:07:05 -04:00
Laura Fernández
726cd4a8a6 Chore: Fix link in UsersTable (#86152) 2024-04-15 16:56:28 +02:00
Isabel Matwawana
d9a0cedd89 Docs: add panel overview (#86075)
* Added panel overview page and updated panel editor page

* Finalized panel overview intro text and added links

* Added add panel section to overview and removed section from editor

* Fixed version interpolation syntax and updated Cloud link

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

* Fixed version interpolation syntax

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>

---------

Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
2024-04-15 10:51:00 -04:00
Isabel Matwawana
918f122433 Docs: add tags section to dashboard settings docs (#85875)
Edited
2024-04-15 10:49:14 -04:00
David Allen
eb46d85829 Docs: add best practices Play link (#86076) 2024-04-15 10:47:58 -04:00
Jack Westbrook
1dfd34ee79 Chore: Add codemod and betterer config to make barrel imports explicit (#80913)
* chore: add codemod for highlighting barrel imports

* style(frontend): add no-barrel-files plugin to betterer

* chore(betterer): update betterer file

* ci(frontend-metrics): track occurrences of barrel files being imported

* chore: clean up explicit barrel imports codemod script

* chore(codeowners): add explicit barrel imports script

* Add no-barrel-files plugin to betterer configuration

Co-Authored-By: LeventeBalogh <balogh.levente.hu@gmail.com>

---------

Co-authored-by: LeventeBalogh <balogh.levente.hu@gmail.com>
2024-04-15 16:36:19 +02:00