Commit Graph
100 Commits
Author SHA1 Message Date
Ashley Harrison 914966a347 Update ci-frontend-metrics.sh (#45161) 2022-02-09 15:55:15 +00:00
Ashley Harrison d3d7411e36 Chore: Add betterer test to track conversion of enzyme tests (#45055)
* Add betterer test for number of enzyme tests

* emit metric for number of enzyme tests

* update frontend metrics script

* Merge...

* Switch order of betterer/lint

* Update version of betterer

* kick levitate

* Update lockfile
2022-02-09 12:41:39 +00:00
Ashley Harrison a552e7323f Improve existing e2e repeat tests a bit (#45001)
* Improve existing e2e repeat tests a bit

* nicer menu blur
2022-02-07 16:24:30 +00:00
Ashley Harrison 12176e24ef Chore: update eslint (#44982) 2022-02-07 13:46:02 +00:00
Ashley Harrison 9e52361c1e Accessibility: Fix text selection when using FocusScope (#44770)
* Add tabIndex={-1} to places using focusScope to allow for text highlighting

* use useDialog

* don't need explicit tabIndex anymore

* remove duplicate spreading of props
2022-02-04 11:20:18 +00:00
0cb3037b55 Panel: Embed URL is now correctly generated for a panel in the home dashboard (#44706)
* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* test tidyup

* Add comment for route

Co-authored-by: kay delaney <kay@grafana.com>
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: Muaaz Saleem <muaazsaleem@Muaazs-MacBook-Pro.local>
2022-02-02 13:38:23 +00:00
Ashley Harrison 666a794a82 Navigation: Initialise navTree in redux store (#44440)
* Add navTree to redux store and used that in NavBar/NavBarNext

* Use createSlice

* update import

* Use NavBarUnconnected instead of Component
2022-01-28 10:06:52 +00:00
Ashley Harrison e1af78954f Only modify table spacing (#44313) 2022-01-21 13:38:13 +00:00
Ashley Harrison d4d306d825 Dashboard: Prevent Mixed datasources using the test datasource crashing (#44128)
* Special case mixed datasources... :/

* Revert "Special case mixed datasources... :/"

This reverts commit dd0e3ea4a8.

* Ensure testdata persists datasource when switching scenario

* Add a unit test to prevent regressions

* kick drone
2022-01-19 13:04:35 +00:00
Ashley Harrison e9f8b40e18 Chore: remove e2e/build_results.zip and add to .gitignore (#44197) 2022-01-19 10:50:55 +00:00
Ashley Harrison 252645b330 Playlists: Enable sharing direct links to playlists (#44161)
* Special case mixed datasources... :/

* Hacky implementation of playlist share modal

* Refactor StartModal into PlaylistSettingsModal

* Revert "Refactor StartModal into PlaylistSettingsModal"

This reverts commit e71fc33865.

* Create new ShareModal component

* Revert "Special case mixed datasources... :/"

This reverts commit dd0e3ea4a8.

* PlaylistMode instead of PlaylistModes

* kick drone
2022-01-19 09:44:29 +00:00
Ashley Harrison aa00af8f2d Chore(CodeQL): Add noopener noreferrer to external links in email templates (#44092)
* Add noopener noreferrer to external links in email templates

* missed one...

* kick drone
2022-01-17 11:17:43 +00:00
Ashley Harrison c618339482 Export: Fix error being thrown when exporting dashboards using query variables that reference the default datasource (#44034)
* handle undefined datasources, add unit test

* slightly nicer
2022-01-17 10:21:13 +00:00
Ashley Harrison 45287b4129 Button: Only set pointer-events: none; on disabled LinkButtons (#44006) 2022-01-13 15:58:21 +00:00
Ashley HarrisonandJack Westbrook f74b21c119 Dependencies: downgrade typescript to 4.4.4 for now (#43970)
* Downgrade typescript to 4.5.2 for now

* Downgrade to 4.4.4 instead :(

* kick drone

* Update .github/renovate.json5

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2022-01-13 10:08:38 +00:00
Ashley Harrison 8f1468df6a only push default datasources to the list if they're not undefined (#43966) 2022-01-13 09:26:26 +00:00
1966eba796 Chore: Add some e2e tests for repeating behaviour (#43457)
* user essentials mob! 🔱

* user essentials mob! 🔱

* WIP: Mob session work 🚧 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* mob next [ci-skip] [ci skip] [skip ci]

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* :construction:: Mob session work 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* Move repeats suite under dashboard suite

* remove these generated files

* move repeats-suite into dashboards-suite

* Reexport dashboard jsons from play and update them

* :construction:: Mob session work 🔱

* :construction:: Mob session work 🔱

* Rename dashboards to work with stripnulls

* Run stripnulls

* Add repeat to row schema

* Clean up the rest of the repeating dashboards

* Fix tooltip sorting

* Update older dashboards

* Update golden files so tests pass

* format this to ensure consistent tabs/spaces

* undo whitespace changes

* Update scripts/stripnulls.sh

Co-authored-by: sam boyer <sam.boyer@grafana.com>

* update schema versions and test

Co-authored-by: thisisobate <obasiuche62@gmail.com>
Co-authored-by: Hugo Häggmark <hugo.haggmark@gmail.com>
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: kay delaney <kay@grafana.com>
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
Co-authored-by: sam boyer <sam.boyer@grafana.com>
2022-01-11 16:47:30 +00:00
Ashley Harrison 77347a37b1 Add tests to ensure infinite value mappings work (#43858) 2022-01-10 14:16:07 +00:00
Ashley Harrison f2336fd981 Need to add a group name to ensure they're batched correctly (#43796) 2022-01-07 12:32:09 +00:00
Ashley Harrison 1fe098ecd2 Enable patch updates in renovate (#43795) 2022-01-07 11:27:23 +00:00
Ashley Harrison 6a558582d5 Fix deprecated sass (#43753) 2022-01-06 13:09:52 +00:00
Ashley Harrison c87b048af8 Login: Prevent page overflowing on mobile (#43739) 2022-01-06 10:34:13 +00:00
Ashley Harrison b826804ef7 Hide previews behind toggle properly (#43704) 2022-01-05 15:28:03 +00:00
Ashley Harrison c509c32091 Remove height/width to fix safari issue (#43668) 2022-01-04 15:55:34 +00:00
Ashley Harrison 39f787cbef Navigation: Remove some redundant css and tidy up reverse logic (#43403)
* Remove some redundant css and tidy up reverse logic

* Fix alignment of subtitle

* Remove navbar-dropdown class
2021-12-21 16:15:03 +00:00
Ashley Harrison c7f76df61e Use outline -2px to guarantee visibility of outline (#43400) 2021-12-21 10:52:26 +00:00
Ashley Harrison 57c3549b07 Implement left arrow to focus parent, fix list style on firefox (#43345)
* Implement left arrow to close menu for now, fix list style on firefox

* Implement onLeft

* Fix outline of first item in navbar

* Fix focus styles appearing when using mouse

* add unit test
2021-12-20 17:41:14 +01:00
Ashley Harrison 6f8e651cdb Move the background style to the parent component (#43359) 2021-12-20 16:00:29 +00:00
Ashley Harrison 80b55f09ad Configuration: You can now see your expired API keys if you have no active ones (#42452)
* Configuration: Always display expired API keys

* Use exclamation-triangle instead

* Reintroduce toggle, move logic into store and call both endpoints

* Handle apiKeys without TTL

* Remove backend changes and make checks in frontend instead
2021-12-16 11:46:09 +00:00
Ashley Harrison c3ca46d5f6 Chore: Login via the API by default in Cypress (#43167)
* Use the api to login in cypress by default

* export getBaseUrl

* Revert "export getBaseUrl"

This reverts commit ae7eecea37.

* just use BASE_URL from the env

* fix exemplars test

* move into separate functions
2021-12-16 09:28:37 +00:00
Ashley Harrison 566907e617 Dashboard: Prevent crash when expanding a row containing panels with … (#43032)
* Dashboard: Prevent crash when expanding a row containing panels with no yPos defined

* Add comment explaining defensive code
2021-12-15 12:31:53 +01:00
Ashley HarrisonandAlexandra Vargas e1a5fa063a Chore: Add remove-milestone workflow (#43086)
* Add remove milestone action

* Update name

* Chore: use main branch from github action repository

Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
2021-12-14 13:54:19 +01:00
Ashley Harrison a345b06095 Chore(dependencies): Tidy up deps in our packages (#42085)
* Chore(dependencies): Tidy up deps in root package

* Tidy up dependencies in @grafana/data

* Tidy up dependencies in @grafana/e2e

* Tidy up @grafana/e2e-selectors packages

* Tidy up packages in @grafana/runtime

* tidy up packages in @grafana/ui

* tidy up packages in jaeger-ui-components

* Readd regenerator-runtime in @grafana/data
2021-12-06 17:32:55 +00:00
Ashley Harrison 0388082768 Update SearchItem.tsx (#42783) 2021-12-06 14:14:56 +00:00
Ashley HarrisonandRenovate Bot cc9151d382 Dependencies: Jest 27 (#42681)
* Update jest monorepo

* Update version of marked so it doesn't throw an error, set testEnvironment

* Fix some unit tests

* Remove all these tests that aren't actually working...

* use spyOn instead of mocking the whole module

* Fix linting

Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-12-03 17:09:25 +00:00
Ashley Harrison a365dcca5b Manage dashboards: Can now delete empty folders (#42527)
* Manage dashboards: Can now delete empty folders

* Split hasChecked out into a separate function

* Update modal text
2021-12-01 14:53:41 +00:00
Ashley Harrison 5eb35606b9 Transformations: Clarify behaviour of Date format (#42436)
* Transformations: Clarify behaviour of `Date format`

* Remove full stop from bullet point
2021-11-29 16:30:07 +00:00
Ashley Harrison 6aa05c5d05 Dependencies: Fix broken renovate config (#42379) 2021-11-26 17:36:23 +01:00
Ashley Harrison 84744aa04f Dependencies: enable minor version updates + turn on batched monthly patch updates (i think) (#42376) 2021-11-26 15:59:01 +00:00
Ashley Harrison 0516ad822b PanelEdit: Query now correctly initializes data source (#42291) 2021-11-26 09:37:19 +00:00
Ashley Harrison a897154017 pally-ci: Ignore version update element (#42249)
* pa11y-ci: Ignore update version element

* Add hideElements to pa11yci-pr.conf.js
2021-11-25 09:51:21 +00:00
Ashley Harrison 4318448539 News: Now reloads the feed when refreshing the dashboard or changing the time range (#42217) 2021-11-25 09:32:28 +00:00
Ashley Harrison 993025c478 Update .pa11yci-pr.conf.js (#42148) 2021-11-23 16:43:37 +00:00
Ashley Harrison 20e1457a78 Select: use findBy and make these tests async to avoid act() errors (#42134) 2021-11-23 14:53:10 +00:00
Ashley Harrison b6b75e919b Select: Select menus now properly scroll during keyboard navigation (#41917)
* Select: Select menus now properly scroll when navigating with the keyboard

* Remove this unnecessary children declaration in the interface

* Guard this with an if statement to avoid the nullish coalescing

* Don't need the optional chaining if we're guarding with an if
2021-11-22 10:57:44 +00:00
Ashley HarrisonandHugo Häggmark 97a423aedc Dashboard: Remove the current panel from the list of options in the Dashboard datasource (#41826)
* Dashboard: Update check for current panel

* Get datasource name as before

* Update public/app/plugins/datasource/dashboard/DashboardQueryEditor.tsx

Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>

* import SHARED_DASHBOARD_QUERY

* Add some unit tests

Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
2021-11-18 11:43:47 +00:00
Ashley Harrison 5452c069f7 PanelEdit: Display drag indicators on draggable sections (#41711)
* PanelEdit: Display drag indicators on draggable sections

* Move drag indicators between the sections
2021-11-17 13:46:24 +00:00
4f9c096599 Import: Load gcom dashboards from URL (#41799)
* mob next [ci-skip] [ci skip] [skip ci]

* mob next [ci-skip] [ci skip] [skip ci]

* mob next [ci-skip] [ci skip] [skip ci]

* mob next [ci-skip] [ci skip] [skip ci]

* mob next [ci-skip] [ci skip] [skip ci]

* mob next [ci-skip] [ci skip] [skip ci]

* mob next [ci-skip] [ci skip] [skip ci]

* Update import in reducer test

Co-authored-by: thisisobate <obasiuche62@gmail.com>
Co-authored-by: kay delaney <kay@grafana.com>
Co-authored-by: Hugo Häggmark <hugo.haggmark@gmail.com>
2021-11-17 12:26:44 +00:00
Ashley Harrison 0e76f347c3 Overrides: Pass searchQuery to overrides section to highlight correctly (#41684) 2021-11-16 11:41:53 +00:00
Ashley Harrison e0a60cf459 Navigation: Set dropdown text color to primary to match previous behaviour (#41560) 2021-11-10 17:34:38 +00:00
ed030f9c21 Chore: Set min node version in package.json to 16 (#41423)
* Update package.json

* Update build-container version

* Sign drone

* Update developer-guide

* kick drone

Co-authored-by: dsotirakis <sotirakis.dim@gmail.com>
Co-authored-by: Dimitris Sotirakis <dimitrios.sotirakis@grafana.com>
Co-authored-by: kay delaney <kay@grafana.com>
2021-11-10 14:23:10 +00:00
Ashley Harrison 90d2d1f4da Navigation: Refactor mobile menu into it's own component (#41308)
* Navigation: Start creating new NavBarMenu component

* Navigation: Apply new NavBarMenu to NavBarNext

* Navigation: Remove everything to do with .sidemenu-open--xs

* Navigation: Ensure search is passed to NavBarMenu

* Navigation: Standardise NavBarMenuItem

* This extra check isn't needed anymore

* Navigation: Refactor <li> out of NavBarMenu

* Navigation: Combine NavBarMenuItem with DropdownChild

* use spread syntax since performance shouldn't be a concern for such small arrays

* Improve active item logic

* Ensure unique keys

* Remove this duplicate code

* Add unit tests for getActiveItem

* Add tests for NavBarMenu

* Rename mobileMenuOpen -> menuOpen in NavBarNext (since it can be used for mobile menu or megamenu)

* just use index to key the items

* Use exact versions of @react-aria packages

* Navigation: Make the dropdown header a NavBarMenuItem

* Navigation: Stop using dropdown-menu for styles

* Navigation: Hide divider in NavBarMenu + tweak color on section header
2021-11-09 13:41:38 +00:00
Ashley Harrison bac6168e62 Update Select.mdx (#41205)
* Update Select.mdx

* kick drone
2021-11-02 21:28:13 +00:00
Ashley Harrison e0b2e0b152 Annotations: Ensure legacy annotation editors are cleaned up properly when switching datasource (#41115)
* Annotations: Ensure Angular-based annotation editors are cleaned up properly

* Annotations: Remove ng-if instead of wrapping in div
2021-11-02 15:30:20 +00:00
Ashley Harrison eb223a6645 LibraryPanels: Ensure the list can be fully scrolled when adding a library panel (#41196) 2021-11-02 15:21:11 +00:00
Ashley Harrison c45c246646 Chore(Linting): Remove js/ts files from prettier as they're already linted by eslint (#40459) 2021-11-02 11:25:12 +00:00
Ashley Harrison 727a4bd9e4 Navigation: New NavBar designs behind feature toggle (#41045)
* Navigation: Remove plus button behind feature toggle

* Navigation: Add home button behind feature toggle

* Navigation: Move settings/admin to bottom section behind feature toggle

* Navigation: Refactor grafana logo to be a NavBarItem

* Navigation: Create new PluginSection and styling changes to support new sections

* Navigation: Hack to use mobile menu as a mega menu for now

* Navigation: Only render plugin section if there are items

* Navigation: mobile menu is always 100% width if toggle is off

* Navigation: Reset width back to 48 and fix broken css property

* Navigation: Create generic NavBarSection component to reduce repetition

* Navigation: Don't show sublinks for core items

* Navigation: Comments from UX review

* Navigation: Remove mobile menu hack

* Navigation: Unit tests for enrichConfigItems and other minor review comments

* Navigation: Move section logic to backend

* Navigation: Refactor alerting links out into a separate function

* Navigation: More tests for isLinkActive

* Linting...

* Navigation: Create new NavBar component for when feature toggle is enabled
2021-11-02 11:19:18 +00:00
Ashley Harrison 283c19a129 TimePicker: Clicking outside the TimePicker/TimePickerCalendar now pr… (#40956)
* TimePicker: Clicking outside the TimePicker/TimePickerCalendar now properly dismisses the popup

* Slightly tidier syntax

* Don't forget to lint...
2021-10-29 10:31:56 +01:00
Ashley Harrison 67861c72d2 Update CODEOWNERS (#41026) 2021-10-29 10:19:26 +01:00
Ashley Harrison 3ed5ade78d Suggestions: Make the visualization suggestions more accessible (#40944)
* Suggestions: Make the visualization suggestions more accessible

* Reintroduce wrapping div to prevent title overlapping
2021-10-27 16:35:59 +01:00
Ashley Harrison 144e0c6ca3 Chore: fix lockfile (#40992) 2021-10-27 16:29:28 +02:00
Ashley HarrisonandGábor Farkas e9df40d7d0 Chore: Ignore copy-webpack-plugin updates in toolkit (#40812)
* Chore(dependencies): Ignore updates to copy-webpack-plugin in @grafana/toolkit for now

* Chore(dependencies): Ignore updates to css-loader in @grafana/toolkit for now

Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com>
2021-10-22 15:03:47 +01:00
Ashley Harrison c8f03139f8 Update latest.json (#40767) 2021-10-21 16:10:57 +02:00
Ashley Harrison 447a088750 Annotations: Allow addition of custom values whilst tags are loading (#40702) 2021-10-21 14:55:02 +01:00
Ashley Harrison b60ae7ebed Chore: Fix lockfile (#40706) 2021-10-20 16:22:17 +01:00
Ashley Harrison e48d77b1eb Variables: Improve display when selecting variables with the same value (#40607)
* Variables: Allow selection of different variables with the same value

* Variables: Don't modify this key
2021-10-19 14:13:17 +01:00
Ashley Harrison ec0fcbbf4b Annotations: Improve tag search performance (#40567) 2021-10-18 15:00:46 +01:00
Ashley Harrison f7cbb298f7 Update ci-frontend-metrics.sh (#40569) 2021-10-18 13:17:02 +01:00
Ashley Harrison 99c51a491b Update ci-frontend-metrics.sh (#40562) 2021-10-18 11:49:19 +01:00
Ashley Harrison e367fefdae Chore(dependencies): Remove puppeteer since we don't use it anywhere (#40137) 2021-10-08 09:22:43 +01:00
Ashley HarrisonandWill Browne 009a26264c NavBar: Order App plugins alphabetically (#40078)
* NavBar: Order App plugins alphabetically

* Update pkg/api/index.go

Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>

Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
2021-10-07 10:08:47 +01:00
Ashley Harrison 2f731d42f3 NewsPanel: Prevent Date and title collapsing to single row (#40016) 2021-10-06 11:14:37 +01:00
Ashley Harrison a3783a4eb7 Navigation: Increase navigation width + make icons a consistent size (#39959)
* Navigation: Increase navigation width + make icons a consistent size

* Navigation: Move style to only apply to headers
2021-10-04 16:18:17 +01:00
Ashley Harrison c2c04f218a Chore(DashboardSearch): Convert to use useTheme2 (#39918) 2021-10-04 10:32:29 +01:00
Ashley Harrison 4350f4931d NavBar: Styling tweaks to tidy up appearance (#39871)
* NavBar: Styling tweaks to tidy up appearance

* NavBar: Add external link icon to external links

* NavBar: Dim the external link icon

* bump drone

* NavBar: Rename variable to better describe what it's doing
2021-10-01 15:53:56 +01:00
Ashley Harrison ff009bee9f DashboardRow: Prevent unintended editing of DashboardRow with keyboard shortcut 'e' (#39792) 2021-09-29 16:33:11 +01:00
Ashley Harrison 2058193e98 BarGauge: Improve behaviour when working with streaming data (#39737)
* BarGauge: Improve behaviour when working with streaming data

* BarGauge: Refactor default min/max into grafana/data
2021-09-29 10:12:27 +01:00
Ashley Harrison 58d69d1055 Update CODEOWNERS (#39678) 2021-09-27 17:45:47 +01:00
Ashley Harrison 0aac00839a Update dependabot.yml (#39663) 2021-09-27 14:34:36 +01:00
Ashley HarrisonandJack Westbrook 11e362ff0a Chore(dependabot): Add explicit dependabot config to raise PRs for major version bumps (#39640)
* chore(dependabot): introduce explicit npm settings

* Chore(dependabot): ignore minor/patch versions for now

* Chore(dependabot): Ignore some things that will probably require work.

* Chore(dependabot): Let's keep the yaml formatting consistent

* Chore(dependabot): Remove zone.js as it's not used anymore

* Chore(dependabot): Update reviewers to frontend-ops team

* Chore(dependabot): Set the correct frontend-ops group :|

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
2021-09-27 13:34:25 +01:00
Ashley Harrison bbf64722e4 Update lockfile to correct output after running yarn install (#39646)
* Update lockfile to correct output after running `yarn install`

* Chore: Remove caniuse-db since nothing is using it anymore
2021-09-27 13:30:35 +01:00
Ashley Harrison 0229146c3b Update PageToolbar.tsx (#39572) 2021-09-23 14:36:53 +01:00
Ashley Harrison 6948dbe550 BarGauge: Set cell color to off if numeric value is NaN (#39574)
* BarGauge: Set cell color to off if numeric value is NaN

* BarGauge: Pull getCellColor out into a pure function and add unit tests
2021-09-23 13:25:13 +01:00
Ashley Harrison 4aed940738 VersionHistory: Remove global scss causing conflicts elsewhere (#39437) 2021-09-23 09:54:53 +01:00
Ashley Harrison a4d41d35d0 Chore(Navigation): Rename SideMenu -> NavBar (#39483) 2021-09-22 14:56:15 +01:00
Ashley Harrison e2c87caff0 Chore: Remove postcss-browser-reporter (#39409) 2021-09-20 13:38:23 +02:00
Ashley Harrison f3475b864c Chore: Tidy up emotion css with better theme breakpoint (#39340) 2021-09-20 08:55:31 +01:00
Ashley Harrison 06571e0af6 Dashboard: Don't show SectionHeader unless section has a title (#39336)
* Dashboard: Don't show SectionHeader unless section has a title

* Dashboard: Add unit test to prevent regression
2021-09-17 11:59:15 +01:00
Ashley Harrison 52d7358d83 Chore: More TypeScript strict fixes (#39300)
* Chore: More TypeScript strict fixes

* Chore: Use filter instead of reduce to fix TypeScript error

* Chore: Retype AzureResultFormat as string

* Chore: Account for getBlocks() poor typings of reduce

* Chore: Need to explicitly check for undefined here since '' is falsey
2021-09-17 09:47:23 +01:00
Ashley Harrison d0ae3a324f Update ci-check-strict.sh (#39298) 2021-09-16 16:51:35 +01:00
Ashley Harrison ca53f5c8da Navigation: Implement active state for items in the Sidemenu (#39030)
* Navigation: Implement active state for items in the Sidemenu

* Navigation: Improve logic for when link is active and extract isSearchActive into a util function

* Navigation: Implement custom rule for dashboards under /d/ and fix minor bugs

* Navigation: only show first matching active state + strip query params from link urls
2021-09-13 16:49:27 +01:00
Ashley Harrison e4ca6f2445 Sidemenu: Refactor Sidemenu to use emotion (#38995)
* Chore(Sidemenu): Refactor Sidemenu scss into emotion

* Fix unit test

* Sidemenu: use cx instead of template strings
2021-09-09 09:56:08 +01:00
Ashley Harrison e639b220ce Sidemenu: Use <a> instead of <Link> when target is present (#38987) 2021-09-08 14:39:49 +01:00
Ashley Harrison b82fe083d7 Sidemenu: Refactor SignIn to use SideMenuItem (#38882) 2021-09-08 09:48:30 +01:00
Ashley Harrison b24a4630a6 Chore(Navigation): Add feature toggle for new navigation work (#38929) 2021-09-07 17:24:44 +01:00
Ashley HarrisonandUrsula Kallio 9ce5edfa6b Docs: Update 'Whitelisted' to 'Allowed' per style guide (#38897)
* Docs: Updated 'Whitelisted' to 'Accepted' to match what's shown in the frontend now.

* Apply suggestions from code review

Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com>

* Docs: Update frontend to match docs

* kick drone

Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com>
2021-09-07 13:30:26 +01:00
Ashley Harrison ea65e11c44 Sidemenu: Various accessibility improvements (#38823) 2021-09-02 14:17:57 +01:00
Ashley Harrison 205c672417 Sidemenu: Refactor TopSectionItem and BottomNavLinks into SideMenuItem (#38755)
* Sidemenu: Refactor TopSectionItem and BottomNavLinks into SideMenuItem

* Update failing snapshot

* BottomSection: Convert tests to RTL + add some extra unit tests
2021-09-01 17:16:50 +01:00
Ashley Harrison b40d48258d Sidemenu: Fix logout button (#38747) 2021-08-31 11:33:38 +01:00
Ashley Harrison 7a242afcd6 Sidemenu: Refactor BottomNavLinks to use SideMenuDropDown (#38598)
* Sidemenu: Attempt to refactor BottomNavLinks to use SideMenuDropDown

* BottomNavLinks: Rewrite existing enzyme tests in RTL

* BottomNavLinks: Use object spreading instead of slicing
2021-08-31 10:37:51 +01:00