Commit Graph
73 Commits
Author SHA1 Message Date
Josh Hunt ce4d8646fd Chore: E2E tests for various variables types (#44747)
* Pass data-testid into VariableTextEditorField

* Add e2e tests for custom variables

* Rename query variable specs to match others

* Add e2e tests for Text Box variables

* manually remove id: null

* Add tests for constant variables
2022-02-03 09:58:56 +11:00
Josh Hunt d2f80c3a6f Chore: Replace ts-jest mocked with jest.mocked (#44630) 2022-01-31 09:28:58 +01:00
Josh Hunt c6ce629fd8 I18n: Translate navigation items (#44131)
* I18n: Translate navigation items

* improve comment, remove console.log

* update mock macros

* Mark up all phrases for translation

* added deprecate text comment, moved translations to a seperate file

* use TestProvider in NavBarItem

* use TestProvider in nav tests

* remove text deprecation comment

* update translations
2022-01-31 03:41:58 +01:00
Josh Hunt b1b6205651 TablePanel: Fix ad-hoc variabes not working on default datasources (#44314)
* Dashboards: Fix ad-hoc variabes not working on default datasources

* not async

* Update comment
2022-01-31 01:16:46 +01:00
Josh Hunt bddf3d7558 Chore: Correctly escape strings in JSONFormatter (#44096)
* Chore: Properly escape double-quotes in strings in JSONFormatter

* escape slashes
2022-01-21 14:51:59 +00:00
9f97f05fcc DashboardSettings: Prevent Dashboard permissions from linking to folder permissions when user does not have sufficient permissions (#44212)
* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* user essentials mob! 🔱

* add tests

* fix up

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Alexandra Vargas <alexa1866@gmail.com>
Co-authored-by: Hugo Häggmark <hugo.haggmark@gmail.com>
2022-01-19 16:27:33 +01:00
Josh Hunt 36983d8d3b Chore: Mark up User Profile page for translation (#43874)
* Mark up User profile page for translation

* Extract new messages

* updated selectors

* update selectors

* wip TestProvider

* update tests

* fix field labels

* extract new messages

* don't store date objects in redux state

* don't store date objects in redux state
2022-01-17 16:58:49 +00:00
Josh Hunt 7ea951b35d Chore: Use ReactNode type for Field error prop (#43852)
* Chore: Use ReactNode type for Field error prop

* add LoadingPlaceholder
2022-01-11 16:45:14 +00:00
Josh Hunt 609a1aa8ad Chore: parse parseDuration values as numbers (#42826)
* Chore: parseDuration values as numbers

* Clean up RefreshPicker labels
2021-12-16 11:35:53 +00:00
Josh Hunt 4f6d08f14b I18N: Add Lingui core translation framework. (#41827)
* I18N: Add Core Lingui framework for translating the UI

* Make FieldSet accept ReactNode for the label, so it can be translated

* Translate a phrase in the User profile edit form

* Translate phrase

* run lingui compile before webpack builds

* init i18n more lazily

* i1n:compile in drone lint step

* wip for getting tests to work

* Use mock lingui/macros because its too hard to use the real macros in Jest...

* mock messages for tests

* use specific lingui version

* add comment for test helper

* we actually don't need the i18n setup in tests because we mock out <Trans />

* update package.json

* remove unneded imports

* revert back babel core version

* Create a I18nProvider wrapper
2021-12-15 17:00:37 +01:00
Josh Hunt 130386f84b Chore: Fix errant text appearing in AnnotationSettingsList table (#42360) 2021-11-26 13:25:08 +00:00
Josh Hunt 879cdcd0c7 Chore: Refactor isSharedDashboardQuery to narrow type natrually (#42312) 2021-11-26 10:53:08 +00:00
Josh Hunt 62e55f4724 Chore: Refactor QueryRunner to remove type assertions (#42329) 2021-11-26 10:28:13 +00:00
Josh Hunt 3b497f3e8d Chore: Move babel config to a root babel.config.json (#41615)
* Chore: Move babel config to a root babel.config.json

* Re-add babel cache settings to webpack

* Re-add production browserlist in babel config

* re-add babel hot refresh config

* fix storybook
2021-11-18 16:38:58 +00:00
Josh Hunt bfec79a7dc Chore: Improve wording of 'Now delay' option (#41368)
* Chore: Improve wording of 'Now delay' option

* Feedback
2021-11-15 16:08:28 +01:00
Josh Hunt ecb877cb24 Snapshots: Fix panel inspector for snapshot data (#41530) 2021-11-10 12:40:04 +01:00
Josh Hunt cbc00babe4 Dashboards: Fix 'Copy' from being appended to new dashboard titles (#41344) 2021-11-05 11:05:47 +00:00
Josh Hunt 9fc5193ecd Dashboard: Disable image renderer link for unsaved dashboards (#41249) 2021-11-03 12:17:16 +01:00
Josh Hunt 14ddb2939c Chore: Enable strict Typescript checks (#41198)
* Chore: Enable strict Typescript checking

* Chore: Remove old strict budget checks
2021-11-02 15:23:44 +00:00
cb948d10e0 CloudWatch: Fix strict Typescript errors (#41160)
* CloudWatch: Fix strict typscript errors

* Update public/app/plugins/datasource/cloudwatch/components/ConfigEditor.tsx

Co-authored-by: Sarah Zinger <sarahzinger@users.noreply.github.com>

* Chore: reduce strict error

* Update ci-check-strict.sh

Co-authored-by: Sarah Zinger <sarahzinger@users.noreply.github.com>
Co-authored-by: Hugo Häggmark <hugo.haggmark@gmail.com>
2021-11-02 13:16:46 +00:00
Josh Hunt 419c465edf Grafana-UI: Editor UI components (#41136)
* Grafana-UI: Update theme.spacing to support string value when called with just one arugment

This allows theme.spacing("auto") to be valid

* Grafana-UI: Support width="auto" for Select component

This allows for inline Selects that are sized based on their content,
rather than occupying block-width

* Add toOption for creating Select options to @grafana/data

* Add test util
2021-11-01 12:06:28 +01:00
Josh Hunt 90b802a62d AzureMonitor: Prevent incomplete Logs queries from running (#40512)
* AzureMonitor: Prevent incomplete queries from running

* fix
2021-10-25 17:37:50 +02:00
Josh HuntandAlex Khomenko d5a0f719df Grafana-UI: Move Select container styles to outer most container (#40611)
* Grafana-UI: Move Select container styles to outer most container

* Update packages/grafana-ui/src/components/Select/Container.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>

* Rename file

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
2021-10-19 13:29:33 +02:00
Josh Hunt b3196621f1 AzureMonitor: Fix template variables being cleared out (#39173)
* AzureMonitor: Fix template variables being cleared out

* fix metric namespace from resetting

* tests :)
2021-09-15 16:31:37 +01:00
Josh Hunt 17306217aa AzureMonitor: Support PostgreSQL and MySQL Flexible Servers (#38075) 2021-08-19 16:56:58 +02:00
Josh Hunt 1e221b6452 AzureMonitor: Show error message when subscriptions request fails in ConfigEditor (#37837)
* Fix jsdoc description for datasourceRequest

* Align default subscription width with other fields

* AzureMonitor: Show error message when requesting default subscriptions in ConfigEditor

* update snapshots:
2021-08-17 16:46:15 +01:00
Josh Hunt afabc617ed AzureMonitor: Apply query migrations in QueryEditor (#37704)
* move query migrations out of the angular controller

* Migrate queries in QueryEditor

* finish up migrations

* update deprecated comment

* remove comment
2021-08-17 14:03:18 +02:00
Josh Hunt 368da73ac4 AzureMonitor: Fix crash from infinite render loop (#37924) 2021-08-17 11:50:37 +01:00
Josh Hunt 81cfc2c347 AzureMonitor: Use React QueryEditor for annotations editor (#37633) 2021-08-13 11:05:57 +01:00
Josh Huntandachatterjee-grafana 88487806e3 Docs: Clarify how to enable "Forward OAuth Identity" for data sources (#37696)
* Docs: Clarify how to enable "Forward OAuth Identity" for data sources

* Update docs/sources/developers/plugins/add-authentication-for-data-source-plugins.md

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* Update add-authentication-for-data-source-plugins.md

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
2021-08-09 17:22:40 +01:00
Josh Hunt f41f45f6bf AzureMonitor: Remove Angular query editor (#37532)
* Remove angular query editor

* call debounced onRunQuery, and set some default query values
2021-08-05 10:12:25 +01:00
Josh Hunt e530d66275 AzureMonitor: Refactor query state and fetching data for Metrics (#37067)
* Split query modifications into seperate file

* seperate setQueryValue for Logs

* wip for centralising api requests

* more wip

* moved data hooks out into seperate module, added post-request cleanup

* metric metadata

* ,

* more cleanup

* update tests, fix hasOption to work with grouped variables

* update ARG subscriptiopns field

* last select stuff

* remove todo comment

* pr feedback

* more pr feedback :) :)

* updated comment
2021-08-03 10:04:04 +01:00
Josh Hunt 43ee7acecd AzureMonitor: Make all query properties optional (#36701)
* start to make all query fields optional

* fix other types

* fix optional types in fields

* Pfeedback!

* Clean up types
2021-07-14 12:36:11 +02:00
Josh Hunt a2a1fa51f2 AzureMonitor: Resource Picker alignment/spacing tweaks (#35125) 2021-07-08 16:37:41 +02:00
Josh Hunt 4c0acf335b Grafana-UI: Refactor Checkbox to fix alignment issues (#36164)
* Grafana-UI: Fix Checkbox vertical layout issues

* reorganise css

* WIP for fixing checkboxes in manage dashboards

* Cleanup checkbox and fix issue in Dashboard manage page

* update tests
2021-07-08 14:09:58 +02:00
Josh HuntandRobby Milo eabf3fb674 Docs: Fix Azure Monitor refs (#36458)
* Docs: Fix Azure Monitor refs

* more fixes

Co-authored-by: Robby Milo <robbymilo@gmail.com>
2021-07-06 10:27:32 -04:00
Josh Hunt 2a4191a2ee AzureMonitor: Fix issue where resource group name is missing on the resource picker button (#36400)
* AzureMonitor: Fix issue where resource group name is missing in the UI

* fix
2021-07-06 11:22:47 +02:00
Josh Hunt 227c11d37f Grafana-Toolkit: Improve error messages when tasks fail (#36381) 2021-07-06 10:07:17 +01:00
ca5379d64d AzureMonitor: Refresh documentation (#35371)
* AzureMonitor: Refresh documentation

* logs/kusto

* finish up logs

* variables for log analytics

* Apply suggestions from code review

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* finish up main topics

* finish docs?

* typos and other review comments

* add link to sample arg queries

* split up azure docs

* workaround weird code duplication issue

* Update docs/sources/datasources/azuremonitor/template-variables.md

Co-authored-by: Sarah Zinger <sarahzinger@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* feedback

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
Co-authored-by: Sarah Zinger <sarahzinger@users.noreply.github.com>
2021-07-02 15:56:20 +01:00
Josh Hunt fcb4e5a211 Grafana-UI: Remove references to old monaco libraries (#35557) 2021-06-22 11:52:08 +01:00
Josh Hunt 4cdcb3103a AzureMonitor: Fix workspace template variable queries without default workspace (#35836) 2021-06-17 10:19:27 +01:00
Josh Huntandachatterjee-grafana 8a0cef9954 AzureMonitor: Update documentation and v8 Whats New (#35275)
* AzureMonitor: Update documentation and v8 Whats New

* update docs, provisioning:

* minor updates, mainly images

* fix typos

* fixes

* few other minor fixes

* Update docs/sources/datasources/azuremonitor.md

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* Update azuremonitor.md

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
2021-06-07 21:59:32 +01:00
Josh Hunt 5fb37ad5dc AzureMonitor: Fix permissions issue with Logs template variable queries (#35181) 2021-06-03 15:22:13 +01:00
Josh Hunt 32d9b04666 Grafana-UI: Fix checkbox vertical alignment (#35124)
* Grafana-UI: Fix Checkbox vertical layout issues

* reorganise css

* revert my 'fix' and just go back to setting a min height :(
2021-06-03 15:37:59 +03:00
Josh Hunt 3be0a2d328 AzureMonitor: Use resource type display names in the UI (#35060)
* AzureMonitor: Use display names for resource types and locations

* de-pluralize resource types

* Rename Namespace field to Resource Type, and use display names

* add comments
2021-06-02 12:47:04 +02:00
Josh Hunt 888cddb834 AzureMonitor: Support querying Subscriptions and Resource Groups in Logs (#34766)
* AzureMonitor: Support querying Subscriptions and Resource Groups in Logs

* cleanup
2021-05-28 08:58:46 +01:00
Josh Hunt 7646246d8c AzureMonitor: Hide App Insights for data sources not using it (#34725)
* AzureMonitor: Hide Application Insights and Insights Analytics for panels not using them

* AzureMonitor: Hide Application Insights config

* simplify

* fix test
2021-05-27 20:28:36 +01:00
Josh Hunt b4ce068f0e AzureMonitor: Display variables in Logs resource picker (#34648)
* AzureMonitor: Display variables in Resource Picker

* tests

* hide template variable group when there's no template variables
2021-05-26 09:42:17 +01:00
Josh Hunt 1d3bcb0e90 AzureMonitor: ResourceMonitor children refactor (#34591)
* AzureMonitor: Refactor children to be an arrayu

* Add some resourcePickerData tests

* update tests

* some quick NestedResourceTable tests
2021-05-25 07:51:48 +01:00
Josh Hunt cf94410e59 AzureMonitor: Update Logs workspace() template variable query to return resource URIs (#34445)
* Migrate template variables straight into resource field,

Display error if unable to migrate

* Update workspace() template variable query function to return a resource URI

* update backend to support resource uris in workspace field

* don't load resource names for variables

* throw error when workspace migration returns no results

* update testDatasource to work with either resource URI or workspace GUID

* fix tests

* cleanup types just a little bit, as a treat
2021-05-20 10:16:29 +02:00
Josh HuntandSarah Zinger 5dca9fd4d8 AzureMonitor: Support querying any Resource for Logs queries (#33879)
* wip

* wip:

* ui work for resource picker

* disable rows when others are selected

* resource picker open button

* Azure Monitor: Connect to backend with real data (#34024)

* Connect to backend with real data

* Fixes from code review.

* WIP:Begin thinking about how to make queries with scope determined by the resource picker

* More fixes post code review.

* Fixes after rebasing

* Remove outdated todo

* AzureMonitor: Support any resource for Logs queries (#33762)

* Apply button for resource picker

* scroll table body

* secondary cancel button

* loading state for nested rows

* Display resource components in picker button

* fix tests

* fix icons

* move route function

* Migrate from workspace to resource uri for log analytics (#34337)

* reword backwards compat comment

* remove base url suffix

* fix lint error

* move migrations to seperate file

* cleanup

* update regex

* cleanup

* update plugin routes to use new azure auth type

* use AzureDataSourceInstanceSettings alias

Co-authored-by: Sarah Zinger <sarahzinger@users.noreply.github.com>
2021-05-19 17:39:08 +01:00
Josh Hunt 679001051b AzureMonitor: Revert back to editable Angular interfaces for both App Insights queries (#33943) 2021-05-12 09:32:35 +02:00
Josh Hunt 72c9d806fd AzureMonitor: Kusto language support (#33528)
* Add Kusto custom language to Monaco

* Load Kusto schema into monaco

* cleanup + tests

* cleanup + tests

* cleanup :)

* move monaco languages to a registry
2021-05-11 16:48:59 +02:00
Josh Hunt 8333c55bee AzureMonitor: Create read-only React view for Insights Analytics (#33719)
* AzureMonitor: Create read-only React view for Insights Analytics

* Fix spacing
2021-05-06 21:11:27 +02:00
Josh Hunt f121e3a281 Grafana-UI: Create Grafana themes for Monaco (#33716)
* Grafana-UI: Update monaco theme to use Grafana colours

* _variables changes

* comment where the colour names come from
2021-05-05 13:10:42 +02:00
Josh Hunt ef9f99645d Bump version in latest.json (#33500) 2021-04-28 21:26:34 +01:00
Josh HuntandRyan McKinley a13c5380a7 Grafana-UI: Switch CodeEditor to UMD @monao-editor/react (#33204)
* Grafana-UI: Switch CodeEditor to @monao-editor/react

* update copy script and paths

* hide context menu

* use __grafana_public_path__

* Fix value and language not updating

* update jaeger tsconfig

* update tsconfig

Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2021-04-27 17:34:56 +01:00
Josh Hunt 0463164f8c Grafana-UI: Type onEditorDidMount (#33178) 2021-04-21 11:16:54 +02:00
Josh Hunt a7d18bbc89 AzureMonitor: Add support for Virtual WAN namespaces (#32935)
* AzureMonitor: Add support for additional Microsoft.Network namespaces

* Update supported_namespaces.ts

* Update supported_namespaces.ts
2021-04-13 15:24:58 +01:00
Josh Hunt d2bdb4ed41 AzureMonitor: Convert Logs to React (#32315)
* Convert Logs to React

* copy changes

* fix effect deps

* tests for logs

* remove any from test

* Update QueryEditor.tsx
2021-04-13 15:29:32 +02:00
Josh Hunt 21879410ab Grafana-UI: allow pass through of monaco options (#32763) 2021-04-08 14:02:00 +01:00
Josh HuntandHugo Häggmark 95470d7302 AzureMonitor: Refactor datasource.query to fix --strict error (#32416)
* fix --strict in datasource.ts

* Update public/app/plugins/datasource/grafana-azure-monitor-datasource/datasource.ts

Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>

Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
2021-04-07 09:25:33 +01:00
Josh HuntandMarcus Efraimsson 5289603a59 AzureMonitor: fix migration error from older versions of App Insights queries (#32372)
* AzureMonitor: fix nill reference error with missing timeGrain

* add a test

Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
2021-04-06 11:33:46 +01:00
Josh Hunt 9a7c10cffe AzureMonitor: display errors from requests for the dropdowns (#31921)
* AzureMonitor: display errors from requests for the dropdowns

* switch to array of errors, using just the last one

* unify error object

* move files into utils

* TESTS

* fix tests
2021-03-24 12:06:55 +00:00
Josh Hunt f1917f81b9 AzureMonitor: use undefined for empty Metrics values in jsonData (#32230)
* Remove old angular Metrics view controller code

* Make Metrics unset fields "undefined"

* add checks for 'select' in filterQuery

* fix tests
2021-03-23 12:31:04 +00:00
Josh Hunt 7389b2ecac Grafana-UI: Allow <Select /> value to be unset (#32136)
* Fix: Allow <Select /> value to be unset

* clean up

* fix null object in select onChange

* Revert "fix null object in select onChange"

This reverts commit 4b157073884938e5e6a1fac1bbafa7c6017cb361.

* undo onChange arg type change

* fix tests
2021-03-22 14:45:27 +00:00
Josh Hunt 2fb92789e7 Query editor: avoid avoiding word wrap on query editor components (#31949) 2021-03-15 10:15:14 +00:00
Josh Hunt 13a47aede2 AzureMonitor: Migrate Metrics query editor to React (#30783)
* AzureMonitor: Remove anys from datasource to get the inferred type

* AzureMonitor: Cast some datasource types

TODO: we want proper types for these

* AzureMonitor: Initial react Metrics editor components

* start dimension fields

* replace replaceTemplateVariable with datasource.replace, and rename onQueryChange to onChange

* actually just do template variable replacement in the datasource

* don't use azureMonitorIsConfigured

* Refactors, mainly around the metric metadata

 - Convert all the metric metadata options for the Select before its set into state
 - Stop using SelectableValue because it's basically any when all the properties are optional
 - the onChange function passed to the fields now just accepts the direct value, rather than wrapped in a SelectableValue

* added proper fields, and adding and removing for DimensionFields

* Update query with Dimension changes

* Width

* subscription and query type fields

* Should be feature complete now, more or less

* fix missing import

* fix lint issues

* set default subscription ID

* Starting to write some tests

* tests for query editor

* Remove subscription ID from the label in Metrics

But we keep it there for the angular stuff

* MetricsQueryEditor tests

* Update index.test.tsx

* fix tests

* add template variables to dropdowns

* clean up

* update tests

* Reorganise react components

* Group query fields into rows

* Rename Option type, add Azure response type

* Refactor Metrics metric metadata

 - Types the Azure API
 - Moves default metadata values into datasource

* nit

* update test
2021-03-11 11:37:39 +00:00
Josh Hunt a51cc050e2 Chore: type backendSrv.datasourceRequest (#31870) 2021-03-10 20:52:25 +01:00
Josh Huntandachatterjee-grafana d566d2e164 AzureMonitor: Add deprecation message for App Insights/Insights Analytics (#30633)
* AzureMonitor: Add deprecation message for Application Insights/Insights Analytics

relates to #30184

(also some prettier changes came along for the ride)

* reorder query type options

* Rearrange documenation, move Logs up

* Fix Logs heading

* deprecation documentation

* finish up docs

* update link

* Apply doc suggestions from code review

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* Update docs/sources/datasources/azuremonitor.md

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>

* clean up docs

Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
2021-03-04 09:46:44 +01:00
Josh Hunt 85e186cf10 Grafana-UI: Add id to Select to make it easier to test (#31230)
* Prettier formatting

* Grafana-UI: Add support for id and inputId props to Select

* Grafana-UI: Add aria-label to Select

* Grafana-UI: InlineField and Field get ID from inputId prop

For Select

* Fix tests using TagFilter

* Update Select prop documentation

* Update Field tests to use screen instead

* Fix the last few tests
2021-02-16 16:19:55 +00:00
Josh Hunt 5218497a3e Chore: report eslint no-explicit-any errors to metrics (#31182)
* Chore: report eslint no-explicit-any errors to metrics

* double quote
2021-02-15 10:15:34 +00:00
Josh Hunt e089365abe AzureMonitor: rename labels for query type dropdown (#30143)
* AzureMonitor: rename labels for queryType dropdown

* Reorder to match original order

* Docs: rename query types

* Docs: update KQL url

* Docs: update Azure Monitor / Log Analytics names

* Update documentation to include new name

* Docs formatting

* Rename Azure Monitor config editor names

* update test snapshots
2021-01-14 12:33:41 +00:00