Commit Graph

44181 Commits

Author SHA1 Message Date
Matias Chomicki
84f94cdc24
Logs: Show active state of "filter for value" buttons in Logs Details (#70328)
* Datasource test: fix describe nesting

* Parsing: export handleQuotes function

* Modify query: add functions to detect the presence of a label and remove it

* Loki: add support to toggle filters if already present

* Datasource test: fix describe nesting

* Loki: add support to toggle filter out if present

* Remove label: handle escaped values

* Datasource: add test case for escaped label values

* Loki: remove = filter when applying !=

* Remove selector: add support for Selector node being far from Matcher

* Modify query: add unit tests

* Elasticsearch: create modifyQuery for elastic

* Elastic modify query: implement functions

* Elasticsearch: implement modifyQuery functions in datasource

* Elasticsearch: update datasource test

* Loki modify query: check for streamSelectorPositions length

* Elasticsearch query has filter: escape filter value in regex

* Remove unused type

* Modify query: add functions to detect the presence of a label and remove it

* Remove label: handle escaped values

* Logs: create props to check for label filters in the query

* Log Details Row: use label state props to show visual feedback

* Make isCallbacks async

* Explore: add placeholder for checking for filter in query

* Datasource: define new API method

* Inspect query: add base implementation

* Remove isFilterOutLabelActive as it will not be needed

* Check for "isActive" on every render

Otherwise the active state will be out of sync

* Elasticsearch: implement inspectQuery in the datasource

* Logs: update test

* Log details: update test

* Datasources: update tests

* Inspect query: rename to analize query to prevent confusion

* Datasource types: mark method as alpha

* Explore: add comment to log-specific functions

* Remove duplicated code from bad rebase

* Remove label filter: check node type

* getMatchersWithFilter: rename argument

* Fix bad rebase

* Create DataSourceWithQueryManipulationSupport interface

* Implement type guard for DataSourceWithQueryManipulationSupport

* DataSourceWithQueryManipulationSupport: move to logs module

* hasQueryManipulationSupport: change implementation

`modifyQuery` comes from the prototype.

* DataSourceWithQueryManipulationSupport: expand code comments

* AnalyzeQueryOptions: move to logs module

* DataSourceWithQueryManipulationSupport: add support for more return types

* Fix merge error

* Update packages/grafana-data/src/types/logs.ts

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>

* DatasourceAPI: deprecate modifyQuery

* Explore: refactor isFilterLabelActive

* DataSourceWithQueryModificationSupport: rename interface

* Split interfaces into Analyze and Modify

* Query analysis: better name for interface

* Fix guard

* Create feature flag for active state

* Use new feature flag in Explore

* DataSourceToggleableQueryFiltersSupport: create a specific interface for this feature

* Rename feature flag

* De-deprecate modifyQuery

* DataSourceToggleableQueryFiltersSupport: Rethink types and methods

* Explore: adjust modifyQuery and isFilterLabelActive to new methods

* Loki: implement new interface and revert modifyQuery

* DataSourceToggleableQueryFiltersSupport: better name for arguments

* Elasticsearch: implement new interface and revert modifyQuery

* Loki: better name for arguments

* Explore: document current limitation on isFilterLabelActive

* Explore: place toggleable filters under feature flag

* Loki: add tests for the new methods

* Loki: add legacy modifyQuery tests

* Elasticsearch: add tests for the new methods

* Elasticsearch: add legacy modifyQuery tests

* Toggle filter action: improve type values

* Logs types: update interface description

* DataSourceWithToggleableQueryFiltersSupport: update interface name

* Update feature flag description

* Explore: add todo comment for isFilterLabelActive

---------

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
2023-07-24 11:22:47 +03:00
github-actions[bot]
719f6bc520
Update make docs procedure (#72180)
Co-authored-by: grafanabot <bot@grafana.com>
2023-07-24 09:19:37 +01:00
Esteban Beltran
a5cf278263
Docs: Update instructions for local publishing grafana npm packages (#72110) 2023-07-24 09:43:31 +02:00
Guilherme Caulada
f005a375db
CI: Run only Grafana builds on RGM for grafana/grafana (#72144)
* Run only OSS builds on RGM for grafana/grafana

* Update script name

* Ignore windows step failure for RGM
2023-07-21 15:50:06 -05:00
David Harris
0589060041
docs: fix broken link (#72114) 2023-07-21 16:49:57 -04:00
Andreas Christou
c4d6509145
CloudMonitoring: Correctly set title and text fields for annotations (#71888)
Correctly set title and text fields
2023-07-21 20:42:42 +00:00
Nathan Marrs
8c86a46440
Phlare: Set enum field type to enum instead of integer (#72078)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2023-07-21 13:08:23 -05:00
Nathan Marrs
9a6a739003
TestData: Update Flame Graph scenario to use enum field type for label (#72082)
Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
2023-07-21 20:27:23 +03:00
Eva
b88a321ad2
Update _index.md (#72068)
* Update _index.md 

Edits to the "Set up image rendering" doc.

1. First section, "Set up Image Rendering," last paragraph:
"You can also render a PNG by clicking hovering..." -- I removed "clicking" from that sentence.

2. "Alerting and Render Limits" section, link for "concurrent_render_limit" takes you to the page but not the section. This seems to be the case for all section links on this "Configure Grafana" page. I'm not sure how to fix it but switched from a relative link to a full path to see if that would help.

3. "Install Grafana Image Renderer Plugin," the link goes to the plugin overview page instead of the installation page. I tried adding the full path to see if that would go to the installation tab.

4. "Configuration" section, the same as the second edit I made, the first link, "Grafana configuration file," goes to the page but not the section link. I switched the relative path to a full path to see if it would work.

5. "Security" section, the very last sentence has the same Grafana configuration page link that goes to the correct page but not the correct section, "Grafana configuration" for the renderer token section. Same as previous ones, I switched out the relative path for the full path.

6. "Start browser with additional arguments," the second link in the first paragraph that goes to Puppeteer list of Chromium flags went to a 404 page. I couldn't figure out where they had moved it so I found a different site with a list of default flags and used that link instead.

* corrects links

* updates links

* fixes anchor link

---------

Co-authored-by: Chris Moyer <chris.moyer@grafana.com>
2023-07-21 12:23:32 -05:00
Leon Sorokin
1de35bf3c3
TimeSeries / StateTimeline: Add support for rendering enum fields (#64179)
Co-authored-by: nmarrs <nathanielmarrs@gmail.com>
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
2023-07-21 11:38:11 -05:00
Usman Ahmad
4e50115d95
Update _index.md (#71400)
* Update _index.md

Added missing hyperlink for high availability and a small typo

* updates link

---------

Co-authored-by: Chris Moyer <chris.moyer@grafana.com>
2023-07-21 11:34:30 -05:00
Ryan McKinley
10ea92fa09
Schemas: minor updates from the k8s branch (#71688)
Co-authored-by: sam boyer <sdboyer@grafana.com>
2023-07-21 19:17:11 +03:00
Ludovic Viaud
6c1346cbc1
Devenv: add exemplar to self-instrumentation (#72069) 2023-07-21 18:02:20 +02:00
Ludovic Viaud
7ec3489cd3
Plugins Instrumentation: add exemplar to the plugin requests metrics (#72071)
* Plugins Instrumentation: add exemplar to the plugin requests metrics
2023-07-21 18:01:29 +02:00
Josh Hunt
65d8ea9beb
Chore: Use GITHUB_TOKEN in issue-labeled instead of grot token (#72127) 2023-07-21 17:52:02 +02:00
Josh Hunt
504d5352bc
Chore: Use GITHUB_TOKEN in pr-commands instead of grot token (#72125)
Use GITHUB_TOKEN instead of grot token
2023-07-21 16:41:22 +01:00
Isabella Siu
56913fbd95
Redshift: Support caching async aws queries (#71682)
Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>
2023-07-21 11:34:07 -04:00
Josh Hunt
3457ccbf12
FolderPicker interaction reporting (#71896)
* FolderPicker interaction reporting

* rename event
2023-07-21 18:23:05 +03:00
Josh Hunt
a5016c9e88
NestedFolders: API improvements for NestedFolderPicker (#72093)
* NestedFolders: Prepare nested folder picker for more usage

* fix betterer results

* Update usage of NestedFolderPicker

* fix tests

* fix betterer
2023-07-21 15:40:39 +01:00
Ieva
cfa1a2c55f
RBAC: Split non-empty scopes into kind, attribute and identifier fields for better search performance (#71933)
* add a feature toggle

* add the fields for attribute, kind and identifier to permission

Co-authored-by: Kalle Persson <kalle.persson@grafana.com>

* set the new fields when new permissions are stored

* add migrations

Co-authored-by: Kalle Persson <kalle.persson@grafana.com>

* remove comments

* Update pkg/services/accesscontrol/migrator/migrator.go

Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>

* feedback: put column migrations behind the feature toggle, added an index, changed how wildcard scopes are split

* PR feedback: add a comment and revert an accidentally changed file

* PR feedback: handle the case with : in resource identifier

* switch from checking feature toggle through cfg to checking it through featuremgmt

* don't put the column migrations behind a feature toggle after all - this breaks permission queries from db

---------

Co-authored-by: Kalle Persson <kalle.persson@grafana.com>
Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>
2023-07-21 15:23:01 +01:00
Ieva
59eb2f68b7
AuthN: Lock down manual role updates for users synced through Grafana Com portal (#72044)
take into account auth.grafananet config section when checking if gcom auth is enabled
2023-07-21 15:22:28 +01:00
Jack Baldry
12f7524c86
Update doc-validator to fix suggestions involving anchors (#72108)
Suggestions for relref link fixes were missing the anchors.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
2023-07-21 15:21:19 +01:00
Joao Silva
1f86dde818
Timezone: Add exception for Simferopol timezone description (#72112) 2023-07-21 15:02:54 +01:00
Kevin Minehart
16e2808b43
CI: Use GCP keys in vault and not drone secrets (#72023) 2023-07-21 08:53:57 -05:00
Josh Hunt
f3235ba959
NestedFolders: Rename FolderPicker to OldFolderPicker (#72098)
* Rename FolderPicker to OldFolderPicker

* fix jest mock

* fix jest mock
2023-07-21 13:24:43 +00:00
Josh Hunt
b9fc097ccd
NestedFolderPicker: Fix forms being submitted when opening folder picker (#72109)
Fix NestedFolderPicker submitting forms when opened
2023-07-21 15:57:09 +03:00
Ashley Harrison
f078a0bb40
NestedFolderPicker: Allow for excluding certain uids (#72019)
* exclude some uids from nested folder picker so you can't move a folder to itself

* rename excludedUids to excludeUIDs
2023-07-21 13:10:23 +01:00
Ashley Harrison
8f464ac66e
NestedFolderPicker: Correctly handle pagination (#72030)
correctly handle pagination in the folder picker when there is more than 1 page of dashboards
2023-07-21 13:08:19 +01:00
Gareth Dawson
4e42f9b619
Loki: Add the ability to prettify logql queries (#64337)
* pushed to get help of a genius

* fix: error response is not json

* feat: make request on click

* refactor: remove print statement

* refactor: remove unnecessary code

* feat: convert grafana variables to value for API request

* use the parser to interpolate and recover the original query (#64591)

* Prettify query: use the parser to interpolate and recover the original query

* Fix typo

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

* Fix typo

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>

* fix: reverse transformation not working

---------

Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
Co-authored-by: Gareth Dawson <gwdawson.work@gmail.com>

* fix: bugs created from merge

* refactor: move prettify code out of monaco editor

* fix: variables with the same value get converted back to the incorect variable

* refactor

* use consistent styling with bigquery

* fix: only allow text/plain and application/json

* fix: only make the request if the query is valid

* endpoint now returns application/json

* prettify from js

* WIP: not all cases are handles, code still needs cleaning up

* WIP

* large refactor, finished support for all pipeline expressions

* add tests for all format functions

* idk why these files changed

* add support for range aggregation expr & refactor

* add support for vector aggregation expressions

* add support for bin op expression

* add support for literal and vector expressions

* add tests and fix some bugs

* add support for distinct and decolorize

* feat: update variable replace and return

* fix: lezer throws an errow when using a range variable

* remove api implementation

* remove api implementation

* remove type assertions

* add feature flag

* update naming

* fix: bug incorrectly formatting unwrap with labelfilter

* support label replace expr

* remove duplicate code (after migration)

* add more tests

* validate query before formatting

* move tests to lezer repo

* add feature tracking

* populate feature tracking with some data

* upgrade lezer version to 0.1.7

* bump lezer to 0.1.8

* add tests

---------

Co-authored-by: Matias Chomicki <matyax@gmail.com>
Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>
2023-07-21 13:03:56 +01:00
Matias Chomicki
c84d689ce0
Loki: Enable Query Splitting by default (#72094)
* lokiQuerySplitting: enable feature flag by default

* Query stats: add special note for stats + splitting
2023-07-21 13:53:10 +02:00
Jack Westbrook
6ac664ecf7
Chore: Update Semver to latest versions (#72086)
chore(npm): bump all versions of semver to their latest respective version
2023-07-21 12:40:45 +02:00
Kyle Brandt
1df4d332c9
SSE: Use errutil to show better error messages in prod (#71658)
- include public message
- propagate data source query errors so they are shown as well to which fixes #70026
2023-07-21 06:38:29 -04:00
RoxanaAnamariaTurc
eea18d6741
Datetime: Added more tests to the files in the datetime folder (#71731)
* Datetime: Added more tests to the files in the datetime folder

* Updated tests suites according to feedback received

* Corrected the lint error

* Removed repetitive code
2023-07-21 11:24:22 +01:00
RoxanaAnamariaTurc
e7ad60bfc7
A11Y: Added the name of the section to collapse button for screenreader (#72010)
A11Y: Added the name of the section  to aria-label of the button to collapse or expand section in the navigation tree
2023-07-21 09:54:48 +01:00
Ashley Harrison
01369e6aff
Chore: fix .eslintignore to only ignore folder paths at the root (#72032)
fix eslintignore to only ignore folder paths at the root
2023-07-21 09:17:42 +01:00
George Robinson
892a0d2e5e
Update logrus to v1.9.3 (#71571) 2023-07-21 09:37:20 +02:00
Andres Martinez Gotor
6f445eca8a
Chore: Remove liveTimer reference from testdata (#71997) 2023-07-21 09:18:41 +02:00
Alexander Weaver
ff48a145cc
Alerting: Add exported getters for PanelKey fields (#72064)
Add getters
2023-07-20 15:47:20 -05:00
William Wernert
dfb040d842
CI: Add GitHub workflow to schedule a PR with changes to Alerting Swagger spec (#71794)
* add github workflow to schedule alerting swagger spec pr

* also generate stable api spec
2023-07-20 22:31:20 +03:00
Yuri Tseretyan
cbbbe2e6f6
SSE: DSNode to update result with names to make each value identifiable by labels (only Graphite and TestData) (#71246)
* introduce a function checkIfSeriesNeedToBeFixed to scan all value fields in the response and provide a function that updates Series so they can be uniquely identifiable. Only Graphite and TestData are checked.

* update `convertDataFramesToResults` to run this function and provide it to WideToMany
* update WideToMany to run the fix function if it is not nil
2023-07-20 14:44:12 -04:00
Matthew Jacobson
13121d3234
Alerting: Add contact point provisioning file export (#71692)
* Add contact point provisioning file export apis

* Regenerate api

* docs

* frontend

* add mock to tests

* Fix missing row-level export button on viewer role w/ prov. read

* Address review comments

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
2023-07-20 14:35:56 -04:00
Isabel
a7c639f16e
docs: update incorrect front matter labels (#71974)
* update incorrect front matter labels

* removing unneeded labels from shared content files

* change public preview to private preview for email sharing

* add OSS back to product labels
2023-07-20 14:05:58 -04:00
Christopher Moyer
46c49aa7ff
Docs: adds mimir and oncall (#72042)
adds mimir and oncall
2023-07-20 12:01:55 -05:00
Clément Duveau
62c6e04d70
Docs: fix broken links (#71911)
* Fix different broken links and missing pages

* Pin version in docs link for release announcements

* fixing validator error

---------

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
2023-07-20 12:39:59 -04:00
Laura Fernández
c24b538b4e
Grafana-ui: TextLink documentation (#71762) 2023-07-20 17:48:46 +02:00
Michael Mandrus
e8093cb11a
Config: Add [aws][external_id] to ini files (#72026)
add mention of aws external id to ini files
2023-07-20 10:37:41 -04:00
Josh Hunt
78869fae7c
NestedFolders: Select style for closed nested folder picker (#71959)
* make unexpanded nested folder picker look like a select

* fix prefix icon

* placeholder style, only show input label if value selected

* aria-label

* text component
2023-07-20 17:33:42 +03:00
Agnès Toulet
264cbb402c
Kinds: rework verify-kinds to reduce GH API calls (#71304)
* Kinds: rework verify-kinds to reduce GH API calls

* Clean up and apply review feedback
2023-07-20 15:26:00 +02:00
Fabrizio
ef82932f48
Plugins: Remove logs button instead of disabling it (#71448) 2023-07-20 14:28:16 +02:00
Galen Kistler
1c358de190
Prometheus: Fix heatmap query format (#71971)
Check first numeric field instead of name: Value 

---------

Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
2023-07-20 15:09:40 +03:00